Re: [O] [Patch] Support for dimming local to each agenda

2017-07-14 Thread Nicolas Goaziou
Nicolas Goaziou writes: > Yuri Lensky writes: > >> Why not save mark? > > We usually do not mess with it, unless this is explicit in the function > documentation, e.g., `org-mark-ring-push'. > >> This allows user-defined hooks in org-blocker-hooks more

Re: [O] [Patch] Support for dimming local to each agenda

2017-07-14 Thread Nicolas Goaziou
Yuri Lensky writes: > Why not save mark? We usually do not mess with it, unless this is explicit in the function documentation, e.g., `org-mark-ring-push'. > This allows user-defined hooks in org-blocker-hooks more freedom. I'm not sure this is a sufficient reason, really.

Re: [O] [Patch] Support for dimming local to each agenda

2017-07-14 Thread Yuri Lensky
Why not save mark? This allows user-defined hooks in org-blocker-hooks more freedom. That said, I am not sure of org-mode project conventions, so if `save-excursion' is preferred I can change it to that. Thanks. On Fri, Jul 14, 2017 at 1:29 AM, Nicolas Goaziou wrote: >

Re: [O] [Patch] Support for dimming local to each agenda

2017-07-14 Thread Nicolas Goaziou
Hello, Yuri Lensky writes: > Thanks. I have attached an updated patch that addresses your points (with > some additional cleanup). Thank you. >> Why is `save-mark-and-excursion' needed? >> > Because we are moving point to get to the heading, and in principle hooks > in

Re: [O] [Patch] Support for dimming local to each agenda

2017-07-13 Thread Yuri Lensky
Thanks. I have attached an updated patch that addresses your points (with some additional cleanup). On Thu, Jul 13, 2017 at 5:51 AM, Nicolas Goaziou wrote: > Hello, > > Yuri Lensky writes: > > > Composite agenda views can now set

Re: [O] [Patch] Support for dimming local to each agenda

2017-07-13 Thread Nicolas Goaziou
Hello, Yuri Lensky writes: > Composite agenda views can now set org-agenda-dim-blocked-tasks locally. > From 52f8bf79a198fa2e7f131c2a015a7c9400a403ac Mon Sep 17 00:00:00 2001 > From: "Yuri D. Lensky" > Date: Mon, 10 Jul 2017 19:21:39 -0700 > Subject: [PATCH

[O] [Patch] Support for dimming local to each agenda

2017-07-11 Thread Yuri Lensky
Composite agenda views can now set org-agenda-dim-blocked-tasks locally. 0002-org-agenda.el-Support-for-dimming-local-to-each-agen.patch Description: Binary data