Re: [O] [RFC] Display most recent log item in Agenda

2014-12-20 Thread Nicolas Goaziou
Hello, Eric Abrahamsen e...@ericabrahamsen.net writes: I keep hammering on this but... There's still a bug in `org-log-beginning', I think maybe the same one as before. Say it's called on an empty entry, or one that only contains a property drawer and/or a planning line, and there's another

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-20 Thread Nicolas Goaziou
Eric Abrahamsen e...@ericabrahamsen.net writes: I'm not terribly worried about finding the real last state note with 100% accuracy -- as you say, that's not really possible. This would be a convenience function displaying a useful bit of information, and if it fails to do so no planes will

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-20 Thread Eric Abrahamsen
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Eric Abrahamsen e...@ericabrahamsen.net writes: I keep hammering on this but... There's still a bug in `org-log-beginning', I think maybe the same one as before. Say it's called on an empty entry, or one that only contains a property

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-19 Thread Eric Abrahamsen
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Eric Abrahamsen e...@ericabrahamsen.net writes: I thought that's what `org-log-beginning' was for: finding where the log-note list would be (drawer or no), if it exists. Not exactly. It finds where the next note is to be inserted. This may not

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-16 Thread Nicolas Goaziou
Eric Abrahamsen e...@ericabrahamsen.net writes: I thought that's what `org-log-beginning' was for: finding where the log-note list would be (drawer or no), if it exists. Not exactly. It finds where the next note is to be inserted. This may not be in front of the log-note list even if it exists

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-16 Thread Eric Abrahamsen
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Eric Abrahamsen e...@ericabrahamsen.net writes: I thought that's what `org-log-beginning' was for: finding where the log-note list would be (drawer or no), if it exists. Not exactly. It finds where the next note is to be inserted. This may not

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-15 Thread Nicolas Goaziou
Eric Abrahamsen e...@ericabrahamsen.net writes: I think this still isn't quite right. If the variable `org-log-into-drawer' is set to t, and the entry has no logdrawer property, the whole function still returns the t, which breaks `org-log-beginning'. Indeed. Fixed. Thank you. Regards,

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-15 Thread Nicolas Goaziou
Eric Abrahamsen e...@ericabrahamsen.net writes: I started with this approach for two reasons: 1) I thought collecting the list items would be simpler, and as it became more and more complicated, I didn't rethink the approach, and 2) collecting all the items is the actual feature I was after

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-15 Thread Eric Abrahamsen
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Eric Abrahamsen e...@ericabrahamsen.net writes: I started with this approach for two reasons: 1) I thought collecting the list items would be simpler, and as it became more and more complicated, I didn't rethink the approach, and 2) collecting

[O] [RFC] Display most recent log item in Agenda

2014-12-14 Thread Eric Abrahamsen
Undeterred by my previous bum patch, I'm sending more patches! Most of these are what do you think patches. 1. Ensure-org-log-into-drawer-returns-nil-or-string If the answer to my last question is make sure `org-log-into-drawer' never returns just t, then this patch does that. If that isn't the

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-14 Thread Eric Abrahamsen
Eric Abrahamsen e...@ericabrahamsen.net writes: Undeterred by my previous bum patch, I'm sending more patches! Most of these are what do you think patches. 1. Ensure-org-log-into-drawer-returns-nil-or-string If the answer to my last question is make sure `org-log-into-drawer' never

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-14 Thread Nicolas Goaziou
Hello, Eric Abrahamsen e...@ericabrahamsen.net writes: Undeterred by my previous bum patch, I'm sending more patches! Most of these are what do you think patches. 1. Ensure-org-log-into-drawer-returns-nil-or-string If the answer to my last question is make sure `org-log-into-drawer'

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-14 Thread Eric Abrahamsen
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Eric Abrahamsen e...@ericabrahamsen.net writes: Undeterred by my previous bum patch, I'm sending more patches! Most of these are what do you think patches. 1. Ensure-org-log-into-drawer-returns-nil-or-string If the answer to my last

Re: [O] [RFC] Display most recent log item in Agenda

2014-12-14 Thread Eric Abrahamsen
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Eric Abrahamsen e...@ericabrahamsen.net writes: Undeterred by my previous bum patch, I'm sending more patches! Most of these are what do you think patches. 1. Ensure-org-log-into-drawer-returns-nil-or-string If the answer to my last