Nicolas Goaziou m...@nicolasgoaziou.fr writes:
AFAIC, you can push the patches, when the above is fixed. Thank you.
Pushed:
304a5cb ox-koma-letter: Interpret #+SUBJECT.
a795d9e ox-koma-letter: Stricter subject inference
c4d4e5e ox-koma-letter: Tiny refactor
—Rasmus
--
Bang bang
Hi Nicolas,
Excellent comments. Thanks a lot!
Nicolas Goaziou m...@nicolasgoaziou.fr writes:
In this case, I suggest to change `org-koma-letter--special-headline'
into `org-koma-letter--special-tag'
I agree.
Eventually, since you're only interested in the first special tag
encountered,
Rasmus ras...@gmx.us writes:
+(defun org-koma-letter--special-tag (headline info)
+ Non-nil if HEADLINE is a special headline.
+INFO is a plist holding contextual information. Returns first
^^^
Return, per (info (elisp)Documentation
Rasmus ras...@gmx.us writes:
+ (:with-headline-opening nil nil
org-koma-letter-headline-is-opening-maybe)
I don't think this line is required.
It feels more consistent to provide the check through the definition, but
I'm not willing to pick a fight over this so it's back to just checking
Nicolas Goaziou m...@nicolasgoaziou.fr writes:
I have only tested the patch briefly as I need to actually produce a
letter. But for the letter I'm writing export works fine.
You sent a wrong patch.
Ups. Let's try again.
In the second patch I fix the no interpretation of #+SUBJECT.
Rasmus ras...@gmx.us writes:
- (cdr (assoc (org-koma-letter--get-value key)
- org-koma-letter-special-contents)))
+ (cdr (assoc-string (org-koma-letter--get-value key)
+ org-koma-letter-special-contents)))
AFAIU, this is a bugfix, so it should go in a separate
Hello,
Rasmus ras...@gmx.us writes:
I want to change the subject inference in ox-koma-letter to only happen on
top-level headlines.
Thus, in the following example the opening would be opening and not h1
as it is currently.
* opening
** h1
Typically, h1 is just there to help me organize
Hi,
I want to change the subject inference in ox-koma-letter to only happen on
top-level headlines.
Thus, in the following example the opening would be opening and not h1
as it is currently.
* opening
** h1
Typically, h1 is just there to help me organize the letter.
Any objections?
—Rasmus
Rasmus ras...@gmx.us writes:
Nicolas Goaziou m...@nicolasgoaziou.fr writes:
However, I don't think :opening setting belongs to
`org-koma-letter-headline', as it means it is potentially set each time
a headline is being processed.
The property is at most set once cf. the second clause.
By
Nicolas Goaziou m...@nicolasgoaziou.fr writes:
However, I don't think :opening setting belongs to
`org-koma-letter-headline', as it means it is potentially set each time
a headline is being processed.
The property is at most set once cf. the second clause.
The (when ...) could be moved
Nicolas Goaziou m...@nicolasgoaziou.fr writes:
I updated the patch. Perhaps the loop determination shod be moved to a
separate function to keep the template clean.
Yes, it needs to be factored out (maybe
`org-koma-letter--special-headline-p') since it is also used in
11 matches
Mail list logo
