Achim Gratz writes:
> Rasmus writes:
>> Please also apply this patch to make "make test" pass.
>
> Applied. Please always run all tests before committing.
Thanks. I only learned about it now from Aaron's link.
--
Together we will make the possible totay impossible!
Rasmus writes:
> Please also apply this patch to make "make test" pass.
Applied. Please always run all tests before committing.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net
Nicolas Goaziou writes:
> Hello,
>
> Rasmus writes:
>
>> Shoot. Fixed in attached (tested with texi2pdf).
>
> Applied. Thank you for this patch.
Please also apply this patch to make "make test" pass.
—Rasmus
--
Don't panic!!!
>From 04d90414a848a55ff602cfbc0b5f300299830732 Mon Sep 17 00:00:0
Hello,
Rasmus writes:
> Shoot. Fixed in attached (tested with texi2pdf).
Applied. Thank you for this patch.
Regards,
--
Nicolas Goaziou
Hi Rasmus,
Thanks for all the work on this patch – I haven’t had anything to say
about it really, but it looks like a really useful feature.
2014ko urriak 2an, Rasmus-ek idatzi zuen:
[...]
> PS: How can I get commit access? I'm starting to feel like the Nick K
> of the org-list.
TLDR: email
Xavier Garrido writes:
> Following the discussion here
> http://article.gmane.org/gmane.emacs.orgmode/91322/match=improved+way,
> I have quickly tested the patch and it perfectly fits my needs. So
> thanks again.
I'm happy that it works well for you.
> Just one remark : there is an undefined @r
Hi,
Following the discussion here
http://article.gmane.org/gmane.emacs.orgmode/91322/match=improved+way, I
have quickly tested the patch and it perfectly fits my needs. So thanks
again.
Just one remark : there is an undefined @ref tag in org.texi (line
10011) file that should referred to "s
Hi,
Nicolas Goaziou writes:
> It isn't very important, but you forgot full stops at the end of
> comments in the test file.
Fixed.
>> I want to discuss one more important potential issue before having the
>> patch applied. Currently, location is ignored if the included part is
>> not an env
Hello,
Rasmus writes:
> Changes are one sentence in the documentations, casing, and I changed
> the regexp so that :only-contents is valid (it's nil).
Thank you.
It isn't very important, but you forgot full stops at the end of
comments in the test file.
> Is it better now?
I think so.
> I w
Hi,
Changes are one sentence in the documentations, casing, and I changed
the regexp so that :only-contents is valid (it's nil).
Nicolas Goaziou writes:
> Rasmus writes:
>
>> It's two extra words and maybe it's helpful to make the concept clear
>> to people unfamilar with org-element. The sta
Rasmus writes:
> It's two extra words and maybe it's helpful to make the concept clear
> to people unfamilar with org-element. The statement "contents of the
> requested element", while technically clear, is only barely
> comprehensible for the uninvited.
>
> However, it's only tweo extra words,
Nicolas Goaziou writes:
>> Just out of curiosity, what is an example of a element that can be
>> named and does not have a :contents-begin?
>
> #+name: empty-drawer
> :DRAWER:
> :END:
Thanks.
>> Okay, there's a lot of improvements in that suggestion. However, it
>> misses this case whic
Hello,
Rasmus writes:
> Thanks for the comments. I hope I addressed the previous comments and
> did not introduce new reasons bugs.
> I added tests.
Great.
> Just out of curiosity, what is an example of a element that can be
> named and does not have a :contents-begin?
#+name: empty-drawer
Hi,
Thanks for the comments. I hope I addressed the previous comments and
did not introduce new reasons bugs.
I added tests.
Comments on comments follow.
Nicolas Goaziou writes:
>> Okay, I hope I got it now. It's a rather forgiving regexp in terms of
>> mistakes. Is that OK?
>
> Please no "
Hello,
Rasmus writes:
> Okay, I hope I got a better patch here.
Thank you. Some comments follow.
> Nicolas Goaziou writes:
>> This should be ":only-contents t" or ":only-contents nil".
>> ":only-contents" alone can be tolerated as a shortcut for
>> ":only-contents nil", but that's all.
>
> Ok
Hi,
Okay, I hope I got a better patch here. I do — for sure — present
another dreadfully long email! Let's start.
Nicolas Goaziou writes:
>>> #+INCLUDE: file.org::#custom_id :noheadline :lines "3-"
>
> Is it `:only-contents' or `:no-headline'? Also ":kwd1 :kbd2 value" is
> usually a shortcut
Rasmus writes:
>> You cannot enforce `org-mode' as the current major mode since you can
>> include other file types.
>
> But then I can't use org-element-at-point:
>
> (with-temp-buffer
> (text-mode) (insert "* test\nmy txt") (goto-char (point-min))
> (org-element-at-point))
>
> (with-temp-buf
Hi,
A short comment.
Nicolas Goaziou writes:
>> + (org-export--prepare-file-contents file location
>> only-contents lines
>
> Couldn't location, only-contents and lines be merged into a single
> argument? At the moment, you are either short-circuiting or breaking
> gua
Hello,
Rasmus writes:
> Rasmus writes:
>
>> This patch allows INCLUDE to have intuitive links as resolved by
>> `org-link'-search'. A couple of examples:
Thanks for the patch. Some comments follow.
>> #+INCLUDE: file.org::#custom_id :noheadline :lines "3-"
Is it `:only-contents' or `:no-hea
Hi,
Rasmus writes:
> This patch allows INCLUDE to have intuitive links as resolved by
> `org-link'-search'. A couple of examples:
>
> #+INCLUDE: file.org::#custom_id :noheadline :lines "3-"
> #+INCLUDE: file.org::*headline :lines "-10"
>
> :noheading tries to get rid of the first headline, and
Hi,
This patch allows INCLUDE to have intuitive links as resolved by
`org-link'-search'. A couple of examples:
#+INCLUDE: file.org::#custom_id :noheadline :lines "3-"
#+INCLUDE: file.org::*headline :lines "-10"
:noheading tries to get rid of the first headline, and immediately
subsequent drawer
21 matches
Mail list logo
