Re: [O] Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)]
Hello, Renato Ferreira writes: > Investigating an issue I was having with (org-resolve-clocks) that i would > need to resolve the same clock twice, i believe i stumbled upon the > following bug on (org-files-list) (used by (org-resolve-clocks)): > > It gets a list from (org-agenda-files) and pushes the open org > buffers found through (buffer-list), but i believe it _incorrectly_ uses > (cl-pushnew) since it ultimately uses memql (which compares with eql) to > check existence of the buffer file name (a string) with the > (org-agenda-files) list (of strings), returning duplicate items on lists > since compared strings are not the same lisp objects. > > Advising (org-files-list) with (delete-dups) is a workaround i'm using but > (org-files-list) needs to be changed to use member instead of memql. Fixed. Thank you. Regards, -- Nicolas Goaziou
[O] Bug: org-files-list duplicate files [9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/)]
Hello, Investigating an issue I was having with (org-resolve-clocks) that i would need to resolve the same clock twice, i believe i stumbled upon the following bug on (org-files-list) (used by (org-resolve-clocks)): It gets a list from (org-agenda-files) and pushes the open org buffers found through (buffer-list), but i believe it _incorrectly_ uses (cl-pushnew) since it ultimately uses memql (which compares with eql) to check existence of the buffer file name (a string) with the (org-agenda-files) list (of strings), returning duplicate items on lists since compared strings are not the same lisp objects. Advising (org-files-list) with (delete-dups) is a workaround i'm using but (org-files-list) needs to be changed to use member instead of memql. Thank you very much. Emacs : GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 Package: Org mode version 9.1.3 (9.1.3-29-g037db0-elpa @ ~/.emacs.d/elpa/org-20171204/) -- Att., Renato Ferreira
