Re: [O] Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)]

2019-02-18 Thread Piet van Oostrum
Nicolas Goaziou wrote:

 > Hello,
 > 
 > Piet van Oostrum  writes:
 > 
 > > In org-mode 9.2.1, the menu item Org > Show/Hide > Show All is bound
 > > to org-show-all, but this function is nor=t interactive. Therefore the
 > > invocation of this menu item fails.
 > >
 > > command-execute: Wrong type argument: commandp, org-show-all
 > >
 > > Solution: add (interactive)
 > 
 > I wrote a commit message and applied your patch. I also added TINYCHANGE
 > cookie since I don't know if you signed papers already.
 > 
I signed papers for Emacs long long long time ago. Possibly with an older email 
address like p...@cs.uu.nl or p...@cs.ruu.nl.
But in this case the change is trivial, and there really is no other reasonable 
way to do it.
If I had thought about it I would not have given a patch :)
-- 
Piet van Oostrum 
WWW: http://piet.vanoostrum.org/
PGP key: [8DAE142BE17999C4]




Re: [O] Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)]

2019-02-18 Thread Nicolas Goaziou
Hello,

Piet van Oostrum  writes:

> In org-mode 9.2.1, the menu item Org > Show/Hide > Show All is bound
> to org-show-all, but this function is nor=t interactive. Therefore the
> invocation of this menu item fails.
>
> command-execute: Wrong type argument: commandp, org-show-all
>
> Solution: add (interactive)

I wrote a commit message and applied your patch. I also added TINYCHANGE
cookie since I don't know if you signed papers already.

Thank you.

Regards,

-- 
Nicolas Goaziou



[O] Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)]

2019-02-17 Thread Piet van Oostrum


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

 https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.


In org-mode 9.2.1, the menu item Org > Show/Hide > Show All is bound to 
org-show-all, but this function is nor=t interactive. Therefore the invocation 
of this menu item fails.

command-execute: Wrong type argument: commandp, org-show-all

Solution: add (interactive)

diff -u /Users/piet/.emacs.d/elpa/org-9.2.1/org.el.\~1\~ 
/Users/piet/.emacs.d/elpa/org-9.2.1/org.el
--- /Users/piet/.emacs.d/elpa/org-9.2.1/org.el.~1~  2019-02-17 
21:37:16.0 +0100
+++ /Users/piet/.emacs.d/elpa/org-9.2.1/org.el  2019-02-17 21:54:11.0 
+0100
@@ -6935,6 +6935,7 @@
 By default, the function expands headings, blocks and drawers.
 When optional argument TYPE is a list of symbols among `blocks',
 `drawers' and `headings', to only expand one specific type."
+  (interactive)
   (dolist (type (or types '(blocks drawers headings)))
 (org-flag-region (point-min) (point-max) nil
 (pcase type




Emacs  : GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 
Version 10.10.5 (Build 14F2511))
 of 2018-05-31
Package: Org mode version 9.2.1 (9.2.1-elpa @ 
/Users/piet/.emacs.d/elpa/org-9.2.1/)

current state:
==
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer 
org-src-mode-configure-edit-buffer)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-calendar-to-agenda-key [99]
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-html-format-inlinetask-function 
'org-html-format-inlinetask-default-function
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-reveal-start-hook '(org-decrypt-entry)
 org-modules '(org-w3m org-bbdb org-bibtex org-docview org-gnus org-info 
org-irc org-mhe org-rmail)
 org-export-creator-string "Emacs 26.1 (Org mode 9.1.9)"
 org-mime-library 'vm
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook 
org-show-all append local] 5]
 #[0 "\301\211\207" 
[imenu-create-index-function org-imenu-get-tree] 2]
 #[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook 
org-show-block-all append local] 5]
 #[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook 
org-babel-show-result-all append local] 5]
 org-babel-result-hide-spec 
org-babel-hide-all-hashes)
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn 
ENTRY)"]
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-agenda-deadline-faces '((1.0 . org-warning) (0.5 . org-upcoming-deadline) 
(0.0 . default))
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe 
org-babel-header-arg-expand)
 org-html-creator-string "https://www.gnu.org/software/emacs/\;>Emacs 26.1 (https://orgmode.org\;>Org mode 9.1.9)"
 org-ascii-format-drawer-function #[771 "\207" [] 4 "\n\n(fn NAME CONTENTS 
WIDTH)"]
 org-src-lang-modes '(("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa" . 
artist)
  ("asymptote" . asy) ("dot" . 
fundamental) ("sqlite" . sql)
  ("calc" . fundamental) ("C" . c) 
("cpp" . c++) ("C++" . c++)
  ("screen" . shell-script) ("shell" . 
sh) ("bash" . sh))
 org-latex-table-scientific-notation "%s\\,(%s)"
 org-html-infojs-template "\n/**\n *\n * @source: %SCRIPT_PATH\n *\n * @licstart  The 
following is the entire license notice for the\n *  JavaScript code in 
%SCRIPT_PATH.\n *\n * Copyright (C) 2012-2018 Free Software Foundation, Inc.\n 
*\n *\n * The JavaScript code in this tag is free software: you can\n * 
redistribute it and/or modify it under the terms of the GNU\n * General Public 
License (GNU GPL) as published by the Free Software\n * Foundation, either 
version 3 of the License, or (at your option)\n * any later version.  The code 
is distributed WITHOUT ANY WARRANTY;\n * without even the implied warranty of 
MERCHANTABILITY or FITNESS\n * FOR A PARTICULAR PURPOSE.  See the GNU GPL for 
more details.\n *\n *