Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
At Thu, 22 Sep 2011 10:13:18 -0400,
Dave Abrahams wrote:
on Thu Sep 22 2011, David Maus dmaus-AT-ictsoc.de wrote:
The link escaping was changed in November 2010, maybe the link in
question is an old one?
Yep.
Good. This explains it.
I think it's unfortunate that link escaping should have been changed in
a backward-incompatible way. Seems like the right thing to do would
have been to add a fallback to the old interpretation if the new one
failed.
True, but the problem is that AFAIK there is now way to
programmatically check if the new escpaing/unescaping fails. There is
this function:
http://orgmode.org/worg/org-hacks.html#check-old-link-escapes
,
| Starting with version 7.5 Org uses percent escaping more consistently
| and with a modified algorithm to determine which characters to escape
| and how.
|
| As a side effect this modified behaviour might break existing links if
| they contain a sequence of characters that look like a percent escape
| (e.g. [0-9A-Fa-f]{2}) but are in fact not a percent escape.
|
| The function below can be used to perform a preliminary check for such
| links in an Org mode file. It will run through all links in the file
| and issue a warning if it finds a percent escape sequence which is not
| in old Org's list of known percent escapes.
`
that might at least tell you if there is a problematic link in an Org
mode buffer. What to do if the func finds a possibly problematic
sequence depends on the link. In the %dave-case escaping the percent
sign (% = %25) could be sufficient.
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber dmj...@jabber.org
Email. dm...@ictsoc.de
pgpM4W71yYEc4.pgp
Description: PGP signature
Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
on Thu Sep 22 2011, David Maus dmaus-AT-ictsoc.de wrote: The link escaping was changed in November 2010, maybe the link in question is an old one? Yep. Good. This explains it. I think it's unfortunate that link escaping should have been changed in a backward-incompatible way. Seems like the right thing to do would have been to add a fallback to the old interpretation if the new one failed. -- Dave Abrahams BoostPro Computing http://www.boostpro.com
Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
At Tue, 20 Sep 2011 12:24:48 -0400, Dave Abrahams wrote: on Tue Sep 20 2011, David Maus dmaus-AT-ictsoc.de wrote: The original link is alread wrong, i.e. unescaped. The key question are 1. How did you create the original link? I used this code: https://github.com/dabrahams/elisp/blob/master/elisp/autoload.d/wl-setup.el#L801 Is there some encoding step I should have applied? Nope, the code should do the trick. The escaping is currently done when the link is inserted via `org-insert-link'. 2. When did you create the original link? It might have been as long as a year ago I tried taking a link with `org-store-link' and insert it with `org-insert-link' and the link was properly escaped. The link escaping was changed in November 2010, maybe the link in question is an old one? Yep. Good. This explains it. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgptdJKBMFqOP.pgp Description: PGP signature
Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
on Tue Sep 20 2011, David Maus dmaus-AT-ictsoc.de wrote: The original link is alread wrong, i.e. unescaped. The key question are 1. How did you create the original link? I used this code: https://github.com/dabrahams/elisp/blob/master/elisp/autoload.d/wl-setup.el#L801 Is there some encoding step I should have applied? 2. When did you create the original link? It might have been as long as a year ago I tried taking a link with `org-store-link' and insert it with `org-insert-link' and the link was properly escaped. The link escaping was changed in November 2010, maybe the link in question is an old one? Yep. -- Dave Abrahams BoostPro Computing http://www.boostpro.com
Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
At Fri, 16 Sep 2011 14:20:50 -0400, Dave Abrahams wrote: on Fri Sep 16 2011, David Maus dmaus-AT-ictsoc.de wrote: How did you enter the link into the Org file? The original link [[message://m2k4n46n5p.wl%d...@boostpro.com]] Is unescaped, but Org treats links as always percent-escaped. What happens is that %da is treated as a percent escaped character and unescaped after read from buffer. The link should read: message://m2k4n46n5p.wl%25d...@boostpro.com Yeah, I finally figured that out. This is a troublesome situation https://lists.gnu.org/archive/html/emacs-orgmode/2011-09/msg00257.html But up to know I didn't find a solution for it. Hmm, well, ... the link started out as a a wanderlust link of a form more like this: [[wl:/message-id:m2k4n46n5p.wl%d...@boostpro.com/%%5BGmail%5D/All%20Mail#103387bf-79b8-4389-ad51-955087347...@gmail.com]] _That_ link used to work. I transformed links like that by search/replace into: [[message://m2k4n46n5p.wl%d...@boostpro.com]] So maybe it's my fault? The original link is alread wrong, i.e. unescaped. The key question are 1. How did you create the original link? 2. When did you create the original link? I tried taking a link with `org-store-link' and insert it with `org-insert-link' and the link was properly escaped. The link escaping was changed in November 2010, maybe the link in question is an old one? Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgp7yKGM9pvf3.pgp Description: PGP signature
[O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
I have an Org link as follows:
[[message://m2k4n46n5p.wl%d...@boostpro.com]]
When I try to `C-c C-o' it, opening fails because the link-handling code
sees this string for the link:
m2k4n46n5p.wlÚv...@boostpro.com
which you may notice is different. If I do
(org-open-link-from-string message://m2k4n46n5p.wl%d...@boostpro.com)
on the other hand, it works just fine.
Emacs : GNU Emacs 23.3.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0
AppKit 1038.36)
of 2011-09-12 on pluto.luannocracy.com
Package: Org-mode version 7.7 (release_7.7.292.g0d4e8.dirty)
current state:
==
(setq
org-x-backends '(ox-org ox-redmine)
org-agenda-deadline-leaders '(D: D%d: )
org-clock-in-switch-to-state STARTED
org-agenda-skip-scheduled-if-deadline-is-shown t
org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
org-x-redmine-title-prefix-match-function 'org-x-redmine-title-prefix-match
org-speed-command-hook '(org-speed-command-default-hook
org-babel-speed-command-hook)
org-agenda-custom-commands '((E Errands (next 3 days) tags
ErrandTODO\DONE\TODO\CANCELED\STYLE\habit\SCHEDULED\+3d\
((org-agenda-overriding-header Errands (next 3
days
(A Priority #A tasks agenda
((org-agenda-ndays 1)
(org-agenda-overriding-header Today's priority #A tasks: )
(org-agenda-skip-function
(quote (org-agenda-skip-entry-if (quote
notregexp) \\=.*\\[#A\\])))
)
)
(b Priority #A and #B tasks agenda
((org-agenda-ndays 1)
(org-agenda-overriding-header Today's priority
#A and #B tasks: )
(org-agenda-skip-function
(quote (org-agenda-skip-entry-if (quote
regexp) \\=.*\\[#C\\])))
)
)
(p Un-prioritized tasks agenda
((org-agenda-overriding-header Today's
un-prioritized tasks: )
(org-agenda-skip-function
(quote (org-agenda-skip-entry-if (quote
notregexp) \\=.*\\[#[ABC]\\])))
)
)
(w Waiting/delegated tasks tags
TODO=\WAITING\|TODO=\DELEGATED\
((org-agenda-overriding-header
Waiting/delegated tasks:)
(org-agenda-sorting-strategy (quote
(todo-state-up priority-down category-up
)
(u Unscheduled tasks tags
AREA\Work\TODO\\TODO{DONE\\|CANCELED\\|NOTE\\|PROJECT}
((org-agenda-files (quote
(~/Documents/Tasks/todo.txt)))
(org-agenda-overriding-header Unscheduled
tasks: )
(org-agenda-skip-function
(quote
(org-agenda-skip-entry-if (quote scheduled)
(quote deadline) (quote timestamp)
(quote regexp) \\*
\\(DEFERRED\\|SOMEDAY\\))
)
)
(org-agenda-sorting-strategy (quote
(priority-down
)
(U Deferred tasks tags TODO=\DEFERRED\
((org-agenda-files (quote
(~/Documents/Tasks/todo.txt)))
(org-agenda-overriding-header Deferred
tasks:))
)
(Y Someday tasks tags TODO=\SOMEDAY\
((org-agenda-overriding-header Someday
tasks:)))
(G Ledger tasks (all) alltodo
((org-agenda-files (quote
(~/src/ledger/plan/TODO)))
(org-agenda-overriding-header Ledger tasks:)
(org-agenda-sorting-strategy (quote
(todo-state-up priority-down category-up
)
(N Ledger tasks (all, alphabetical) alltodo
((org-agenda-files (quote
(~/src/ledger/plan/TODO)))
(org-agenda-overriding-header Ledger tasks,
alphabetical:)
Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
At Fri, 16 Sep 2011 12:03:51 -0400, Dave Abrahams wrote: Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See http://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org-mode mailing list. I have an Org link as follows: [[message://m2k4n46n5p.wl%d...@boostpro.com]] When I try to `C-c C-o' it, opening fails because the link-handling code sees this string for the link: m2k4n46n5p.wlÚv...@boostpro.com which you may notice is different. If I do (org-open-link-from-string message://m2k4n46n5p.wl%d...@boostpro.com) How did you enter the link into the Org file? The original link [[message://m2k4n46n5p.wl%d...@boostpro.com]] Is unescaped, but Org treats links as always percent-escaped. What happens is that %da is treated as a percent escaped character and unescaped after read from buffer. The link should read: message://m2k4n46n5p.wl%25d...@boostpro.com This is a troublesome situation https://lists.gnu.org/archive/html/emacs-orgmode/2011-09/msg00257.html But up to know I didn't find a solution for it. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgpXiewk8yzTV.pgp Description: PGP signature
Re: [O] Bug: unable to open link unless `...from-string' [7.7 (release_7.7.292.g0d4e8.dirty)]
on Fri Sep 16 2011, David Maus dmaus-AT-ictsoc.de wrote: How did you enter the link into the Org file? The original link [[message://m2k4n46n5p.wl%d...@boostpro.com]] Is unescaped, but Org treats links as always percent-escaped. What happens is that %da is treated as a percent escaped character and unescaped after read from buffer. The link should read: message://m2k4n46n5p.wl%25d...@boostpro.com Yeah, I finally figured that out. This is a troublesome situation https://lists.gnu.org/archive/html/emacs-orgmode/2011-09/msg00257.html But up to know I didn't find a solution for it. Hmm, well, ... the link started out as a a wanderlust link of a form more like this: [[wl:/message-id:m2k4n46n5p.wl%d...@boostpro.com/%%5BGmail%5D/All%20Mail#103387bf-79b8-4389-ad51-955087347...@gmail.com]] _That_ link used to work. I transformed links like that by search/replace into: [[message://m2k4n46n5p.wl%d...@boostpro.com]] So maybe it's my fault? -- Dave Abrahams BoostPro Computing http://www.boostpro.com
