Re: [O] Cursor jumps unexpectedly when calling org-agenda-todo

2014-01-25 Thread Bastien 
Hi Matt,

Matt Lundin m...@imapmail.org writes:

 Hi Bastien,

 Commit e5259962f61c398d84d43d33c29a6f021c9b326a introduced a change
 (perhaps unintentional) in the function org-agenda-todo. Line 8870
 added another...

 (setq col (current-column))

 Is this supposed to be there?

Not at all, I just fixed this.

Thanks for the clear report,

-- 
 Bastien

[O] Cursor jumps unexpectedly when calling org-agenda-todo

2014-01-24 Thread Matt Lundin 
Hi Bastien,

Commit e5259962f61c398d84d43d33c29a6f021c9b326a introduced a change
(perhaps unintentional) in the function org-agenda-todo. Line 8870
added another...

(setq col (current-column))

Is this supposed to be there?

The problem is that this is called in the actual org buffer at the
location of org-marker, thus overriding the earlier value set in line
8757. 

Thus, when org-agenda-todo attempts places the cursor with
org-move-to-column (line 8796), it does so on the basis of the position
in the org file rather than the original position in the agenda. In
other words, no matter what column the cursor is at in the agenda buffer
(e.g., 0, 28, 30), it gets moved to the column of org-marker in the org
buffer (e.g., 13).

For instance, a cursor here in the agenda...

  inbox:  Scheduled:  TODO Do something:errands:
^

gets moved to here after calling org-agenda-todo...

  inbox:  Scheduled:  TODO Do something:errands:
^

Thanks,
Matt