Re: [O] Lexical binding bug in org-list.el?

2015-11-11 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > LGTM. I’ve probably met my quota of org-related fun for the day (see > below...), but implementing this in terms of elements will be my next > org-list related task. What is "this"? Unfortunately org-list and Elements do not play nicely with each other at the momen

Re: [O] Lexical binding bug in org-list.el?

2015-11-09 Thread Kaushal Modi
Thanks for fixing this.

Re: [O] Lexical binding bug in org-list.el?

2015-11-08 Thread Aaron Ecay
Hi Nicolas, 2015ko azaroak 8an, Nicolas Goaziou-ek idatzi zuen: [...] > Anyway, this we're really nitpicking. There's nothing fundamentally > wrong in either choice. You’re right, and I’m not trying to be quarrelsome. At least for me, it’s helpful to understand the perspective on things like t

Re: [O] Lexical binding bug in org-list.el?

2015-11-08 Thread Nicolas Goaziou
Aaron Ecay writes: > I don’t think we should unit-test only public API functions. I didn't say that. However, I wouldn't write tests for "--" functions. > Indeed, I find it easier to write unit tests for small functions, > since I don’t have to construct a lot of extra context to exercise all >

Re: [O] Lexical binding bug in org-list.el?

2015-11-07 Thread Aaron Ecay
Hi Nicolas, 2015ko azaroak 7an, Nicolas Goaziou-ek idatzi zuen: > > Aaron Ecay writes: > >> On a broader scope, this is just one part of org that is written in this >> style (one large let that defines many functions which call each other; >> the body of the let is just a call into one of these

Re: [O] Lexical binding bug in org-list.el?

2015-11-07 Thread Nicolas Goaziou
Aaron Ecay writes: > On a broader scope, this is just one part of org that is written in this > style (one large let that defines many functions which call each other; > the body of the let is just a call into one of these functions). This > isn’t idiomatic elisp (at least, I’ve never seen it ou

Re: [O] Lexical binding bug in org-list.el?

2015-11-07 Thread Aaron Ecay
Hi Nicolas, 2015ko azaroak 7an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Aaron Ecay writes: > >> The org-list code is a mess, and I think we should hold off on converting >> it to lexical scoping until it can be refactored in a more dedicated >> way. > > It seems a bit strong considerin

Re: [O] Lexical binding bug in org-list.el?

2015-11-06 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > The org-list code is a mess, and I think we should hold off on converting > it to lexical scoping until it can be refactored in a more dedicated > way. It seems a bit strong considering there's only one issue so far. I don't think the code is a mess, but "Send and re

Re: [O] Lexical binding bug in org-list.el?

2015-11-06 Thread Kaushal Modi
Thanks for working on this Aaron but M-x ediff-patch-file failed for me. I am on the cce317 commit of org-mode (http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=265e5b9984818f76dea8f5147af0c4a939cf457b) patching file /home/kmodi/e/elisp/org-mode/lisp_25_0/org-list.el Hunk #1 succeeded at 2923

Re: [O] Lexical binding bug in org-list.el?

2015-11-06 Thread Aaron Ecay
Hi Kaushal, I can reproduce the bug, and you’re right about the cause. I made the attached patch, which seems to get the code back on its feet. But I just sort of fiddled with it until all the lexical scoping warnings from the compiler went away; I have no idea whether it’s correct. The org-lis

Re: [O] Lexical binding bug in org-list.el?

2015-11-06 Thread Kaushal Modi
Lesser steps to recreate this bug: (1) In any buffer, do M-x org-mode (2) Type: - item 1 (3) Do M-RET Now you have - item 1 - (4) Now do C-c * Boom!

[O] Lexical binding bug in org-list.el?

2015-11-06 Thread Kaushal Modi
Hi, Here the required info: Org-mode version 8.3.2 (release_8.3.2-287-gcce317 @ /home/kmodi/usr_local/apps/6/emacs/master/share/emacs/site-lisp/org/) The bug is very easy to recreate. (1) In any buffer, M-x org-mode (2) Type * heading 1 (3) Do M-RET Now you have * heading 1 * (4) Do C-c - No