Re: [O] Org Mode Documentation Patch

2018-06-25 Thread Van L


>> I've printed, signed, scanned and sent the assignment to
>> ass...@gnu.org , waiting for their response.
> 
> Nice.

It should be possible to do without printing and 
scanning, do all of the assignment electronically.



Re: [O] Org Mode Documentation Patch

2018-06-25 Thread Nicolas Goaziou
Hello,

"Siraphob (Ben) Phipathananunth"  writes:

> I've printed, signed, scanned and sent the assignment to
> ass...@gnu.org , waiting for their response.

Nice.

> In the meantime, please install another patch I wrote, attached.

Done, barring one hunk specified below.

> You may notice that the email and name of the patch author is
> different, this is to correspond with my email and legal name. ("Ben"
> is my nickname)

OK.

> - compilation for /today/, until the entry is marked DONE, i.e.,
> - the task is automatically forwarded until completed.
> + compilation for /today/, until the entry is marked DONE, (i.e.
> + the task is automatically forwarded until completed).

I wasn't convinced by this change so I didn't apply it. The former form
looks correct.

Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Org Mode Documentation Patch

2018-06-25 Thread Siraphob (Ben) Phipathananunth
I've printed, signed, scanned and sent the assignment to ass...@gnu.org 
, waiting for their response.


In the meantime, please install another patch I wrote, attached.

You may notice that the email and name of the patch author is different, 
this is to correspond with my email and legal name. ("Ben" is my nickname)


Thanks,

--
Siraphob (Ben) Phipathananunth
From 677ac08a5b11157f59dd5acc73a2bc7103344f22 Mon Sep 17 00:00:00 2001
From: Siraphob Phipathananunth 
Date: Mon, 25 Jun 2018 21:27:05 +0700
Subject: [PATCH] Fix "cursor" to "point", fix grammar and add cross-references

* doc/org-manual : More wording and grammar is fixed, cross-references
to other sections are added when key terms appear (e.g. agenda,
property, completion).
---
 doc/org-manual.org | 323 ++---
 1 file changed, 161 insertions(+), 162 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index f1180458a..caa23be83 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -1145,8 +1145,7 @@ to disable them individually.
  indentation.  When these commands are executed several times in
  direct succession, the initially selected region is used, even if
  the new indentation would imply a different hierarchy.  To use
- the new hierarchy, break the command chain with a cursor motion
- or so.
+ the new hierarchy, break the command chain by moving point.
 
  As a special case, using this command on the very first item of
  a list moves the whole list.  This behavior can be disabled by
@@ -1194,7 +1193,7 @@ to disable them individually.
  #+vindex: org-support-shift-select
  #+kindex: S-LEFT
  #+kindex: S-RIGHT
- This command also cycles bullet styles when point in on the
+ This command also cycles bullet styles when point is in on the
  bullet or anywhere in an item line, details depending on
  ~org-support-shift-select~.
 
@@ -1683,7 +1682,7 @@ you, configure the option ~org-table-auto-blank-field~.
  #+vindex: org-table-copy-increment
  When current field is empty, copy from first non-empty field
  above.  When not empty, copy current field down to next row and
- move cursor along with it.  Depending on the variable
+ move point along with it.  Depending on the variable
  ~org-table-copy-increment~, integer field values can be
  incremented during copy.  Integers that are too large are not
  incremented, however.  Also, a ~0~ prefix argument temporarily
@@ -1919,10 +1918,10 @@ to derive fields from other fields.  While fully 
featured, Org's
 implementation is not identical to other spreadsheets.  For example,
 Org knows the concept of a /column formula/ that will be applied to
 all non-header fields in a column without having to copy the formula
-to each relevant field.  There is also a formula debugger, and
-a formula editor with features for highlighting fields in the table
-corresponding to the references at the point in the formula, moving
-these references by arrow keys.
+to each relevant field.  There is also a formula debugger, and a
+formula editor with features for highlighting fields in the table
+corresponding to the references at point in the formula, moving these
+references by arrow keys.
 
 *** References
 :PROPERTIES:
@@ -3376,7 +3375,7 @@ generally, act on links.
  possible with =~/= for your home directory.  You can force an
  absolute path with two {{{kbd(C-u)}}} prefixes.
 
-- {{{kbd(C-c C-l)}}} (with cursor on existing link) ::
+- {{{kbd(C-c C-l)}}} (with point on existing link) ::
 
  #+cindex: following links
  When point is on an existing link, {{{kbd(C-c C-l)}}} allows
@@ -3391,11 +3390,11 @@ generally, act on links.
  ~browse-url-at-point~), run VM/MH-E/Wanderlust/Rmail/Gnus/BBDB
  for the corresponding links, and execute the command in a shell
  link.  When point is on an internal link, this command runs the
- corresponding search.  When point is on the tags part of
- a headline, it creates the corresponding tags view (see [[*Matching
- tags and properties]]).  If the cursor is on a timestamp, it
- compiles the agenda for that date.  Furthermore, it visits text
- and remote files in =file= links with Emacs and select a suitable
+ corresponding search.  When point is on the tags part of a
+ headline, it creates the corresponding tags view (see [[*Matching
+ tags and properties]]).  If point is on a timestamp, it compiles
+ the agenda for that date.  Furthermore, it visits text and remote
+ files in =file= links with Emacs and select a suitable
  application for local non-text files.  Classification of files is
  based on file extension only.  See option ~org-file-apps~.  If
  you want to override the default application and visit the file
@@ -3867,14 +3866,13 @@ require action.  Your setup would then look like this:
 (sequence "|" "CANCELED")))
 #+end_src
 
-The keywords should 

Re: [O] Org Mode Documentation Patch

2018-06-23 Thread Nicolas Goaziou
"Siraphob (Ben) Phipathananunth"  writes:

> I just sent an email to ass...@gnu.org with my information,

Great!

> how will I know when copyright assign is completed?

They will let you know. Then, you may let me know. :)




Re: [O] Org Mode Documentation Patch

2018-06-23 Thread Siraphob (Ben) Phipathananunth
Thank you very much for accepting the patch.

Nicolas Goaziou wrote:
> BTW, what is your status wrt FSF papers?

I just sent an email to ass...@gnu.org with my information, how will I know 
when copyright assign is completed?

Thank you again,

-- 
Siraphob (Ben) Phipathananunth



Re: [O] Org Mode Documentation Patch

2018-06-23 Thread Nicolas Goaziou
Hello,

"Siraphob (Ben) Phipathananunth"  writes:

> I've begun reading the Org Mode manual, and noticed that the wording
> in some places could be improved (so far I've read up to Section 4.8).
> I've attached my patch.  Some of the more drastic changes:
>
> - Changed all occurrences of "the cursor" to "point", I thought the
>   inconsistency was confusing, especially since the Emacs manual
>   maintains usage of "point" throughout, so too should the Org Mode
>   manual.

Thank you. I applied your patch. 

I'm not totally convinced by the change from "function" to "Lisp
function", since, in the context of Org, an Elisp library, there is no
ambiguity. But I have no strong opinion, so I didn't remove the
occurrences in your patch.

BTW, what is your status wrt FSF papers?

> Section 4.6 "Link abbreviations" in the Org Mode manual link to
> websites that have and/or promote non-free software.  The URLs are
> used to illustrate link abbreviations in Org Mode, but I suppose this
> was purely coincidental because long URLs to websites such as
> gnu.org/some/long/path could be used instead.  Would it be appropriate
> to change the examples in a later patch?

Sure. However, for the sake of clarity, it would be better if not all
examples are similar, i.e., no "gnu.org/some/long/path" everywhere.

> When the PDF version of the Org Mode manual is generated with "make
> docs", the footnotes (3 and 4) around Section 4.3 are incorrectly
> indented, can anyone reproduce this?

I don't see anything like that in the PDF. You may want to try deleting
it and re-generate it.

> Should I submit my patches as smaller ones as I read sections of the
> manual or bulk them together into a larger patch, or is it just a
> matter of preference?

As you wish.

> Please let me know if you have any comments about the patch.  It's my
> first one, I hope I have followed the CONTRIBUTING guide properly.

I fixed a couple of missing capitalization (point at the beginning of
a sentence) and filled modified paragraphs. I also slightly modified
your commit message.

Regards,

-- 
Nicolas Goaziou



[O] Org Mode Documentation Patch

2018-06-22 Thread Siraphob (Ben) Phipathananunth
This patch was originally submitted to Emacs devel, but Eli Zaretskii
redirected me here.

I've begun reading the Org Mode manual, and noticed that the wording
in some places could be improved (so far I've read up to Section 4.8).
I've attached my patch.  Some of the more drastic changes:

- Changed all occurrences of "the cursor" to "point", I thought the
  inconsistency was confusing, especially since the Emacs manual
  maintains usage of "point" throughout, so too should the Org Mode
  manual.

I have a couple of questions regarding the Org Mode manual and
submitting patches:

Section 4.6 "Link abbreviations" in the Org Mode manual link to
websites that have and/or promote non-free software.  The URLs are
used to illustrate link abbreviations in Org Mode, but I suppose this
was purely coincidental because long URLs to websites such as
gnu.org/some/long/path could be used instead.  Would it be appropriate
to change the examples in a later patch?

When the PDF version of the Org Mode manual is generated with "make
docs", the footnotes (3 and 4) around Section 4.3 are incorrectly
indented, can anyone reproduce this?  What is causing it?

Should I submit my patches as smaller ones as I read sections of the
manual or bulk them together into a larger patch, or is it just a
matter of preference?

Please let me know if you have any comments about the patch.  It's my
first one, I hope I have followed the CONTRIBUTING guide properly.

Thanks!

--

Siraphob (Ben) Phipathananunth


0001-Fix-various-grammatical-errors-and-fix-terminology.patch
Description: Binary data