Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Please go ahead (applying the patch, not bugging somebody!). Alan, from now on, you can use this as a general rule :) Thanks! -- Bastien
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 2014-09-24 12:12, Steve Purcell st...@sanityinc.com writes: The existing Applescript for grabbing flagged mail messages can only work on machines which have Growl installed. This is increasingly rarely the case as Growl has been obsoleted by OS X’s own notification system. Applied. Thank you for the patch and sorry for the delay. Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 signature.asc Description: PGP signature
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 9 Oct 2014, at 12:40, Alan Schmitt alan.schm...@polytechnique.org wrote: Applied. Thank you for the patch and sorry for the delay. Thanks for merging both of those patches. I’ll re-work the other one (re. broken “message:” links) in the near future and resubmit. -Steve
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
Hello, Unless I'm mistaken, I did not receive a reply to this question: can I apply this patch? I understand that Bastien is quite busy at the moment, so I'm wondering if I should bug somebody else ;) Best, Alan On 2014-09-25 08:17, Alan Schmitt alan.schm...@polytechnique.org writes: On 2014-09-24 20:59, Steve Purcell st...@sanityinc.com writes: On 24 Sep 2014, at 20:13, Alan Schmitt alan.schm...@polytechnique.org wrote: tell application System Events set growlHelpers to the name of every process whose creator type contains GRRR if (count of growlHelpers) 0 then set growlHelperApp to item 1 of growlHelpers else set growlHelperApp to end if end tell I get an empty string as returned value. Is is the same for you? Yes, that part works fine on its own even on my machine. But when the code passed to AppleScript includes 'tell application “GrowlHelperApp”’, then the code will not execute unless the app is present — there’s a precompilation step where, presumably, AppleScript determines that the target application supports the listed commands. I see. I agree this should be removed. Org maintainers: can I apply this patch? Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 signature.asc Description: PGP signature
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
Hello, Alan Schmitt alan.schm...@polytechnique.org writes: Unless I'm mistaken, I did not receive a reply to this question: can I apply this patch? I understand that Bastien is quite busy at the moment, so I'm wondering if I should bug somebody else ;) Please go ahead (applying the patch, not bugging somebody!). Regards, -- Nicolas Goaziou
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 2014-09-24 20:59, Steve Purcell st...@sanityinc.com writes: On 24 Sep 2014, at 20:13, Alan Schmitt alan.schm...@polytechnique.org wrote: tell application System Events set growlHelpers to the name of every process whose creator type contains GRRR if (count of growlHelpers) 0 then set growlHelperApp to item 1 of growlHelpers else set growlHelperApp to end if end tell I get an empty string as returned value. Is is the same for you? Yes, that part works fine on its own even on my machine. But when the code passed to AppleScript includes 'tell application “GrowlHelperApp”’, then the code will not execute unless the app is present — there’s a precompilation step where, presumably, AppleScript determines that the target application supports the listed commands. I see. I agree this should be removed. Org maintainers: can I apply this patch? Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 signature.asc Description: PGP signature
[O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
The existing Applescript for grabbing flagged mail messages can only work on machines which have Growl installed. This is increasingly rarely the case as Growl has been obsoleted by OS X’s own notification system. -Steve 0001-org-mac-link.el-Don-t-fail-on-machines-without-Growl.patch Description: Binary data
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 2014-09-24 12:12, Steve Purcell st...@sanityinc.com writes: The existing Applescript for grabbing flagged mail messages can only work on machines which have Growl installed. This is increasingly rarely the case as Growl has been obsoleted by OS X’s own notification system. I'm surprised: I don't have Growl installed and it still works. I agree there is not much point in testing for Growl, though. Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 signature.asc Description: PGP signature
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
Alan Schmitt alan.schm...@polytechnique.org writes: On 2014-09-24 12:12, Steve Purcell st...@sanityinc.com writes: I'm surprised: I don't have Growl installed and it still works. I agree there is not much point in testing for Growl, though. I get the system popup asking me to locate the growlHelperApp program. -Steve
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 2014-09-24 16:35, Steve Purcell st...@sanityinc.com writes: Alan Schmitt alan.schm...@polytechnique.org writes: On 2014-09-24 12:12, Steve Purcell st...@sanityinc.com writes: I'm surprised: I don't have Growl installed and it still works. I agree there is not much point in testing for Growl, though. I get the system popup asking me to locate the growlHelperApp program. Indeed. Digging a little, I found out that I actually have Growl still installed. I removed it, killed its process, and made sure through the following AppleScript that it's not found: tell application System Events set growlHelpers to the name of every process whose creator type contains GRRR if (count of growlHelpers) 0 then set growlHelperApp to item 1 of growlHelpers else set growlHelperApp to end if end tell I get an empty string as returned value. Is is the same for you? But as I said before, I'm fine with removing Growl support, unless someone objects. Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 signature.asc Description: PGP signature
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 24 Sep 2014, at 20:13, Alan Schmitt alan.schm...@polytechnique.org wrote: tell application System Events set growlHelpers to the name of every process whose creator type contains GRRR if (count of growlHelpers) 0 then set growlHelperApp to item 1 of growlHelpers else set growlHelperApp to end if end tell I get an empty string as returned value. Is is the same for you? Yes, that part works fine on its own even on my machine. But when the code passed to AppleScript includes 'tell application “GrowlHelperApp”’, then the code will not execute unless the app is present — there’s a precompilation step where, presumably, AppleScript determines that the target application supports the listed commands. -Steve
