Re: [O] Tangling is broken in git master

2012-08-13 Thread Eric Schulte
Bastien b...@gnu.org writes: Bernt Hansen be...@norang.ca writes: That doesn't work. There's a missing ) at the end of the defalias and after I add that I get Er, sorry for the typo. I've reverted this commit for now, I'll see if I can get rid of cl-labels another way. I've just

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Eric, Eric Schulte eric.schu...@gmx.com writes: I've just pushed up another version of this commit, which I believe removes cl-labels while still preserving tangling behavior. If you have a chance please re-check tangling with the latest Org-mode. `letrec' is not available on Emacs 24.1

Re: [O] Tangling is broken in git master

2012-08-13 Thread Eric Schulte
Bastien b...@gnu.org writes: Hi Eric, Eric Schulte eric.schu...@gmx.com writes: I've just pushed up another version of this commit, which I believe removes cl-labels while still preserving tangling behavior. If you have a chance please re-check tangling with the latest Org-mode.

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Eric, Eric Schulte eric.schu...@gmx.com writes: I'm surprised that elisp doesn't provide any mechanism for local anonymous functions. (let ((my-local-func (lambda (a) (message a (funcall my-local-func Hello!)) is fine. It's just for recursive local function -- letrec provides

Re: [O] Tangling is broken in git master

2012-08-13 Thread Nick Dokos
Eric Schulte eric.schu...@gmx.com wrote: Bastien b...@gnu.org writes: Hi Eric, Eric Schulte eric.schu...@gmx.com writes: I've just pushed up another version of this commit, which I believe removes cl-labels while still preserving tangling behavior. If you have a chance please

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Nick, Nick Dokos nicholas.do...@hp.com writes: Can't the definition of letrec in emacs24 be lifted bodily into org-compat.el (or whatever the correct place is) as a compatibility-with-emacs-23 macro? I don't think it's worth the effort. The current code works and compiles without warnings

Re: [O] Tangling is broken in git master

2012-08-13 Thread Nicolas Goaziou
Hello, Bastien b...@gnu.org writes: Eric Schulte eric.schu...@gmx.com writes: I'm surprised that elisp doesn't provide any mechanism for local anonymous functions. (let ((my-local-func (lambda (a) (message a (funcall my-local-func Hello!)) is fine. It's just for recursive

Re: [O] Tangling is broken in git master

2012-08-13 Thread Nick Dokos
Bastien b...@gnu.org wrote: Hi Nick, Nick Dokos nicholas.do...@hp.com writes: Can't the definition of letrec in emacs24 be lifted bodily into org-compat.el (or whatever the correct place is) as a compatibility-with-emacs-23 macro? I don't think it's worth the effort. The

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Nick, Nick Dokos nicholas.do...@hp.com writes: I'd suggest that that can be a source of bugs that would be avoided with a compatibility macro. `org-labels' is an alias for `cl-labels' (when available) or `labels'. There is no need for a compatibility macro here, as the current code is

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Nicolas Goaziou n.goaz...@gmail.com writes: You can have recursive local functions: #+begin_src emacs-lisp (let* (len ; For byte compiler. (len (lambda (l) (if (not l) 0 (1+ (funcall len (cdr l))) (funcall len '(1 2 3)))

Re: [O] Tangling is broken in git master

2012-08-12 Thread Achim Gratz
Bernt Hansen writes: Tangling doesn't work for me in git master anymore. Git bisect identifies the following commit as introducing the problem [...] Debugger entered--Lisp error: (void-function letrec) (letrec ((intersect ...)) (funcall intersect (case context ... ... ...) (split-string

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bastien
Hi Bernt, Bernt Hansen be...@norang.ca writes: Tangling doesn't work for me in git master anymore. Git bisect identifies the following commit as introducing the problem Please try the attached patch and let us know if it works. Thanks, From 45c517919756b7af78b720e454e8ea8d969f6a43 Mon Sep

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bernt Hansen
Bastien b...@gnu.org writes: Hi Bernt, Bernt Hansen be...@norang.ca writes: Tangling doesn't work for me in git master anymore. Git bisect identifies the following commit as introducing the problem Please try the attached patch and let us know if it works. Thanks, That doesn't work.

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bernt Hansen
Achim Gratz strom...@nexgo.de writes: Bernt Hansen writes: Tangling doesn't work for me in git master anymore. Git bisect identifies the following commit as introducing the problem [...] Debugger entered--Lisp error: (void-function letrec) (letrec ((intersect ...)) (funcall intersect

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bastien
Bernt Hansen be...@norang.ca writes: That doesn't work. There's a missing ) at the end of the defalias and after I add that I get Er, sorry for the typo. I've reverted this commit for now, I'll see if I can get rid of cl-labels another way. Thanks, -- Bastien

[O] Tangling is broken in git master

2012-08-11 Thread Bernt Hansen
Hi Bastien, Tangling doesn't work for me in git master anymore. Git bisect identifies the following commit as introducing the problem --8---cut here---start-8--- ba16c3c6f50738b070769040586945436439be76 is the first bad commit commit