Bastien writes:
> Well, hold on, I'm recompiling Emacs, as my cl-macs.el seemed to
> date from way before two days ago.
With a fresh Emacs things are fine. Sorry for the noise.
--
Bastien
Bastien writes:
> This commit
>
> http://orgmode.org/w/?p=org-mode.git;a=commit;h=63b5f8
>
> breaks things for me.
>
> My Emacs version is 24.1.50.3 (built from trunk yesterday) and Org
> aliases org-flet to cl-flet* which doesn't exist here.
>
> Can you check and fix this?
Well, hold on, I'm
Hi Eric,
Eric Schulte writes:
> I've just applied this patch including the input from both Achim and
> Vladimir (thanks).
>
> I also applied another patches fixing the other cl related build issues
> mentioned by Achim. The build now succeeds on the latest Emacs without
> generating any warning
Achim Gratz writes:
> Eric Schulte writes:
>> I also applied another patches fixing the other cl related build issues
>> mentioned by Achim. The build now succeeds on the latest Emacs without
>> generating any warnings and all tests pass (although it sounds like we
>> could use more test coverag
Eric Schulte writes:
> I also applied another patches fixing the other cl related build issues
> mentioned by Achim. The build now succeeds on the latest Emacs without
> generating any warnings and all tests pass (although it sounds like we
> could use more test coverage).
I don't think d7a8b6636
I've just applied this patch including the input from both Achim and
Vladimir (thanks).
I also applied another patches fixing the other cl related build issues
mentioned by Achim. The build now succeeds on the latest Emacs without
generating any warnings and all tests pass (although it sounds lik
Eric Schulte writes:
> Okay, I've noticed a number of these errors as well. It looks like the
> old version of flet allowed the definition of recursive functions, but
> the new cl-flet does not.
The defalias checks for the wrong Emacs version. I've just built
another Emacs24 which got version 24
Vladimir Lomov writes:
> Thanks, would work fine with this small change:
Thanks, but please do not patch a patch file...
Eric, that leaves:
In org-babel-edit-distance:
ob.el:624:37:Warning: function `map' from cl package called at runtime
which the byte-compiler did not pick up on before. If i
Hello,
** Eric Schulte [2012-07-20 11:43:45 -0600]:
[...]
> Okay, I've noticed a number of these errors as well. It looks like the
> old version of flet allowed the definition of recursive functions, but
> the new cl-flet does not.
> Below find my previous patch which now uses cl-flet* instead
This attached alternate patch introduces two new compatibility macros
named `org-flet' and `org-labels' in org-macs.el. These macros are
aliased to the appropriate cl macro depending on the version of Emacs in
use.
>>> This is interesting, but seems not fully functional. After
Hello,
** Vladimir Lomov [2012-07-20 10:19:45 +0900]:
> ** Vladimir Lomov [2012-07-19 21:33:57 +0900]:
>> Hello,
>>> ** Eric Schulte [2012-07-18 22:13:45 -0600]:
>>> This attached alternate patch introduces two new compatibility macros
>>> named `org-flet' and `org-labels' in org-macs.el. These
** Vladimir Lomov [2012-07-19 21:33:57 +0900]:
> Hello,
> ** Eric Schulte [2012-07-18 22:13:45 -0600]:
>> Achim Gratz writes:
>>> Eric Schulte writes:
This attached alternate patch introduces two new compatibility macros
named `org-flet' and `org-labels' in org-macs.el. These macros
Thanks.
I have taken care for org-odt.el. Any `flet's in org-e-odt.el will also
be removed in the next commit.
--
Hello,
** Eric Schulte [2012-07-18 22:13:45 -0600]:
> Achim Gratz writes:
>> Eric Schulte writes:
>>> This attached alternate patch introduces two new compatibility macros
>>> named `org-flet' and `org-labels' in org-macs.el. These macros are
>>> aliased to the appropriate cl macro depending on
Eric Schulte writes:
> Why? Using `defalias' seems simpler because with `defmacro' I would
> have to copy the macro arguments and stub out a trivial macro body.
> Also, this way the version check only happens once (at load time),
> rather than every time the macro is called.
I confused defalias a
Achim Gratz writes:
> Eric Schulte writes:
>> This attached alternate patch introduces two new compatibility macros
>> named `org-flet' and `org-labels' in org-macs.el. These macros are
>> aliased to the appropriate cl macro depending on the version of Emacs in
>> use.
>
> Wouldn't you want to u
Eric Schulte writes:
> This attached alternate patch introduces two new compatibility macros
> named `org-flet' and `org-labels' in org-macs.el. These macros are
> aliased to the appropriate cl macro depending on the version of Emacs in
> use.
Wouldn't you want to use defmacro instead of defalias
Vladimir Lomov writes:
> Hello,
>
> I'm using Emacs compiled from BZR trunk and Org-mode compiled from GIT.
>
> Begining from some revision (I don't remember exact revno) function
> `flet' was declared obsolete so Org-mode compilation is accompanied with
> warnings about that.
>
> If just ignore
Vladimir Lomov writes:
> Begining from some revision (I don't remember exact revno) function
> `flet' was declared obsolete so Org-mode compilation is accompanied with
> warnings about that.
>
> If just ignore them then I get malfunction Org-mode. I made patch to
> change all `flet's to appropriate
Hello,
I'm using Emacs compiled from BZR trunk and Org-mode compiled from GIT.
Begining from some revision (I don't remember exact revno) function
`flet' was declared obsolete so Org-mode compilation is accompanied with
warnings about that.
If just ignore them then I get malfunction Org-mode. I
20 matches
Mail list logo
