Re: [O] make orgtbl-ascii-plot easier to install

2014-08-29 Thread Thierry Banel
Le 29/08/2014 11:54, Nicolas Goaziou a écrit : > > Patch applied (with tiny changes to comments formatting, and a few > trailing whitespaces). > Great! I will now write a few words of documentation. This page [[info:org#Org-Plot]] seems to be the right place, unless someone has a better idea.

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-29 Thread Nicolas Goaziou
Hello, Thierry Banel writes: > This new patch takes into account all your feedback. > Thanks again for the time spent ! Patch applied (with tiny changes to comments formatting, and a few trailing whitespaces). Thank you for this work. Regards, -- Nicolas Goaziou

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-28 Thread Thierry Banel
Hi Nicolas. This new patch takes into account all your feedback. Thanks again for the time spent ! Thierry Le 28/08/2014 01:28, Nicolas Goaziou a écrit : > > You forgot a space at the end of the sentence. Actually, this is the > case in all your docstrings. Right. Fixed. > > Use "\\[universal-

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-27 Thread Nicolas Goaziou
Thierry Banel writes: > Hereafter is an enhanced version of orgtbl-ascii-plot. > > Thanks, Nicolas, for your feedback. Enhancements you suggested include: > - let-binding (instead of setq) > - better support for table headers (correct parsing of 'hline) > - no dependency on cl-lib (hopefully achi

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-27 Thread Thierry Banel
Hereafter is an enhanced version of orgtbl-ascii-plot. Thanks, Nicolas, for your feedback. Enhancements you suggested include: - let-binding (instead of setq) - better support for table headers (correct parsing of 'hline) - no dependency on cl-lib (hopefully achieving Emacs 23 support) - use dolis

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-26 Thread Thierry Banel
Everything is clear now. Thanks Nicolas for those guidelines. Regards, Thierry Le 27/08/2014 00:09, Nicolas Goaziou a écrit : > Actually, `dolist' is a macro from "subr.el", which is then shadowed by > `cl-dolist', so there's no problem here. > > BTW, you can use macros from cl (cl-lib doesn't exi

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-26 Thread Nicolas Goaziou
Thierry Banel writes: > Do you recommend to stay away from CL & CL-LIB for ORG stuff ? > `DOLIST' comes from CL as well... Actually, `dolist' is a macro from "subr.el", which is then shadowed by `cl-dolist', so there's no problem here. BTW, you can use macros from cl (cl-lib doesn't exist in Em

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-26 Thread Thierry Banel
Le 26/08/2014 22:27, Nicolas Goaziou a écrit : Thierry Banel writes: I'll change to let-binding. What is the rational for that ? Better byte-code ? This is faster, indeed. Also, the scope of the binding is explicit. It is sometimes h

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-26 Thread Nicolas Goaziou
Thierry Banel writes: > I'll change to let-binding. What is the rational for that ? Better > byte-code ? This is faster, indeed. Also, the scope of the binding is explicit. It is sometimes hard to tell where the value of a setq'ed variable comes from. > Can I limit VALUE to numbers ? VALUE come

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-26 Thread Thierry Banel
Thanks Nicolas for your valuable insight. I will apply your recommendations. Le 26/08/2014 10:29, Nicolas Goaziou a écrit : (orgtbl-ascii-plot): top-level function (orgtbl-ascii-draw), (orgtbl-uc-draw-grid), (orgtbl-uc-draw-cont):

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-26 Thread Nicolas Goaziou
Hello, Thierry Banel writes: > Sorry for the late answer, I was on the road. > The patch is attached hereafter. Thank you for the patch. Some comments follow. > From 5fddaba2208c2cb4ce3b6bc24d0d10571124fb39 Mon Sep 17 00:00:00 2001 > From: Thierry Banel > Date: Mon, 11 Aug 2014 00:00:21 +0200

Re: [O] make orgtbl-ascii-plot easier to install

2014-08-10 Thread Thierry Banel
Le 28/07/2014 16:40, Bastien a écrit : >> Of course, I am still open to Dominik Carsten suggestion >> to add it into the core (org-table.el). >> http://thread.gmane.org/gmane.emacs.orgmode/79668 > Please go ahead and provide a patch for this, I agree this > is a nice addition for Org's core. > Sorr

Re: [O] make orgtbl-ascii-plot easier to install

2014-07-28 Thread Bastien
Hi Thierry, Thierry Banel writes: > I moved orgtbl-ascii-plot to MELPA (it was in Worg). > (orgtbl-ascii-plot draws plots in pure Emacs by typing C-c p). Thanks for this. > Of course, I am still open to Dominik Carsten suggestion > to add it into the core (org-table.el). > http://thread.gmane.

[O] make orgtbl-ascii-plot easier to install

2014-07-13 Thread Thierry Banel
Hi The List I moved orgtbl-ascii-plot to MELPA (it was in Worg). (orgtbl-ascii-plot draws plots in pure Emacs by typing C-c p). Of course, I am still open to Dominik Carsten suggestion to add it into the core (org-table.el). http://thread.gmane.org/gmane.emacs.orgmode/79668 In the process I wrot