Re: [O] org-agenda-filter-by-tag-refine defaults to exclude

2016-01-31 Thread Gustav Wikström
Hi Viktor, Kyle Fair enough. I’m not attached to the refine-function at all. If you like to have it removed, then remove it, unless others are of different opinion ofc. The functionality is fairly complex, so removing the keybinding might make it seem less complicated. /G From: Viktor

Re: [O] org-agenda-filter-by-tag-refine defaults to exclude

2016-01-29 Thread Viktor Rosenfeld
Hi Gustav, currently, the remove functionality can also be accessed by C-u /. If we want to provide a dedicated hotkey, then the following definition will do it: (add-hook 'org-agenda-mode-hook (lambda() (local-set-key (kbd "\") '(lambda()

Re: [O] org-agenda-filter-by-tag-refine defaults to exclude

2016-01-29 Thread Kyle Meyer
Hi Gustav, Gustav Wikström writes: [...] > If you want to make any change, Given that, as of 6c6ae99, the function's behavior doesn't match its name or its previous behavior, I don't think leaving it unchanged is a good option. > I'd suggest to instead change the name > of

Re: [O] org-agenda-filter-by-tag-refine defaults to exclude

2016-01-28 Thread Gustav Wikström
Hi Kyle, Viktor and the group, I'd say it's a naming-problem. What, really, is the purpose of the function? Because applying the proposed change essentially makes the function identical to the function it calls. Right? And that function is still available for the user, so a "refinement" can be

Re: [O] org-agenda-filter-by-tag-refine defaults to exclude

2016-01-11 Thread Kyle Meyer
Hi Viktor, Viktor Rosenfeld writes: > Hi, > > I noticed that org-agenda-filter-by-tag-refine started to exclude > selected tags by default recently because the 'refine in the call to > org-agenda-filter-by-tag is interpreted as an exclude flag. This seems to have been

[O] org-agenda-filter-by-tag-refine defaults to exclude

2016-01-04 Thread Viktor Rosenfeld
Hi, I noticed that org-agenda-filter-by-tag-refine started to exclude selected tags by default recently because the 'refine in the call to org-agenda-filter-by-tag is interpreted as an exclude flag. The attached patch fixes this. However, it seems that the function is superfluous because