Re: [Orgmode] [PATCH] Don't create marker if target is entire file.

2010-07-06 Thread Carsten Dominik

Applied, thanks.

I am really enjoying how things get resolved now
without me interacting, and all I need to do is to apply
a patch.

Thanks to all who contributed in this thread and in others!

- Carsten

On Jul 5, 2010, at 9:28 PM, David Maus wrote:


* org-agenda.el (org-agenda-bulk-action): Don't create marker for
position if target is entire file.

If the target of a bulk refile operation is the entire file,
`org-refile-get-location' returns nil for the refile position.
Creating a marker for the target file's buffer at position nil returns
a marker that points nowhere (Cf. GNU Emacs Lisp Reference Manual,
31.6).  `org-refile' adds headings to level 1 if the target position
for the target file is nil -- and hence a marker that points nowhere
is not nil, tries to jump to nowhere.
---
lisp/org-agenda.el |   11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 4345f06..1fe4639 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7489,11 +7489,12 @@ The prefix arg is passed through to the  
command if possible.

   Refile to: 
   (marker-buffer (car org-agenda-bulk-marked-entries))
   org-refile-allow-creating-parent-nodes))
-  (setcar (nthcdr 3 rfloc)
- (move-marker (make-marker) (nth 3 rfloc)
-  (or (get-file-buffer (nth 1 rfloc))
-  (find-buffer-visiting (nth 1 rfloc))
-  (error This should not happen
+  (if (nth 3 rfloc)
+ (setcar (nthcdr 3 rfloc)
+ (move-marker (make-marker) (nth 3 rfloc)
+  (or (get-file-buffer (nth 1 rfloc))
+  (find-buffer-visiting (nth 1 rfloc))
+  (error This should not happen)

  (setq cmd (list 'org-agenda-refile nil (list 'quote rfloc) t)
redo-at-end t))
--
1.7.1


___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


- Carsten




___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[Orgmode] [PATCH] Don't create marker if target is entire file.

2010-07-05 Thread David Maus
* org-agenda.el (org-agenda-bulk-action): Don't create marker for
position if target is entire file.

If the target of a bulk refile operation is the entire file,
`org-refile-get-location' returns nil for the refile position.
Creating a marker for the target file's buffer at position nil returns
a marker that points nowhere (Cf. GNU Emacs Lisp Reference Manual,
31.6).  `org-refile' adds headings to level 1 if the target position
for the target file is nil -- and hence a marker that points nowhere
is not nil, tries to jump to nowhere.
---
 lisp/org-agenda.el |   11 ++-
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 4345f06..1fe4639 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7489,11 +7489,12 @@ The prefix arg is passed through to the command if 
possible.
   Refile to: 
   (marker-buffer (car org-agenda-bulk-marked-entries))
   org-refile-allow-creating-parent-nodes))
-  (setcar (nthcdr 3 rfloc)
- (move-marker (make-marker) (nth 3 rfloc)
-  (or (get-file-buffer (nth 1 rfloc))
-  (find-buffer-visiting (nth 1 rfloc))
-  (error This should not happen
+  (if (nth 3 rfloc)
+ (setcar (nthcdr 3 rfloc)
+ (move-marker (make-marker) (nth 3 rfloc)
+  (or (get-file-buffer (nth 1 rfloc))
+  (find-buffer-visiting (nth 1 rfloc))
+  (error This should not happen)
 
   (setq cmd (list 'org-agenda-refile nil (list 'quote rfloc) t)
redo-at-end t))
-- 
1.7.1


___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode