Re: [Orgmode] Bug: org-wl: from property not set as expected [6.33]
Applied, thanks.
- Carsten
On Nov 14, 2009, at 12:43 PM, David Maus wrote:
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report?
See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
When storing a link to a Wanderlust message the link's :from property
is not set to the full address field (i.e. Name email) if the
Wanderlust customization variable `wl-use-petname' is set to 't, what
is it's default value.
This causes unexpected behavior when `org-store-link' is called for a
remember template as the template's :fromname and :fromaddress
properties are not set correctly: %:fromname is empty and :fromaddress
contains the senders name and not the address.
This misbehaviour is caused because `org-wl-store-link' calls
`wl-summary-line-from' which respects `wl-use-petname' and returns the
senders name only if this variable is set to 't.
Attached patch changes this issue by simply make `org-wl-store-link'
use the same code to get the from field as it does for the to field.
Emacs : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
of 2009-10-23 on elegiac, modified by Debian
Package: Org-mode version 6.33
current state:
==
(setq
org-clock-in-switch-to-state STARTED
org-todo-keyword-faces '((TODO :foreground red :weight bold)
(STARTED :foreground orange red :weight bold)
(DONE :foreground light green) (MAYBE :foreground
tomato)
(WAITING :foreground tan2 :weight bold)
(CANCELLED :foreground firebrick)
(APPT :foreground DeepSkyBlue1 :weight bold)
(DEFERRED :foreground light slate gray))
org-agenda-custom-commands '((r Refile New Notes and Tasks tags
LEVEL=1+REFILE
((org-agenda-todo-ignore-with-date nil)))
(s Started Tasks todo STARTED
((org-agenda-todo-ignore-scheduled nil) (org-agenda-todo-
ignore-deadlines nil)
(org-agenda-todo-ignore-with-date nil))
)
)
org-agenda-files '(/home/david/Org/pg.org /home/david/Org/
work.org /home/david/Org/tec.org /home/david/Org/priv.org
/home/david/Org/refile.org)
org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
org-agenda-tags-column -120
org-checklist-export-function 'org-export-as-ascii
org-completion-use-ido t
org-after-todo-state-change-hook '(org-clock-out-if-current org-
checklist)
org-agenda-todo-ignore-scheduled t
org-todo-state-tags-triggers '((todo (NOTE)) ( (NOTE . t)))
org-log-redeadline 'time
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tab-first-hook '(org-hide-block-toggle-maybe)
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-confirm-shell-link-function 'yes-or-no-p
org-todo-keywords '((sequence TODO(t) STARTED(s) | DONE(D@))
(sequence MAYBE(m) WAITING(w@/!) | CANCELLED(C@))
(sequence APPT(a) DEFERRED(d@/!) | DONE(D@)
CANCELLED(C@)))
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-directory ~/Org
org-log-reschedule 'time
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-
drawers org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-publish-project-alist '((private-dynamic :base-directory ~/
Org/www :base-extension org :publishing-directory
~/www/private :publishing-function (org-publish-org-to-
html) :recursive t :author
David Maus :email maus.da...@gmail.com)
(private-static :base-directory ~/Org/www :base-
extension css :publishing-directory
~/www/private :publishing-function org-publish-
attachment :recursive t)
(private :components (private-dynamic
private-static)))
org-mode-hook '(#[nil \300\301\302\303\304$\207 [org-add-hook
change-major-mode-hook org-show-block-all append local] 5])
org-refile-targets '((org-agenda-files :maxlevel . 3))
org-confirm-elisp-link-function 'yes-or-no-p
org-refile-use-outline-path 'file
org-log-into-drawer LOGBOOK
org-agenda-todo-ignore-with-date t
org-enforce-todo-dependencies t
org-occur-hook '(org-first-headline-recenter)
org-from-is-user-regexp \\David Maus\\
org-tags-column -120
org-remember-templates '((todo 116
* TODO %^{Description} %^G\n :PROPERTIES:\n :Created: %U
\n :Ref: %a\n :END:\n\n %?
refile.org bottom nil)
(appt 97
* APPT %^{Description} %^G\n %^T\n :PROPERTIES:
\n :Created: %U\n :Ref: %a\n :END:\n\n %?
refile.org bottom nil)
(note 110
* %^{Description} :NOTE:%^G\n :PROPERTIES:\n :Created: %U
\n :Ref: %a\n :END:\n\n %?
[Orgmode] Bug: org-wl: from property not set as expected [6.33]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
When storing a link to a Wanderlust message the link's :from property
is not set to the full address field (i.e. Name email) if the
Wanderlust customization variable `wl-use-petname' is set to 't, what
is it's default value.
This causes unexpected behavior when `org-store-link' is called for a
remember template as the template's :fromname and :fromaddress
properties are not set correctly: %:fromname is empty and :fromaddress
contains the senders name and not the address.
This misbehaviour is caused because `org-wl-store-link' calls
`wl-summary-line-from' which respects `wl-use-petname' and returns the
senders name only if this variable is set to 't.
Attached patch changes this issue by simply make `org-wl-store-link'
use the same code to get the from field as it does for the to field.
Emacs : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
of 2009-10-23 on elegiac, modified by Debian
Package: Org-mode version 6.33
current state:
==
(setq
org-clock-in-switch-to-state STARTED
org-todo-keyword-faces '((TODO :foreground red :weight bold) (STARTED
:foreground orange red :weight bold)
(DONE :foreground light green) (MAYBE
:foreground tomato)
(WAITING :foreground tan2 :weight bold)
(CANCELLED :foreground firebrick)
(APPT :foreground DeepSkyBlue1 :weight bold)
(DEFERRED :foreground light slate gray))
org-agenda-custom-commands '((r Refile New Notes and Tasks tags
LEVEL=1+REFILE
((org-agenda-todo-ignore-with-date nil)))
(s Started Tasks todo STARTED
((org-agenda-todo-ignore-scheduled nil)
(org-agenda-todo-ignore-deadlines nil)
(org-agenda-todo-ignore-with-date nil))
)
)
org-agenda-files '(/home/david/Org/pg.org /home/david/Org/work.org
/home/david/Org/tec.org /home/david/Org/priv.org
/home/david/Org/refile.org)
org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
org-agenda-tags-column -120
org-checklist-export-function 'org-export-as-ascii
org-completion-use-ido t
org-after-todo-state-change-hook '(org-clock-out-if-current org-checklist)
org-agenda-todo-ignore-scheduled t
org-todo-state-tags-triggers '((todo (NOTE)) ( (NOTE . t)))
org-log-redeadline 'time
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tab-first-hook '(org-hide-block-toggle-maybe)
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-confirm-shell-link-function 'yes-or-no-p
org-todo-keywords '((sequence TODO(t) STARTED(s) | DONE(D@))
(sequence MAYBE(m) WAITING(w@/!) | CANCELLED(C@))
(sequence APPT(a) DEFERRED(d@/!) | DONE(D@)
CANCELLED(C@)))
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-directory ~/Org
org-log-reschedule 'time
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-publish-project-alist '((private-dynamic :base-directory ~/Org/www
:base-extension org :publishing-directory
~/www/private :publishing-function
(org-publish-org-to-html) :recursive t :author
David Maus :email maus.da...@gmail.com)
(private-static :base-directory ~/Org/www
:base-extension css :publishing-directory
~/www/private :publishing-function
org-publish-attachment :recursive t)
(private :components (private-dynamic
private-static)))
org-mode-hook '(#[nil \300\301\302\303\304$\207 [org-add-hook
change-major-mode-hook org-show-block-all append local] 5])
org-refile-targets '((org-agenda-files :maxlevel . 3))
org-confirm-elisp-link-function 'yes-or-no-p
org-refile-use-outline-path 'file
org-log-into-drawer LOGBOOK
org-agenda-todo-ignore-with-date t
org-enforce-todo-dependencies t
org-occur-hook '(org-first-headline-recenter)
org-from-is-user-regexp \\David Maus\\
org-tags-column -120
org-remember-templates '((todo 116
* TODO %^{Description} %^G\n :PROPERTIES:\n
:Created: %U\n :Ref: %a\n :END:\n\n %?
refile.org bottom nil)
(appt 97
* APPT %^{Description} %^G\n %^T\n :PROPERTIES:\n
:Created: %U\n :Ref: %a\n :END:\n\n %?
refile.org bottom nil)
(note 110
