Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-24 Thread Bastien
Hi Matt, Bastien writes: > I'm not able to reproduce your problem with emacs -q and the minimal > configuration you proposed. Can I ask you to check again? Forget my message - I *can* reproduce your issue, I will investigate this tomorrow. Thanks for your patience, -- Bastien

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-24 Thread Bastien
Hi Matt, Matt Lundin writes: > Matt Lundin writes: >> >> Has there been any progress on this issue? I am finding that the local >> span bindings in the custom command above still do not have any effect. >> My default agenda span is a day. If I call the custom command above, it >> displays only

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-24 Thread Matt Lundin
Matt Lundin writes: > > Has there been any progress on this issue? I am finding that the local > span bindings in the custom command above still do not have any effect. > My default agenda span is a day. If I call the custom command above, it > displays only one day, despite the local setting. I

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-24 Thread Matt Lundin
Matt Lundin writes: > Bastien Guerry writes: > >> Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted". > >>> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a >>> possible default span if it is set. > This patch breaks custom commands --- i.e., if one bin

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-19 Thread Bastien
Hi Carsten, Carsten Dominik writes: > wow, you found your way through the agenda code maze. Yeah, the trip in the code was really a-mazing :) > Looks good to me! Thanks for getting this fixed, so > that Juliens cleaner implementation can stay the basis > for time span setting. This basis is

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-18 Thread Carsten Dominik
Hi Bastien, On Feb 18, 2011, at 3:19 PM, Bastien wrote: Hi Carsten and all, Carsten Dominik writes: For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I've finally push a fix for this problem. The issue appeared when trying

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-18 Thread Gábor Melis
Bastien writes: > Hi Carsten and all, > > Carsten Dominik writes: > >> For what it is worth, and for the record, I still do not >> believe that this is the correct solution to the problem. > > I've finally push a fix for this problem. > > The issue appeared when trying to redo a block agenda c

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-18 Thread Bastien
Hi Carsten and all, Carsten Dominik writes: > For what it is worth, and for the record, I still do not > believe that this is the correct solution to the problem. I've finally push a fix for this problem. The issue appeared when trying to redo a block agenda command, where previous restricti

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-17 Thread Bastien
Hi Carsten, Carsten Dominik writes: > For what it is worth, and for the record, I still do not > believe that this is the correct solution to the problem. > I believe it causes the issue reported in > > http://thread.gmane.org/gmane.emacs.orgmode/37673 > > But unfortunately I have not had ti

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-17 Thread Carsten Dominik
Hi Bastien, hi Julien, For what it is worth, and for the record, I still do not believe that this is the correct solution to the problem. I believe it causes the issue reported in http://thread.gmane.org/gmane.emacs.orgmode/37673 But unfortunately I have not had time to study the issue in mo

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Michael Brand
Hi Bastien On Thu, Feb 10, 2011 at 15:35, Bastien wrote: > Matt and Michael, please report any problem. The two test cases `d g' and `w f d g' in custom agenda view that I described above do still not work like I expect. > Michael, thanks for the detailed step-by-step way of reproducing the > p

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Bastien
Julien Danjou writes: >> But maybe you can just delocalize that one variable instead, >> using kill-local-variable? > > It's a possibility, but I think it's more logical to "reset" every local > variable. I just pushed a (temporary) fix, following Carsten's suggestion of using kill-local-variabl

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Julien Danjou
On Thu, Feb 10 2011, Carsten Dominik wrote: > No, I believe you did kill-all-local-variables, which is a very bad > idea. Org uses local variables to remember settings when refreshing. > And apparently this call was executed in an innocent org > buffer, reverting its major mode to fundamental mod

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Carsten Dominik
Hi Michael, thanks. - Carsten On Feb 10, 2011, at 12:18 PM, Michael Brand wrote: > Hi Carsten > > On Thu, Feb 10, 2011 at 10:20, Carsten Dominik > wrote: >> I am not sure if I know exactly what the remaining problem is. >> Could someone summarize this - I'd be happy to take a look and see if

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Carsten Dominik
On Feb 10, 2011, at 11:51 AM, Julien Danjou wrote: > On Thu, Feb 10 2011, Carsten Dominik wrote: > >> I am not sure if I know exactly what the remaining problem is. >> Could someone summarize this - I'd be happy to take a look and see if I can >> fix it. > > The problem is that org-agenda-list

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Michael Brand
Hi Carsten On Thu, Feb 10, 2011 at 10:20, Carsten Dominik wrote: > I am not sure if I know exactly what the remaining problem is. > Could someone summarize this - I'd be happy to take a look and see if I can > fix it. Not the summary you asked for but a related issue, could you please also cons

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Julien Danjou
On Thu, Feb 10 2011, Carsten Dominik wrote: > I am not sure if I know exactly what the remaining problem is. > Could someone summarize this - I'd be happy to take a look and see if I can > fix it. The problem is that org-agenda-list, when called use as span either: (or span org-agenda-current-s

Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-10 Thread Carsten Dominik
On Feb 9, 2011, at 5:37 PM, Bastien wrote: > Julien Danjou writes: > >> On Sat, Feb 05 2011, Matt Lundin wrote: >> >>> This results in only a day view because org-agenda-current-span is still >>> 'day. >> >> Here's a proposal fix. > > I applied it to early, I made the error of not testing it

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-09 Thread Bastien
Julien Danjou writes: > On Sat, Feb 05 2011, Matt Lundin wrote: > >> This results in only a day view because org-agenda-current-span is still >> 'day. > > Here's a proposal fix. I applied it to early, I made the error of not testing it with a bare "emacs -q". The fix is not okay. Let's find a

[Accepted] [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-08 Thread Bastien Guerry
e: text/plain; charset="utf-8" > MIME-Version: 1.0 > Content-Transfer-Encoding: 7bit > Subject: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda > changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] > Date: Mon, 07 Feb 2011 16:39:17 -0

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-07 Thread Julien Danjou
On Sat, Feb 05 2011, Matt Lundin wrote: > This results in only a day view because org-agenda-current-span is still > 'day. Here's a proposal fix. I could have setq org-agenda-current-span to nil as a work around, but it seems more logical to just kill all the local variables. That is, a custom a

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-05 Thread Julien Danjou
On Sat, Feb 05 2011, Matt Lundin wrote: > This patch breaks custom commands --- i.e., if one binds org-agenda-span > in a custom command, it seems to be overridden by the span of whatever > agenda command one last called (i.e., org-agenda-current-span). > > Steps to replicate: > > 1. (setq org-age

[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

2011-02-04 Thread Matt Lundin
Bastien Guerry writes: > Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted". >> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a >> possible default span if it is set. >> >> Signed-off-by: Julien Danjou >> --- >> lisp/org-agenda.el |5 - >> 1