[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
On Monday 05 July 2010 23:12:46 Bernt Hansen wrote: Hi Bernt, I did some debugging. Thanks. Sorry I've been tied up with work today. No problem. I had some time (and fun) with the debugging. That was the first time I dug into the depth of org's internals. ;-) Oh! It's not that the future dates are missing it's the entry for _today_ that is missing. Ups, I should have been a bit more clear on that. :-) Anyway, since Carsten reverted that commit, the agenda works again. Bye, Tassilo ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
Bernt Hansen be...@norang.ca writes: Hi Bernt, This works for me in both GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian Org-mode version 6.36trans (release_6.36.509.g9e9b) and GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1, Org-mode version 6.36trans (release_6.36.509.g9e9b) I use GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of 2010-06-29 on thinkpad and the current org git HEAD. Unfortunately, I don't have a clue what might cause this problem. If you have any idea, I'm happy to edebug anything you want or provide any additional information. Do you have org-agenda-repeating-timestamp-show-all set to t? Yes, I use the default value which is t. Bye, Tassilo ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
Tassilo Horn tass...@member.fsf.org writes: Hi again, This works for me in both GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian Org-mode version 6.36trans (release_6.36.509.g9e9b) and GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1, Org-mode version 6.36trans (release_6.36.509.g9e9b) I use GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of 2010-06-29 on thinkpad and the current org git HEAD. Now I tried Emacs 23.2, and the problem still persists. Did you do a make clean before make in org to exclude the possibility of having old (but working) *.elc files around? Bye, Tassilo ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
Tassilo Horn tass...@member.fsf.org writes: Tassilo Horn tass...@member.fsf.org writes: Hi again, This works for me in both GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian Org-mode version 6.36trans (release_6.36.509.g9e9b) and GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1, Org-mode version 6.36trans (release_6.36.509.g9e9b) I use GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of 2010-06-29 on thinkpad and the current org git HEAD. Now I tried Emacs 23.2, and the problem still persists. Did you do a make clean before make in org to exclude the possibility of having old (but working) *.elc files around? I have no .elc files - I run directly from the source files (which greatly simplifies jumping around on different commits when I'm trying things) Does reverting that commit locally fix it for you? Do I understand the problem correctly? If I use your example entry (by sticking it at a level 1 task in my refile.org and doing v m in the agenda to show all entries for the month I see the future entries in my agenda but you don't? I'm confused. -Bernt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
Tassilo Horn tass...@member.fsf.org writes: Hi again, Bernt! I did some debugging. Thanks. Sorry I've been tied up with work today. The reason that the repeating events are not shown is that `org-agenda-get-timestamps' doesn't return those repeater events, because when it iterates over all timestamps of a file, the test in the following `if' always returns t and so we are skipping. --8---cut here---start-8--- (catch :skip (and (org-at-date-range-p) (throw :skip nil)) (org-agenda-skip) (if (and (match-end 1) (not (= d1 (org-time-string-to-absolute (match-string 1) d1 nil org-agenda-repeating-timestamp-show-all (throw :skip nil)) --8---cut here---end---8--- This happens, because `org-time-string-to-absolute' returns the first date (the literally written date), not the closest repeating date. For example, for 2010-06-28 Mon 22:00 +1w (last week's Monday) that function returns 733951, although it should return 733958 (last week's Monday + 7 days = today), I guess. The underlined predicate looks suspicious to me: --8---cut here---start-8--- (defun org-time-string-to-absolute (s optional daynr prefer show-all) Convert a time stamp to an absolute day number. If there is a specifyer for a cyclic time stamp, get the closest date to DAYNR. PREFER and SHOW-ALL are passed through to `org-closest-date'. the variable date is bound by the calendar when this is called. (let ((today (calendar-absolute-from-gregorian (calendar-current-date (cond ((and daynr (string-match \\`%%\\((.*)\\) s)) (if (org-diary-sexp-entry (match-string 1 s) date) daynr (+ daynr 1000))) ((and daynr (not (eq daynr today)) (string-match \\+[0-9]+[dwmy] s)) ^^ (org-closest-date s (if (and (boundp 'daynr) (integerp daynr)) daynr (time-to-days (current-time))) (match-string 0 s) prefer show-all)) (t (time-to-days (apply 'encode-time (org-parse-time-string s))) --8---cut here---end---8--- Why shouldn't that case trigger when daynr is today? In that case, we don't even look at the timestamp s... This change was my second attempt at fixing the scheduled display when a weekly TODO entry is missed (ie it's over a week late already). The agenda display. For the case where we're displaying the scheduled date for today's agenda I wanted it to reflect how many days late the task is instead of rolling over on the cyclic repeater. I don't (yet) understand why your example works on my agenda but not yours ... Oh! It's not that the future dates are missing it's the entry for _today_ that is missing. So yes my commit breaks this and I'll get it reverted. Thanks for reporting this issue! Regards, Bernt I deleted the whole underlined predicate, and then the agenda works again for me. Bye, Tassilo ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
Bernt Hansen be...@norang.ca writes: Oh! It's not that the future dates are missing it's the entry for _today_ that is missing. So yes my commit breaks this and I'll get it reverted. Hi Carsten, Please revert the following commit. It's my second failed attempt at fixing this issue. I think I'll just leave it alone for now. I'd rather have the agenda display all entries as it does now than miss cyclic repeating entries for today. , | commit 516640aff96b627d8ad412f6cdb436535600aff0 | Author: Bernt Hansen be...@norang.ca | Date: Wed Jun 23 02:40:16 2010 + | | Fix agenda display for late scheduled and deadline tasks | | * lisp/org.el (org-time-string-to-absolute): Ignore cyclic repeater | when displaying items on todays agenda date. | | Ignore the cyclic repeater when displaying items on today's agenda | date. If you have a weekly task and miss the date the agenda view | will show more than a week late now instead of resetting on the | cyclic repeating date. This makes it much more obvious when you | missed a repeating task after the repeater. ` Thanks, Bernt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
Hi Bernt, thanks, I have reverted the commit. Too bad it is not working. - Carsten On Jul 5, 2010, at 11:16 PM, Bernt Hansen wrote: Bernt Hansen be...@norang.ca writes: Oh! It's not that the future dates are missing it's the entry for _today_ that is missing. So yes my commit breaks this and I'll get it reverted. Hi Carsten, Please revert the following commit. It's my second failed attempt at fixing this issue. I think I'll just leave it alone for now. I'd rather have the agenda display all entries as it does now than miss cyclic repeating entries for today. , | commit 516640aff96b627d8ad412f6cdb436535600aff0 | Author: Bernt Hansen be...@norang.ca | Date: Wed Jun 23 02:40:16 2010 + | | Fix agenda display for late scheduled and deadline tasks | | * lisp/org.el (org-time-string-to-absolute): Ignore cyclic repeater | when displaying items on todays agenda date. | | Ignore the cyclic repeater when displaying items on today's agenda | date. If you have a weekly task and miss the date the agenda view | will show more than a week late now instead of resetting on the | cyclic repeating date. This makes it much more obvious when you | missed a repeating task after the repeater. ` Thanks, Bernt - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
