Re: [Orgmode] org-choose bugfix - whoops
Hi Tom, On Apr 9, 2009, at 2:05 AM, Tom Breton (Tehom) wrote: My previous fix was mistaken. Not sure why it passed tests; I have two theories. Regardless, it was wrong. Current `(org-outline-level)' seems the correct LEVEL= matcher argument to make `org-map-entries' find only an item's immediate children. (Operated on by `org-reduced-level' of course) I don't quite understand why. Second, I may have solved the mystery of how the bug got by me before. `org-map-entries' used to place point at the beginning of an item, a fact which I used to recognize visiting the same item. That seems to have changed between org versions. Third, I have fixed the real bug - properly now, I hope! - and attached a patch. I have applied the patch. Indeed, there was a problem with the cursor positioning during mapping, but I think this should be fixed again. Really, I want the cursor at the beginning of the entry when the mapping function is called. So maybe you'd like to pull from git, check again, and revert the change? I believe that the back-to-heading wrapper will not hurt, but I also believe it is no longer necessary. My apologies for the mess. - Carsten ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] org-choose bugfix
Applied, thanks. - Carsten On Apr 7, 2009, at 2:13 AM, Tom Breton (Tehom) wrote: I don't know how this slipped by me before, and I was sure that I had run the test suite and validated the previous fix, but I just noticed a serious bug, and patched it. The bug is that org-choose uses the wrong number for LEVEL, resulting in no keep-sensible checking. I attach a patch for it. Also patched a doc typo. (6.25 is the OLD half of the patch - I fixed it and then realized I had no old one to diff it to so I fetched the newest org-mode) Tom org-choose.el.diff___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] org-choose bugfix - whoops
My previous fix was mistaken. Not sure why it passed tests; I have two theories. Regardless, it was wrong. Current `(org-outline-level)' seems the correct LEVEL= matcher argument to make `org-map-entries' find only an item's immediate children. (Operated on by `org-reduced-level' of course) I don't quite understand why. Second, I may have solved the mystery of how the bug got by me before. `org-map-entries' used to place point at the beginning of an item, a fact which I used to recognize visiting the same item. That seems to have changed between org versions. Third, I have fixed the real bug - properly now, I hope! - and attached a patch. Tom Breton (Tehom) org-choose.el.diff Description: Binary data ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] org-choose bugfix
Here is a bugfix for org-choose that I've been meaning to post. The bug was this: When looking for alternatives, it looks at the whole tree, not just the immediate children. Now fixed. Patch is attached. Tom Breton (Tehom) org-choose.el.diff Description: Binary data ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] org-choose bugfix
On Tue, Feb 24, 2009 at 6:21 AM, Tom Breton (Tehom) wrote: Here is a bugfix for org-choose that I've been meaning to post. The bug was this: When looking for alternatives, it looks at the whole tree, not just the immediate children. Now fixed. Patch is attached. This seems to be already in the latest git. And my test file now works! Thanks. -- Manish ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
