RE: [PATCH] Adaptive Org faces in headings?

2020-10-28 Thread Rob Davenport
: Emacs-orgmode On Behalf Of Rob Davenport Sent: Tuesday, October 27, 2020 2:31 To: Ihor Radchenko Cc: Org-mode Subject: RE: [PATCH] Adaptive Org faces in headings? Thank you very much for this patch, Ihor. It fixes the issue on my system. I've only recently been getting org from

RE: [PATCH] Adaptive Org faces in headings?

2020-10-27 Thread Rob Davenport
Message- From: Emacs-orgmode On Behalf Of Protesilaos Stavrou Sent: Friday, September 18, 2020 5:53 To: Ihor Radchenko Cc: Bastien ; Protesilaos Stavrou ; Org-mode ; Diego Zamboni Subject: Re: [PATCH] Adaptive Org faces in headings? This email originated from outside of your organization

Re: [PATCH] Adaptive Org faces in headings?

2020-10-07 Thread Kyle Meyer
Protesilaos Stavrou writes: > Tried to format the patch. Please see the attached file. If it does > not work, feel free to dismiss it and just apply the change yourself. Looks good. Applied (23f9415c6). Thanks.

Re: [PATCH] Adaptive Org faces in headings?

2020-10-06 Thread Protesilaos Stavrou
On 2020-10-07, 00:20 -0400, Kyle Meyer wrote: > Protesilaos Stavrou writes: > >> Sorry to re-open this issue. The following change extends Ihor's patch >> to also cover checkbox statistics. Seems to work just fine on my end. >> Thanks again! > > Thanks for the patch. Looks good on my end too.

Re: [PATCH] Adaptive Org faces in headings?

2020-10-06 Thread Kyle Meyer
Protesilaos Stavrou writes: > Sorry to re-open this issue. The following change extends Ihor's patch > to also cover checkbox statistics. Seems to work just fine on my end. > Thanks again! Thanks for the patch. Looks good on my end too. Would you mind adding a commit message and sending the

Re: [PATCH] Adaptive Org faces in headings?

2020-10-05 Thread Protesilaos Stavrou
On 2020-09-26, 08:31 +0200, Bastien wrote: > Bastien writes: > >> Ihor Radchenko writes: >> >>> The attached patch seems to fix the issue. >> >> Applied as 979e82fc3, thanks a lot! > > Also, marking the initial bug report as closed, thanks again. Sorry to re-open this issue. The following

Re: [PATCH] Adaptive Org faces in headings?

2020-09-26 Thread Bastien
Bastien writes: > Ihor Radchenko writes: > >> The attached patch seems to fix the issue. > > Applied as 979e82fc3, thanks a lot! Also, marking the initial bug report as closed, thanks again. -- Bastien

Re: [PATCH] Adaptive Org faces in headings?

2020-09-23 Thread Protesilaos Stavrou
Bastien [2020-09-23, 14:25 +0200]: > Ihor Radchenko writes: > >> The attached patch seems to fix the issue. > > Applied as 979e82fc3, thanks a lot! Good news! Thanks to everyone for their contributions! -- Protesilaos Stavrou protesilaos.com

Re: [PATCH] Adaptive Org faces in headings?

2020-09-23 Thread Bastien
Ihor Radchenko writes: > The attached patch seems to fix the issue. Applied as 979e82fc3, thanks a lot! -- Bastien

Re: [PATCH] Adaptive Org faces in headings?

2020-09-21 Thread Mikhail Skorzhinskii
Hi, I've also tried to apply this patch and see if it will work on my, heavily customized in terms of theming, setup. It didn't spot any new issues. Instead it fixed face inheritance bugs with following elements: 1. Tags with customised faces; 2. Links; 3. Ellipsis; 4. TODO keywords; 5.

Re: [PATCH] Adaptive Org faces in headings?

2020-09-19 Thread Sheng Yang
Thanks for the patch! I noticed the patch also works for org-link, which had been a headache for me. On Fri, Sep 18, 2020, at 04:52, Protesilaos Stavrou wrote: > Ihor Radchenko [2020-09-17, 16:25 +0800]: > > > The attached patch seems to fix the issue. > > Can anyone test? I also tested, with

Re: [PATCH] Adaptive Org faces in headings?

2020-09-18 Thread Protesilaos Stavrou
Ihor Radchenko [2020-09-17, 16:25 +0800]: > The attached patch seems to fix the issue. > Can anyone test? I just tried this using the standard faces of 'emacs -Q' as well as custom themes. In short, the patch fixes the issue on my side. I tested whether faces on the headline would correctly

[PATCH] Adaptive Org faces in headings?

2020-09-17 Thread Ihor Radchenko
The attached patch seems to fix the issue. Can anyone test? Best, Ihor >From 7a5bfe2f514af1f6af48652155732dbcb9fe22d0 Mon Sep 17 00:00:00 2001 From: Ihor Radchenko Date: Thu, 17 Sep 2020 16:14:11 +0800 Subject: [PATCH] Make sure that headline faces take precedence * lisp/org.el