Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
No Wayman writes: > Bastien writes: > >> That's not just org-attach.el, right? The patch does not apply >> either in the bugfix or in the main branch. Could you resend it, >> also wrapping the body of the ChangeLog at <80 lines? M-x >> change-log-mode RET can help. TIA! > > Sorry. Didn't realize the first patch had already been committed, so I > rolled the change into that. > Separated the org-attach patch. See attached. Applied, thanks!
Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
Bastien writes: That's not just org-attach.el, right? The patch does not apply either in the bugfix or in the main branch. Could you resend it, also wrapping the body of the ChangeLog at <80 lines? M-x change-log-mode RET can help. TIA! Sorry. Didn't realize the first patch had already been committed, so I rolled the change into that. Separated the org-attach patch. See attached. >From c5b77469c2fbff5d9fd25fcf9025b8a354406256 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Sat, 25 Sep 2021 15:05:08 -0400 Subject: [PATCH] org-attach: Fix byte-comp function warning * (org-attach.el): Declare function for byte compiler. --- lisp/org-attach.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org-attach.el b/lisp/org-attach.el index 162a01e5e..c2d71514c 100644 --- a/lisp/org-attach.el +++ b/lisp/org-attach.el @@ -40,6 +40,7 @@ (require 'org-id) (declare-function dired-dwim-target-directory "dired-aux") +(declare-function dired-get-marked-files "dired" ( localp arg filter distinguish-one-marked error)) (declare-function org-element-property "org-element" (property element)) (declare-function org-element-type "org-element" (element)) (declare-function org-inlinetask-goto-beginning "org-inlinetask" ()) -- 2.33.0
Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
No Wayman writes: > No Wayman writes: > > And one more in org-attach.el. That's not just org-attach.el, right? The patch does not apply either in the bugfix or in the main branch. Could you resend it, also wrapping the body of the ChangeLog at <80 lines? M-x change-log-mode RET can help. TIA!
Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
No Wayman writes: > Recent changes have introduced byte-comp warnings for unknown > functions at compile time. > These warnings are "louder" now that more users are native compiling > Elisp, so one more reason to avoid them. > > See attached patch. Applied, thanks a lot.
Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
No Wayman writes: And one more in org-attach.el. See attached. >From 21620549a24703697d65c46bc88258cd4b2aaa80 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Sat, 25 Sep 2021 15:05:08 -0400 Subject: [PATCH] Fix byte-comp function warnings * (org.el, org-attach.el, org-keys.el, org-table.el): Declare functions for byte compiler. --- lisp/org-attach.el | 1 + lisp/org-keys.el | 3 ++- lisp/org-table.el | 1 + lisp/org.el| 5 + 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lisp/org-attach.el b/lisp/org-attach.el index 162a01e5e..c2d71514c 100644 --- a/lisp/org-attach.el +++ b/lisp/org-attach.el @@ -40,6 +40,7 @@ (require 'org-id) (declare-function dired-dwim-target-directory "dired-aux") +(declare-function dired-get-marked-files "dired" ( localp arg filter distinguish-one-marked error)) (declare-function org-element-property "org-element" (property element)) (declare-function org-element-type "org-element" (element)) (declare-function org-inlinetask-goto-beginning "org-inlinetask" ()) diff --git a/lisp/org-keys.el b/lisp/org-keys.el index 8f25bda2e..2984a4f51 100644 --- a/lisp/org-keys.el +++ b/lisp/org-keys.el @@ -58,7 +58,6 @@ (declare-function org-clone-subtree-with-time-shift "org" (n shift)) (declare-function org-columns "org" ( global columns-fmt-string)) (declare-function org-comment-dwim "org" (arg)) -(declare-function org-refile-copy "org" ()) (declare-function org-copy-special "org" ()) (declare-function org-copy-visible "org" (beg end)) (declare-function org-ctrl-c-ctrl-c "org" ( arg)) @@ -145,6 +144,8 @@ (declare-function org-promote-subtree "org" ()) (declare-function org-redisplay-inline-images "org" ()) (declare-function org-refile "org" ( arg1 default-buffer rfloc msg)) +(declare-function org-refile-copy "org" ()) +(declare-function org-refile-reverse "org-refile" ( arg default-buffer rfloc msg)) (declare-function org-reftex-citation "org" ()) (declare-function org-reload "org" ( arg1)) (declare-function org-remove-file "org" ( file)) diff --git a/lisp/org-table.el b/lisp/org-table.el index 0bc668757..9a703d8bc 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -66,6 +66,7 @@ (declare-function org-export-install-filters "ox" (info)) (declare-function org-export-table-has-special-column-p "ox" (table)) (declare-function org-export-table-row-is-special-p "ox" (table-row info)) +(declare-function org-forward-paragraph "org" ( arg)) (declare-function org-id-find "org-id" (id markerp)) (declare-function org-indent-line "org" ()) (declare-function org-load-modules-maybe "org" ( force)) diff --git a/lisp/org.el b/lisp/org.el index e1780cf8d..630bfb19d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -158,13 +158,18 @@ Stars are put in group 1 and the trimmed body in group 2.") (declare-function org-element-context "org-element" ( element)) (declare-function org-element-copy "org-element" (datum)) (declare-function org-element-create "org-element" (type props children)) +(declare-function org-element-extract-element "org-element" (element)) +(declare-function org-element-insert-before "org-element" (element location)) (declare-function org-element-interpret-data "org-element" (data)) (declare-function org-element-lineage "org-element" (blob types with-self)) (declare-function org-element-link-parser "org-element" ()) +(declare-function org-element-map "org-element" (data types fun info first-match no-recursion with-affiliated)) (declare-function org-element-nested-p "org-element" (elem-a elem-b)) (declare-function org-element-parse-buffer "org-element" ( granularity visible-only)) +(declare-function org-element-parse-secondary-string "org-element" (string restriction parent)) (declare-function org-element-property "org-element" (property element)) (declare-function org-element-put-property "org-element" (element property value)) +(declare-function org-element-restriction "org-element" (element)) (declare-function org-element-swap-A-B "org-element" (elem-a elem-b)) (declare-function org-element-timestamp-parser "org-element" ()) (declare-function org-element-type "org-element" (element)) -- 2.33.0
[PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
Recent changes have introduced byte-comp warnings for unknown functions at compile time. These warnings are "louder" now that more users are native compiling Elisp, so one more reason to avoid them. See attached patch. >From 736e72b56b10ba451016e4cc07305d8065c02ac9 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Sat, 25 Sep 2021 15:05:08 -0400 Subject: [PATCH] Fix byte-comp function warnings * (org.el, org-table.el org-keys.el) Declare functions for byte compiler. --- lisp/org-keys.el | 3 ++- lisp/org-table.el | 1 + lisp/org.el | 5 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lisp/org-keys.el b/lisp/org-keys.el index 8f25bda2e..2984a4f51 100644 --- a/lisp/org-keys.el +++ b/lisp/org-keys.el @@ -58,7 +58,6 @@ (declare-function org-clone-subtree-with-time-shift "org" (n shift)) (declare-function org-columns "org" ( global columns-fmt-string)) (declare-function org-comment-dwim "org" (arg)) -(declare-function org-refile-copy "org" ()) (declare-function org-copy-special "org" ()) (declare-function org-copy-visible "org" (beg end)) (declare-function org-ctrl-c-ctrl-c "org" ( arg)) @@ -145,6 +144,8 @@ (declare-function org-promote-subtree "org" ()) (declare-function org-redisplay-inline-images "org" ()) (declare-function org-refile "org" ( arg1 default-buffer rfloc msg)) +(declare-function org-refile-copy "org" ()) +(declare-function org-refile-reverse "org-refile" ( arg default-buffer rfloc msg)) (declare-function org-reftex-citation "org" ()) (declare-function org-reload "org" ( arg1)) (declare-function org-remove-file "org" ( file)) diff --git a/lisp/org-table.el b/lisp/org-table.el index 0bc668757..9a703d8bc 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -66,6 +66,7 @@ (declare-function org-export-install-filters "ox" (info)) (declare-function org-export-table-has-special-column-p "ox" (table)) (declare-function org-export-table-row-is-special-p "ox" (table-row info)) +(declare-function org-forward-paragraph "org" ( arg)) (declare-function org-id-find "org-id" (id markerp)) (declare-function org-indent-line "org" ()) (declare-function org-load-modules-maybe "org" ( force)) diff --git a/lisp/org.el b/lisp/org.el index e1780cf8d..630bfb19d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -158,13 +158,18 @@ Stars are put in group 1 and the trimmed body in group 2.") (declare-function org-element-context "org-element" ( element)) (declare-function org-element-copy "org-element" (datum)) (declare-function org-element-create "org-element" (type props children)) +(declare-function org-element-extract-element "org-element" (element)) +(declare-function org-element-insert-before "org-element" (element location)) (declare-function org-element-interpret-data "org-element" (data)) (declare-function org-element-lineage "org-element" (blob types with-self)) (declare-function org-element-link-parser "org-element" ()) +(declare-function org-element-map "org-element" (data types fun info first-match no-recursion with-affiliated)) (declare-function org-element-nested-p "org-element" (elem-a elem-b)) (declare-function org-element-parse-buffer "org-element" ( granularity visible-only)) +(declare-function org-element-parse-secondary-string "org-element" (string restriction parent)) (declare-function org-element-property "org-element" (property element)) (declare-function org-element-put-property "org-element" (element property value)) +(declare-function org-element-restriction "org-element" (element)) (declare-function org-element-swap-A-B "org-element" (elem-a elem-b)) (declare-function org-element-timestamp-parser "org-element" ()) (declare-function org-element-type "org-element" (element)) -- 2.33.0
