Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Kevin Foley writes: > Kyle Meyer writes: > >> Kevin, could you look into updating the test to avoid changing the repo >> state? > > Sorry about that. Do you have any suggestions on how to avoid changing > the state or any examples of similar tests? > > I tried the following to replace the file

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Kyle Meyer writes: > Kevin, could you look into updating the test to avoid changing the repo > state? Sorry about that. Do you have any suggestions on how to avoid changing the state or any examples of similar tests? I tried the following to replace the file with it's original contents but it

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin and Bastien, This change (010d1e3b6) needs a follow-up patch. Running the tests now leaves the working tree dirty: diff --git a/testing/examples/babel.org b/testing/examples/babel.org index b0942800a..e95a65b85 100644 --- a/testing/examples/babel.org +++ b/testing/examples/babel.org @@

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, I was able to apply the patch, I just did so against master. I also added you to the list of contributors here: https://orgmode.org/worg/org-contribute.html Thanks a lot! -- Bastien

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

/x-patch" instead of "text/plain" which I used last time, I'm not sure if that causes issues or if one is preferred. >From eae83992e0c671d0162ba60f567629138ecc0074 Mon Sep 17 00:00:00 2001 From: "Kevin J. Foley" Date: Tue, 28 Jan 2020 17:51:29 -0500 Subject: [PATC

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, Kevin Foley writes: > I've completed the copyright assignment so should be good to go with > this. great, thanks for letting us know! > Haven't had a chance to see if any conflicts have come up in the > meantime but will try to take a look today. I tried to apply your patch but I

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi, I've completed the copyright assignment so should be good to go with this. Haven't had a chance to see if any conflicts have come up in the meantime but will try to take a look today. Kevin

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, Kevin Foley writes: > Thank you for the feedback! I'm working with my employer regarding > copyright assignment and should have that sorted out shortly. I'll > submit the proposed changes once that's taken care. great, thanks a lot for taking the time to go through this! --

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

ver I >> believe this change should be small enough to not require it. >> >> Kevin Foley >> >> From 82e2d108536101c5a5ff9f8a0009051e5a308a3a Mon Sep 17 00:00:00 2001 >> From: "Kevin J. Foley" >> Date: Tue, 28 Jan 2020 17:51:29 -0500 >> Subject: [PATCH]

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

ot require it. > > Kevin Foley > > From 82e2d108536101c5a5ff9f8a0009051e5a308a3a Mon Sep 17 00:00:00 2001 > From: "Kevin J. Foley" > Date: Tue, 28 Jan 2020 17:51:29 -0500 > Subject: [PATCH] Fix `org-babel-detangle' handling of false positives > > * lisp/ob-tangle.el

[PATCH] Fix `org-babel-detangle' handling of false positives

J. Foley" Date: Tue, 28 Jan 2020 17:51:29 -0500 Subject: [PATCH] Fix `org-babel-detangle' handling of false positives * lisp/ob-tangle.el (org-babel-detangle): Handle false positive matches of `org-link-bracket-re' * testing/examples/babel.el: New file for babel detangle false positive te