Re: [PATCH] Ignore flaky ob-python tests

2022-11-03 Thread Ihor Radchenko
Christian Köstlin writes: > I somehow seem to remember that the async tests were also broken with > python.el (python-mode.el not installed). > at least sometimes? I only recall the underscore test. Note that I debugged the async tests with your rake builds, and I have identified that async

Re: [PATCH] Ignore flaky ob-python tests

2022-11-03 Thread Christian Köstlin
Hi Ihor, I somehow seem to remember that the async tests were also broken with python.el (python-mode.el not installed). at least sometimes? or is this only the underscore test? If it's only the underscore test, I would suggest not installing python-mode for ci and ignoring the really flaky tests

Re: [PATCH] Ignore flaky ob-python tests

2022-11-03 Thread Ihor Radchenko
Christian Köstlin writes: > With my patch the tests are still failing but the testsuite continues > to run and returns > with 0 as status code (one can see the failed test though). FYI, I am using automated scripts to run make test locally on multiple Emacs versions. 0 status code would do no

Re: [PATCH] Ignore flaky ob-python tests

2022-11-02 Thread Ihor Radchenko
Ihor Radchenko writes: > Jack Kamm writes: > >> Christian Köstlin writes: >> >>> I think we know of the async problem, and you reported that as well, >>> so I would expect >>> if someone is able to fix it, he will also move the tests to "sharp" again. >> >> Could you provide some references

Re: [PATCH] Ignore flaky ob-python tests

2022-11-02 Thread Ihor Radchenko
Jack Kamm writes: > Christian Köstlin writes: > >> I think we know of the async problem, and you reported that as well, >> so I would expect >> if someone is able to fix it, he will also move the tests to "sharp" again. > > Could you provide some references about the async problem, either how

Re: [PATCH] Ignore flaky ob-python tests

2022-11-02 Thread Jack Kamm
Christian Köstlin writes: > I think we know of the async problem, and you reported that as well, > so I would expect > if someone is able to fix it, he will also move the tests to "sharp" again. Could you provide some references about the async problem, either how to reproduce it or the

Re: [PATCH] Ignore flaky ob-python tests

2022-11-02 Thread Christian Köstlin
On Wed, Nov 2, 2022 at 7:52 AM Ihor Radchenko wrote: > > Christian Köstlin writes: > > > The new async feature of python seems to be implemented in a way > > that can break with high CPU load. This patch still runs the 3 tests in > > question, but does not fail the complete testsuite if any of

Re: [PATCH] Ignore flaky ob-python tests

2022-11-02 Thread Ihor Radchenko
Christian Köstlin writes: > The new async feature of python seems to be implemented in a way > that can break with high CPU load. This patch still runs the 3 tests in > question, but does not fail the complete testsuite if any of those fail. Thanks for the patch, but I'm afraid that it will

[PATCH] Ignore flaky ob-python tests

2022-11-01 Thread Christian Köstlin
The new async feature of python seems to be implemented in a way that can break with high CPU load. This patch still runs the 3 tests in question, but does not fail the complete testsuite if any of those fail. Kind regards, Christian 0001-testing-lisp-test-ob-python.el-Ignore-flaky-tests.patch