Timothy writes:
> I haven’t gone through the patches you’ve sent, but it looks like you’ve put a
> tremendous amount of effort into this! It’s fantastic to see. I think I can
> speak for the Org community when I say thank you.
I appreciate the kind words. It's my pleasure to collaborate with
Hi André,
I haven’t gone through the patches you’ve sent, but it looks like you’ve put a
tremendous amount of effort into this! It’s fantastic to see. I think I can
speak for the Org community when I say thank you.
André A. Gomes writes:
> Hi Bastien and All,
>
> This is a first attempt
Hi André,
André A. Gomes writes:
> Here's something I wasn't sure about when I worked on it. How should I
> distribute the changes commit-wise? Tom Gillespie, for instance,
> suggested separating documentation and docstring from internals.
Yes, that's what I suggest too.
> I think it's ok
Bastien writes:
> Hi André,
>
> I agree this change is a welcome improvement: thanks a lot for working
> on this patch. I would like to suggest a step by step approach:
>
> 1. Updating occurrences in the documentation: manual, guide,
>docstrings, worg occurences, etc.
>
> 2. Updating Org
Timothy writes:
> Sorry that you haven’t heard anything in a while. I’ve been hoping that
> Bastien
> or Nicolas might have been able to take a look at this and give their
> thoughts,
> but unfortunately judging from their recent activity they both seem to be
> quite
> busy as of late. I
Hi André,
André A. Gomes writes:
> As previously discussed, please find the patch below.
I agree this change is a welcome improvement: thanks a lot for working
on this patch. I would like to suggest a step by step approach:
1. Updating occurrences in the documentation: manual, guide,
Hi André,
Sorry that you haven’t heard anything in a while. I’ve been hoping that Bastien
or Nicolas might have been able to take a look at this and give their thoughts,
but unfortunately judging from their recent activity they both seem to be quite
busy as of late. I dream of the day when Org
Jim Porter writes:
>
> In any case, if Org were to add an informative message about this change,
> `org-capture-upgrade-templates' seems to me a reasonable place to do it since
> it's already doing this for other obsolete types. In fact, looking at the
> commit
> history, that function was
On 8/15/2021 4:17 PM, Tim Cross wrote:
At some point, your transition period will end. If it isn't with the
transition to v9.5, it will be the transition to 9.6. At this point, all
of the issues you point out will still exist. There will still be people
who are running multiple versions, there
Jim Porter writes:
> On 8/14/2021 3:54 PM, Tim Cross wrote:
>> I'm not convinced a transition period will help in this case. At some
>> point, users will need to update their capture templates regardless.
>> Provided this impact is clearly outlined in the NEWS.org file (I think
>> there should
On 8/14/2021 3:54 PM, Tim Cross wrote:
I'm not convinced a transition period will help in this case. At some
point, users will need to update their capture templates regardless.
Provided this impact is clearly outlined in the NEWS.org file (I think
there should be a specific reference to capture
No Wayman writes:
As far as org-capture is concerned, support for transparently
upgrading the
user's templates could easily be added to the
`org-capture-upgrade-templates`
function.
It would just be one more case added to the existing pcase
statement and would
prevent breakage for users.
As far as org-capture is concerned, support for transparently
upgrading the user's templates could easily be added to the
`org-capture-upgrade-templates` function.
It would just be one more case added to the existing pcase
statement and would prevent breakage for users.
this patch looks pretty good to me. My only suggestion is that the need
to update capture templates be made more explicit in the NEWS.org file.
I'm assuming this patch would only be applied to the next release and
not maint branch.
Probably important to try and apply this before the main branch
Maxim Nikulin writes:
> On 05/08/2021 19:12, André A. Gomes wrote:
>> @@ -963,7 +963,7 @@ Store them in the capture property list."
>> (org-capture-put-target-region-and-position)
>> (goto-char position))
>> (_ (error "Cannot find target ID \"%s\"" id
>> -
Hi André,
Thanks for taking a first pass at this. I think that this patch is
difficult to review. Could you break it into two separate patches, one
for documentation (non-code, e.g. docstring and comment) changes and
one for code changes? That way we could more easily see where we may
need to
On 05/08/2021 19:12, André A. Gomes wrote:
@@ -963,7 +963,7 @@ Store them in the capture property list."
(org-capture-put-target-region-and-position)
(goto-char position))
(_ (error "Cannot find target ID \"%s\"" id
- (`(file+headline ,path ,headline)
17 matches
Mail list logo
