Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-09-04 Thread Bastien
Hi Terje, sorry for the late reply. Terje Larsen writes: > Did this look okay? I've had to rebase this once again due to some > conflicts in the ORG-NEWS. Applied, thanks! -- Bastien

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-08-30 Thread Terje Larsen
Did this look okay? I've had to rebase this once again due to some conflicts in the ORG-NEWS. Find the latest patch attached. Best regards Terje On Tue, Jun 9, 2020 at 8:53 AM Terje Larsen wrote: > > Thank you Bastien, > > I didn't get what the updated patch with shorter lines meant, the only

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-06-09 Thread Terje Larsen
Thank you Bastien, I didn't get what the updated patch with shorter lines meant, the only thing I could see difference between that patch and my previous patch was the line breaks using CR LF instead of LF. I generate my patch with git format-patch Here is the updated patch using mapconcat.

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-06-01 Thread Bastien
Hello Terje, > I have now signed the FSF papers. Here is the updated patch on top of > current master. Great, thanks. > Let me know if all looks good or if I need to make further changes or > need to provide something else. It looks good -- here is an updated patch with shorter lines. The

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-05-26 Thread Terje Larsen
Hello Bastien, I have now signed the FSF papers. Here is the updated patch on top of current master. Let me know if all looks good or if I need to make further changes or need to provide something else. Best regards, Terje On Mon, Feb 17, 2020 at 12:29 AM Bastien wrote: > > Hi Terje, > >

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-02-16 Thread Bastien
Hi Terje, Terje Larsen writes: > You are welcome, I have never gotten around to sign the FSF papers as > I thought it was a > bit of a hassle, but with those clear instructions I have now started > the process. Thanks! > I guess I have to wait until the process is done until I can > resubmit?

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-02-16 Thread Terje Larsen
Thank you Bastien, You are welcome, I have never gotten around to sign the FSF papers as I thought it was a bit of a hassle, but with those clear instructions I have now started the process. I guess I have to wait until the process is done until I can resubmit? On Wed, Feb 12, 2020 at 6:31 PM

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2020-02-12 Thread Bastien
Hi Terje, Terje Larsen writes: > I have been missing this feature for a while and noticed it had already > been requested before (2014), See: > https://lists.gnu.org/archive/html/emacs-orgmode/2016-08/msg00105.html > > With this patch you can switch between using jar or plantuml. The idea >

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2019-11-24 Thread Terje Larsen
Nicolas Goaziou writes: Hello and thank you for the feedback, made me learn a few things and make some improvements. I have made the suggested changes (see attachment). >From e3c46993714234c0290f3100683cbec3c0d5f056 Mon Sep 17 00:00:00 2001 From: Terje Larsen Date: Fri, 8 Nov 2019 10:25:49

Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2019-11-24 Thread Nicolas Goaziou
Hello, Terje Larsen writes: > And also see attached within this mail. Thank you. Could you rebase it on top of "next" branch and add an entry in ORG-NEWS, section "Org 9.4" about it? > +(defcustom org-plantuml-exec-mode 'jar > + "Method to use for PlantUML diagram generation. > +`jar'

[PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution

2019-11-08 Thread Terje Larsen
I have been missing this feature for a while and noticed it had already been requested before (2014), See: https://lists.gnu.org/archive/html/emacs-orgmode/2016-08/msg00105.html With this patch you can switch between using jar or plantuml. The idea partly stemmed from plantuml-mode and my