Re: [PATCH] ob-sql: Respect database param when using dbconnection

2022-11-03 Thread Bastien Guerry
Ihor Radchenko writes: > Bastien, could you please add Daniel as the maintainer of > lisp/ob-sql.el? Done in bd468136d. Thanks Daniel! -- Bastien

Re: [PATCH] ob-sql: Respect database param when using dbconnection

2022-11-03 Thread Ihor Radchenko
Daniel Kraus writes: >> P.S. ob-sql currently have no maintainer. Do you want to volunteer? > > Hmm, ob-sql is the the babel module I use most often. > I don't think I'll have enough time to make bigger changes etc, > but from what I know that's not necessary or expected. > I'm certainly willing

Re: [PATCH] ob-sql: Respect database param when using dbconnection

2022-11-02 Thread Daniel Kraus
Ihor Radchenko writes: >> Otherwise, the patch itself is not much and I use it daily. > > Thanks! > Applied onto main with minor amendments to the commit message (I added > "." at the end of the sentences). > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fbbc8b55cf3a39c85f8576

Re: [PATCH] ob-sql: Respect database param when using dbconnection

2022-10-31 Thread Ihor Radchenko
Daniel Kraus writes: > Hi, > > sorry for replying to a 2 year old thread. > Attached is a new patch with the change from Kyle and > I also added a news entry. > Not sure if the text for the news entry is any good, > or if there should be an example etc. > Feedback welcome. > > Otherwise, the patc

Re: [PATCH] ob-sql: Respect database param when using dbconnection

2022-10-31 Thread Daniel Kraus
Hi, sorry for replying to a 2 year old thread. Attached is a new patch with the change from Kyle and I also added a news entry. Not sure if the text for the news entry is any good, or if there should be an example etc. Feedback welcome. Otherwise, the patch itself is not much and I use it daily.

Re: [PATCH] ob-sql: Respect database param when using dbconnection

2020-06-01 Thread Stefano Rodighiero
On Mon, Jun 1, 2020 at 4:16 AM Kyle Meyer wrote: Daniel Kraus writes: > > > I use ob-sql with the :dbconnection param so I don't have my username > and password in my org file. > > But often I don't want to use the default database from the dbconnection > alist but > > rather specify it explicitl

Re: [PATCH] ob-sql: Respect database param when using dbconnection

2020-05-31 Thread Kyle Meyer
d is a patch that fixes this. Thanks for the patch. > Subject: [PATCH] ob-sql: Respect database param when using dbconnection > > --- > lisp/ob-sql.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Would you mind formatting your commit message as described at &l

[PATCH] ob-sql: Respect database param when using dbconnection

2020-05-28 Thread Daniel Kraus
iel >From a8dccff104d7426e2f353b1005e0bdcc51de6e99 Mon Sep 17 00:00:00 2001 From: Daniel Kraus Date: Tue, 26 May 2020 16:07:34 +0200 Subject: [PATCH] ob-sql: Respect database param when using dbconnection --- lisp/ob-sql.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/l