Ihor Radchenko writes:
> I believe that it is useful for the users to see such issues instead of,
> say, failing silently on malformed bibliographies.
Applied onto main via 5b45ad083.
Best,
Ihor
John Kitchin writes:
> I would see if you can cache the result and not do it more than needed; it
> can add a performance issue on large files.
The results of parsing are already cached. See 7ddc5b57c.
With this patch, I'd expect 2x performance degradation on (1) first time
Org opens the biblio
I would see if you can cache the result and not do it more than needed; it
can add a performance issue on large files.
John
---
Professor John Kitchin (he/him/his)
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
On Wed, Apr 20, 2022 at 8:28 AM Ihor Radchenko wrote:
>
> There is an edge case triggering infinite loop in oc-basic.
>
> It is caused by bibtex-map-entries (used in
> org-cite-basic--parse-bibtex) when ran on a malformed bibtex buffer [1].
>
> The proposed patch validates the bibtex buffer before
There is an edge case triggering infinite loop in oc-basic.
It is caused by bibtex-map-entries (used in
org-cite-basic--parse-bibtex) when ran on a malformed bibtex buffer [1].
The proposed patch validates the bibtex buffer before processing and
throws an error if issues are found. `bibtex-valid