Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread Bastien Guerry
Hi András, András Simonyi writes: > I've attached a patch with the pcase pattern refactored following > Nicolas's example -- hopefully this solves the problem. Applied - as you guess, I'm in "optimistic push" mode. Hopefully this will help have someone review this if needed. Thanks, and thank

Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread Max Nikulin
On 28/09/2021 23:39, András Simonyi wrote: I've attached a patch with the pcase pattern refactored following Nicolas's example -- hopefully this solves the problem. I do not see the issue any more. No pause during compilation, reasonable file size -rw-rw-r-- 1 ubuntu ubuntu 24992 Sep 28 16:

Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread András Simonyi
Dear All, I've attached a patch with the pcase pattern refactored following Nicolas's example -- hopefully this solves the problem. best wishes, András On Tue, 28 Sept 2021 at 17:16, András Simonyi wrote: > > Thanks, I'll try to put together a patch fixing the problem and send it > shortly. >

Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread András Simonyi
Thanks, I'll try to put together a patch fixing the problem and send it shortly. best wishes, András On Tue, 28 Sept 2021 at 17:03, Max Nikulin wrote: > > On 28/09/2021 21:40, Bastien wrote: > > András Simonyi writes: > > > >> the attached patch adds support for the text (textual) and year > >> (

Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread Max Nikulin
On 28/09/2021 21:40, Bastien wrote: András Simonyi writes: the attached patch adds support for the text (textual) and year (year-only) citation styles in the CSL org-cite processor. Applied, thank you very much! This patch has a problem similar to ones earlier fixed by Nicolas: https://org

Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread Nicolas Goaziou
Hello, Bastien writes: > Dear András, > > András Simonyi writes: > >> the attached patch adds support for the text (textual) and year >> (year-only) citation styles in the CSL org-cite processor. > > Applied, thank you very much! The function `org-cite-csl--create-structure-params' probably ne

Re: [PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread Bastien
Dear András, András Simonyi writes: > the attached patch adds support for the text (textual) and year > (year-only) citation styles in the CSL org-cite processor. Applied, thank you very much! -- Bastien

[PATCH] oc-csl: Add support for the text and year citation styles

2021-09-28 Thread András Simonyi
:13 +0200 Subject: [PATCH] oc-csl: Add support for the text and year citation styles * lisp/oc-csl.el (org-cite-csl--create-structure-params): Introduce this new function to map the extended list of supported citation styles and variants to the corresponding citeproc-el citation structure creation