Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-18 Thread Kyle Meyer
Joseph Mingrone writes: > On Fri, 2020-07-17 at 01:41, Kyle Meyer wrote: [...] >> I'll plan to apply it in a day or two unless there are objections. > > So far so good here. It fixes the errors running 28.0.50 (85eaa83 from > 2020-07-16) and the latest org-mode-contrib. Thanks for testing. Pus

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Kyle Meyer
Basil L. Contovounesios writes: >> @@ -161,11 +161,17 @@ (defun org-eldoc-documentation-function () >> (defun org-eldoc-load () >>"Set up org-eldoc documentation function." >>(interactive) >> - (if (boundp 'eldoc-documentation-functions) >> - (add-hook 'eldoc-documentation-functions

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Eric Abrahamsen
"Basil L. Contovounesios" writes: > Kyle Meyer writes: > >> All right, thanks. Here's that in patch form. I briefly tested with >> Emacs 26, 27, and 28, and things seemed to work fine (though I'm not an >> org-eldoc user). > > I'm not either, but it seems to get pulled in automatically when >

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Joseph Mingrone
On Fri, 2020-07-17 at 01:41, Kyle Meyer wrote: > All right, thanks. Here's that in patch form. I briefly tested with > Emacs 26, 27, and 28, and things seemed to work fine (though I'm not an > org-eldoc user). > I'll plan to apply it in a day or two unless there are objections. So far so good

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Basil L. Contovounesios
Kyle Meyer writes: > All right, thanks. Here's that in patch form. I briefly tested with > Emacs 26, 27, and 28, and things seemed to work fine (though I'm not an > org-eldoc user). I'm not either, but it seems to get pulled in automatically when org-plus-contrib is installed - that's how I no

[PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-16 Thread Kyle Meyer
missed that the default documentation > strategy also allows the function to ignore the callback & just return a > docstring directly. All right, thanks. Here's that in patch form. I briefly tested with Emacs 26, 27, and 28, and things seemed to work fine (though I'm n