Re: [PATCH] org-lint: Fix invocation with C-u prefix argument
On 6/8/22 09:30, Ihor Radchenko wrote: Nick Dokos writes: LGTM! Is there any reason you did not push the patch upstream yourself? ISTR I used to have push access to the repo, but in some repo move I think I've lost it and I've never arranged to get it back. At least, I *think* that was the case - but perhaps given my general state of discombobulation, you don't want me to be committing things to the repo in any case :-) Better to have some eyes on patches first... Ok. AFAIK, after we moved the repo to savannah, you may need to create an account at https://savannah.gnu.org/ and request access from Bastien. Note that you don't have to commit without having extra pairs of eyes on the patches. You can post the patch here, get comments, and then apply the patch yourself if everything is ok. (Yes, I am lazy to apply patches from others if I don't have to). Applied onto main via 9fd5349d0. I did not apply onto bugfix because Bastien asked not to apply non-critical fixed until Emacs 28.2 is out. Best, Ihor Thank you! I will try to get commit rights again before posting another patch. I appreciate your patience and help (and the enormous contribution you have made to Org mode too!) -- Nick
Re: [PATCH] org-lint: Fix invocation with C-u prefix argument
Nick Dokos writes: >> LGTM! Is there any reason you did not push the patch upstream yourself? >> > > ISTR I used to have push access to the repo, but in some repo move I > think I've lost it and I've never arranged to get it back. At least, I > *think* that was the case - but perhaps given my general state of > discombobulation, you don't want me to be committing things to the > repo in any case :-) Better to have some eyes on patches first... Ok. AFAIK, after we moved the repo to savannah, you may need to create an account at https://savannah.gnu.org/ and request access from Bastien. Note that you don't have to commit without having extra pairs of eyes on the patches. You can post the patch here, get comments, and then apply the patch yourself if everything is ok. (Yes, I am lazy to apply patches from others if I don't have to). Applied onto main via 9fd5349d0. I did not apply onto bugfix because Bastien asked not to apply non-critical fixed until Emacs 28.2 is out. Best, Ihor
Re: [PATCH] org-lint: Fix invocation with C-u prefix argument
Ihor Radchenko writes: > Nick Dokos writes: > >> `C-u M-x org-lint' was failing to run any checkers, no matter what >> category was chosen, because the calculation of the list of checkers >> always returned `nil'. > > LGTM! Is there any reason you did not push the patch upstream yourself? > ISTR I used to have push access to the repo, but in some repo move I think I've lost it and I've never arranged to get it back. At least, I *think* that was the case - but perhaps given my general state of discombobulation, you don't want me to be committing things to the repo in any case :-) Better to have some eyes on patches first... -- Nick
Re: [PATCH] org-lint: Fix invocation with C-u prefix argument
Nick Dokos writes: > `C-u M-x org-lint' was failing to run any checkers, no matter what > category was chosen, because the calculation of the list of checkers > always returned `nil'. LGTM! Is there any reason you did not push the patch upstream yourself? Best, Ihor
[PATCH] org-lint: Fix invocation with C-u prefix argument
`C-u M-x org-lint' was failing to run any checkers, no matter what category was chosen, because the calculation of the list of checkers always returned `nil'. >From b55162adf1250980ad0f42423832aa1aa1045d30 Mon Sep 17 00:00:00 2001 From: Nick Dokos Date: Wed, 1 Jun 2022 12:28:23 -0400 Subject: [PATCH] org-lint: Fix invocation with C-u prefix argument * lisp/org-lint.el (org-lint): Fix the order of the arguments in the `assoc-string' call when calculating the list of checkers to invoke. `C-u M-x org-lint' was failing to run any checkers, no matter what category of checkers was chosen, because the calculation of the list of checkers always returned `nil'. --- lisp/org-lint.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-lint.el b/lisp/org-lint.el index cce6fddbd..62a245330 100644 --- a/lisp/org-lint.el +++ b/lisp/org-lint.el @@ -321,7 +321,7 @@ ARG can also be a list of checker names, as symbols, to run." nil t))) (cl-remove-if-not (lambda (c) - (assoc-string (org-lint-checker-categories c) category)) + (assoc-string category (org-lint-checker-categories c))) org-lint--checkers))) (`(16) (list -- 2.34.1 -- Nick
