Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-10-25 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: > Hi, Ihor, > > Sorry for the delay with fixes, took some time before I got time to finish > this. Thanks for your review and looking forward for the next iteration. See > new version in the attachment. Comments are inline. Thanks! Applied onto main with minor amen

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-10-23 Thread Mikhail Skorzhisnkii
Hi, Ihor, Sorry for the delay with fixes, took some time before I got time to finish this. Thanks for your review and looking forward for the next iteration. See new version in the attachment. Comments are inline. Ihor Radchenko writes: > Mikhail Skorzhisnkii writes: > >> Thank you for sugge

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-09 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: > Thank you for suggestion, I seen an announcement about this function, but > somehow forgot about it. > > Sending next version of these patches. Changes from the next version: Thanks! > Subject: [PATCH 3/3] org-refile.el: show refile targets with a title > > * lis

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-08 Thread Mikhail Skorzhisnkii
Thank you for suggestion, I seen an announcement about this function, but somehow forgot about it. Sending next version of these patches. Changes from the next version: • Removed my version of title gathering into one existing in org-clock.el • Split org-clock-get-file-title renaming into separa

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-07 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: >> Also, what will happen in a file like >> >> #+TITLE: Begin title >> #+TITLE: .. end title >> >> ? > > Hm, never did this myself. Now concatenate the list of property values. I have > tested it and space as a separator looks good, if the intention of several > title

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-07 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: > Resubmitting this patch with better commit message. Thanks! Applied onto main with amendments. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eb5ef0ae1424a725f933ef3929e5396a2ab727ab I have changed the variable names to end with more conventional

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-05 Thread Mikhail Skorzhisnkii
Resubmitting this patch with better commit message. Mikhail Skorzhisnkii writes: > I have signed FSF papers. Attaching a rebased patch with additional changes to > ORG-NEWS > > Ihor Radchenko writes: > >> “Mikhail Skorzhinskiy” writes: >> >>> Thanks for review, Ihor. I have sent a copyright as

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-05 Thread Mikhail Skorzhisnkii
Thanks for your comment, Ihor. I have addressed your comments, see some comments inline. Attaching new version of the patch. Ihor Radchenko writes: > Mikhail Skorzhisnkii writes: > >> I have signed FSF papers. Attaching a rebased patch with additional changes >> to >> ORG-NEWS > > Thanks! > >

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-05 Thread Mikhail Skorzhisnkii
Ah, sorry — probably forgot to attach it, yes. See the second patch here in the attachment. Ihor Radchenko writes: > Mikhail Skorzhisnkii writes: > >> Subject: [PATCH 1/2] org-agenda.el: customize outline path in echo area > > I do not see the second patch. Did you forget to attach it? >From 6

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-09-01 Thread Bastien
Hi Ihor, Ihor Radchenko writes: > Mikhail Skorzhisnkii writes: > >> I have signed FSF papers. Attaching a rebased patch with additional changes >> to >> ORG-NEWS > > Bastien, could you kindly check the FSF records? Yes, I confirm Mikhail is on the FSF records. Mikhail, thanks for contributin

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-08-31 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: > I have signed FSF papers. Attaching a rebased patch with additional changes to > ORG-NEWS Bastien, could you kindly check the FSF records? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-08-31 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: > Subject: [PATCH 1/2] org-agenda.el: customize outline path in echo area I do not see the second patch. Did you forget to attach it? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://libe

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-08-31 Thread Ihor Radchenko
Mikhail Skorzhisnkii writes: > I have signed FSF papers. Attaching a rebased patch with additional changes to > ORG-NEWS Thanks! > Subject: [PATCH 1/2] org-agenda.el: customize outline path in echo area > > * lisp/org-agenda.el (org-agenda-show-outline-path): add an option to > show document ti

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-08-30 Thread Mikhail Skorzhisnkii
I have signed FSF papers. Attaching a rebased patch with additional changes to ORG-NEWS Ihor Radchenko writes: > “Mikhail Skorzhinskiy” writes: > >> Thanks for review, Ihor. I have sent a copyright assignment request. Will >> resubmit the patches as soon as I complete the process. > > Thanks! N

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-07-31 Thread Ihor Radchenko
"Mikhail Skorzhinskiy" writes: > Thanks for review, Ihor. I have sent a copyright assignment request. Will > resubmit the patches as soon as I complete the process. Thanks! Note that FSF clerk should reply within 5 working days. If not, please let us know. Best, Ihor

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-07-31 Thread Mikhail Skorzhinskiy
Thanks for review, Ihor. I have sent a copyright assignment request. Will resubmit the patches as soon as I complete the process. -- Mikhail Skorzhinskii mskorzhins...@eml.cc On Sun, Jul 31, 2022, at 09:16, Ihor Radchenko wrote: > Mikhail Skorzhinskii writes: > >> Thank you for the reviewi

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2022-07-31 Thread Ihor Radchenko
Mikhail Skorzhinskii writes: > Thank you for the reviewing my suggestions. I've fixed issues you've > listed. I've attached new patch to this email. > > Let me know what you think. Sorry again for the late reply. The patch looks good, though you may also need to document the new customization in

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2021-12-28 Thread Mikhail Skorzhinskii
Hi Nicolas, Thank you for the reviewing my suggestions. I've fixed issues you've listed. I've attached new patch to this email. Let me know what you think. Thanks, Mikhail On Sun, 2021-12-26 at 22:26 +0100, Nicolas Goaziou wrote: > Hello, > > Thanks. Some comments follow. > > Mikhail Skorzhin

Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix

2021-12-26 Thread Nicolas Goaziou
Hello, Thanks. Some comments follow. Mikhail Skorzhinskii writes: > * lisp/ox-icalendar.el (org-icalendar-scheduled-summary-prepend): > configurable prefix for the scheduled headlines "New variable" is enough. > * lisp/ox-icalendar.el (org-icalendar-deadline-summary-prepend): > configurable p

[PATCH] ox-icalendar.el: customizable vevent summary prefix

2021-12-25 Thread Mikhail Skorzhinskii
* lisp/ox-icalendar.el (org-icalendar-scheduled-summary-prepend): configurable prefix for the scheduled headlines * lisp/ox-icalendar.el (org-icalendar-deadline-summary-prepend): configurable prefix for the headlines with a deadline * lisp/ox-icalendar.el (org-icalendar-entry): use a configurable