"Christopher M. Miles" writes:
>> Sure. Can you please send the final version of the patch and the working
>> tests?
>
> I separated code patch and test into two patches. You can apply selectively.
Sorry, I was not very clear.
I meant to remove that patch that fails due to noninteractive and
"Christopher M. Miles" writes:
> Whether can this patch be merged at first, put the test in future to
> finish? In recent days, I still have not figured out this image overlays
> test.
Sure. Can you please send the final version of the patch and the working
tests?
--
Ihor Radchenko //
Ihor Radchenko writes:
> "Christopher M. Miles" writes:
>
>> Whether can this patch be merged at first, put the test in future to
>> finish? In recent days, I still have not figured out this image overlays
>> test.
>
> Sure. Can you please send the final version of the patch and the working
>
Whether can this patch be merged at first, put the test in future to
finish? In recent days, I still have not figured out this image overlays
test.
"Christopher M. Miles" writes:
> [[PGP Signed Part:Undecided]]
>
> Ihor Radchenko writes:
>
>> "Christopher M. Miles" writes:
>>
I think
Ihor Radchenko writes:
> "Christopher M. Miles" writes:
>
>>> I think that the best we can do in this situation is mocking
>>> `create-image' in batch mode to return non-nil using `cl-letf'.
>>
>> I checked the `create-image' in image.el source code, don't know how to
>> mocking this. I have
"Christopher M. Miles" writes:
>> I think that the best we can do in this situation is mocking
>> `create-image' in batch mode to return non-nil using `cl-letf'.
>
> I checked the `create-image' in image.el source code, don't know how to
> mocking this. I have no experience and idea about this.
Ihor Radchenko writes:
> "Christopher M. Miles" writes:
>
>>> However, upon testing your patch, tests are still failing on my side.
>>> Can you please investigate?
>>
>> But If I use [M-x ert] to run the test
>> "test-org-fold/org-fold-display-inline-images" is passed.
>> Here is the steps:
"Christopher M. Miles" writes:
>> However, upon testing your patch, tests are still failing on my side.
>> Can you please investigate?
>
> But If I use [M-x ert] to run the test
> "test-org-fold/org-fold-display-inline-images" is passed.
> Here is the steps:
> 1. [M-x load-file RET
Ihor Radchenko writes:
> "Christopher M. Miles" writes:
>
>> I think the patch is finished. Please review, Ihor. Thanks for helping.
>
> Thanks for the update!
> I have cleaned the manual and ORG-NEWS wordings.
>
> Upon reading the exported version of the manual, I realized that the
> part in
"Christopher M. Miles" writes:
> I think the patch is finished. Please review, Ihor. Thanks for helping.
Thanks for the update!
I have cleaned the manual and ORG-NEWS wordings.
Upon reading the exported version of the manual, I realized that the
part in 2.2.1 Global and local cycling section
Finally finished and passed the test. Here I attached the new patch.
From c36122f818289cbd26026ae75ce480b03e03f61a Mon Sep 17 00:00:00 2001
From: stardiviner
Date: Wed, 28 Sep 2022 20:46:52 +0800
Subject: [PATCH] org.el: Support auto display inline images when cycling
* lisp/org.el
11 matches
Mail list logo
