Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Sławomir Grochowski writes: > I thought it would get lost in the many thousands of other TODOs you have > on your plate. > Thank you. Merging contributed patches is high priority. I either have them scheduled in agenda or they are the next thing to do upon clearing the scheduled tasks. The

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

I thought it would get lost in the many thousands of other TODOs you have on your plate. Thank you. But to my another surprise you have fixed the bug that was killing me everyday 'org-insert-heading: Fix when folded text is kept right at the new heading'. Thank you very much. Regards, Sławomir

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Ihor Radchenko writes: > I suspect that it is something with overlay boundaries. AFAIR, some org > subtree motion functions use `insert-before-markers', which may be > tricky when we insert right at the beginning/end of an overlay. It was totally unrelated bug on Org side. Applied, onto main,

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Sławomir Grochowski writes: > As I understand it something with overlay. Which try to jump before the > first line of the buffer. Most likely. > And that makes some kind of overflow? > I will try to simplify the example and create a simple overlay without > org-columns. > If anyone has some

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Thank you Ihor for finding such an important bug. I've tried to pinpoint it. I think it happens only when: first heading (row) is the first line of the buffer. To reproduce it: * a * b * c C-u C-c C-x C-c => runs `org-columns' with global argument. Using a keyboard. Press M-, M-, M-. Heading 'a'

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Sławomir Grochowski writes: > Thank you Ihor for the code review. > Now please help me find everything that can be improved in this patch. I just tried to use the patch using the following test case: 1. Create a new Org file containing * A * B * C ** C1 * D 2. C-u C-c C-x C-c 3. M-< 4.

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Thank you Ihor for the code review. Now please help me find everything that can be improved in this patch. > The patch looks good in general, but you need to add proper commit > message. See https://orgmode.org/worg/ > >

Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Sławomir Grochowski writes: > Recently I often use 'column view' feature. > To my suprise in 'column view' user can't move rows up & down. > So I wrote a little code snippet to be able to do it, and I'm sharing it with > you. > > Questions: > 1. Why user can't move rows up & down in 'column

[RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down

Dear All, This is my first proposal & code submit. I will be very gratefull for you comments & feedback what can be done better. Recently I often use 'column view' feature. To my suprise in 'column view' user can't move rows up & down. So I wrote a little code snippet to be able to do it,