Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-09 Thread Nicolas Goaziou
Hello, "Bruce D'Arcus" writes: > Given how common existing functions are that take a list of keys, WDYT > about adding something like a `org-cite-get-references-keys` helper > function, to parallel `org-cite-get-references`? > > So in this case one could do: > > (bibtex-completion-open-any

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-09 Thread Bruce D'Arcus
On Tue, Jun 8, 2021 at 4:25 PM Nicolas Goaziou wrote: > > Hello, > > "Bruce D'Arcus" writes: > > > On Tue, Jun 8, 2021 at 7:36 AM Bruce D'Arcus wrote: > > > >> (org-cite-register-processor 'bibtex > >> :follow #'bibtex-completion-open-any) > > > > Actually, looking at the docstrings, I

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Matt Price
On Tue., Jun. 8, 2021, 5:29 a.m. Nicolas Goaziou, wrote: > Hello, > > Matt Price writes: > > > IIUC, the current architecture assigns responsibility for both *citation > > export* and *in-buffer actions* to a processor shosen by the user (right > > now, oc-cite, oc-natbib, or oc-csl). > >

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Bruce D'Arcus
On Tue, Jun 8, 2021 at 4:25 PM Nicolas Goaziou wrote: > > Still, I'm confused why the basic font-locking doesn't work in this case. > > I know it is not terribly useful but… it works here. For example, if no > bibliography is defined, all cite keys are red (error face). Actually that is useful;

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Nicolas Goaziou
Hello, "Bruce D'Arcus" writes: > On Tue, Jun 8, 2021 at 7:36 AM Bruce D'Arcus wrote: > >> (org-cite-register-processor 'bibtex >> :follow #'bibtex-completion-open-any) > > Actually, looking at the docstrings, I don't think this will work as > is, as the follow processor "accepts two

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Bruce D'Arcus
On Tue, Jun 8, 2021 at 7:36 AM Bruce D'Arcus wrote: > (org-cite-register-processor 'bibtex > :follow #'bibtex-completion-open-any) Actually, looking at the docstrings, I don't think this will work as is, as the follow processor "accepts two arguments, the citation or citation reference

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Bruce D'Arcus
On Tue, Jun 8, 2021 at 5:33 AM Nicolas Goaziou wrote: > > Hello, > > "Bruce D'Arcus" writes: > > > So would it be so simple as doing something like this, to use the > > bibtex-completion-open function instead? > > > > (org-cite-register-processor 'basic > > :follow #'bibtex-completion-open) >

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Nicolas Goaziou
Hello, Matt Price writes: > IIUC, the current architecture assigns responsibility for both *citation > export* and *in-buffer actions* to a processor shosen by the user (right > now, oc-cite, oc-natbib, or oc-csl). That's incorrect. The current architecture provides three entry points:

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-08 Thread Nicolas Goaziou
Hello, "Bruce D'Arcus" writes: > So would it be so simple as doing something like this, to use the > bibtex-completion-open function instead? > > (org-cite-register-processor 'basic > :follow #'bibtex-completion-open) > > As in, that just tells what function to use for at-point? > > If yes,

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-07 Thread Matt Price
Ni Nicolas and Bruce, I'm having trouble keeping up with these emails, let alone testing all these new features! But this most recent response of yours, Nicolas, makes me wonder if it's worth raising a concern. On Mon, Jun 7, 2021 at 5:15 PM Nicolas Goaziou wrote: > Hello, > > "Bruce D'Arcus"

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-07 Thread Bruce D'Arcus
On Mon, Jun 7, 2021 at 5:27 PM Bruce D'Arcus wrote: > So would it be so simple as doing something like this, to use the > bibtex-completion-open function instead? > > (org-cite-register-processor 'basic > :follow #'bibtex-completion-open) > > As in, that just tells what function to use for

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-07 Thread Bruce D'Arcus
On Mon, Jun 7, 2021 at 5:14 PM Nicolas Goaziou wrote: > ... would be great do something > > like: > > > > (setq org-cite-basic-open bibtex-completion-open-pdf) > > If you want to use a different "follow" capability, you need to provide > a different processor instead of configuring this one.

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-07 Thread Nicolas Goaziou
Hello, "Bruce D'Arcus" writes: > Similar to my idea to have a configurable capf, could that function be > configurable? > > A couple of people noted, for example, that the preferred choice would > be that the actual document be opened. I actually got a PR for exactly > this default behavior

Re: [org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-07 Thread Bruce D'Arcus
On Mon, Jun 7, 2021 at 12:53 PM Bruce D'Arcus wrote: > ... would be great do something > like: > > (setq org-cite-basic-open bibtex-completion-open-pdf) I guess that raises a question for me about what code goes where. Maybe instead have it set in oc.el? (setq org-cite-open

[org-cite, oc-basic] configurable open-at-point, font-locking when json?

2021-06-07 Thread Bruce D'Arcus
I'm kind of losing track of details, but two things: First, the current oc-basic has a "follow" function that if point is over a citation-reference (key), and one does "M-x org-open-at-point", the bibtex entry is opened. Very cool! Similar to my idea to have a configurable capf, could that