Ihor Radchenko writes:
> LGTM. Thanks!
Thanks, I've applied now:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=da2b61b09e1eff957e6b2560a2f9c8509de6beac
Jack Kamm writes:
> I've updated the patch so that it applies cleanly onto the latest main,
> and also fixed a few issues including the ones Ihor pointed out above.
>
> Let me know if there are any issues -- otherwise I'll apply it to main
> in the near future.
LGTM. Thanks!
--
Ihor Radchenko
Ihor Radchenko writes:
> This does not look right. Did you try to export anything with this patch
> applied? You are passing multiple string arguments to `format'.
>
> Finally, I think that we can document the new keyword in the manual.
I've updated the patch so that it applies cleanly onto
Detlef Steuer writes:
> Next try.
Thanks!
> +Default for ~org-icalendar-ttl~ is nil. In that case the setting will
> +not be used in the exported ICS file.
> +
> +The option may also be set using the ICAL-TTL keyword.
Should quote the Org syntax keyword according to our documentation
>
> May you please also take into account the amendments I made in my
> patch I attached earlier? For example, you still appear to use
> time-to-live and "time to life" inconsistently herein.
>
Oh, sorry, something went terribly wrong on my end.
Next try.
Thx for your patience!
Detlef
Detlef Steuer writes:
>> To achieve this you just need to update the export option settings:
>>
>> (:icalendar-ttl nil nil org-icalendar-ttl)
>>
>> adding a file keyword to be used.
>> See `org-export-options-alist' docstring.
>>
>
> Hi Ihor,
>
> I hope I understood your advice and the
Am Tue, 17 Jan 2023 10:30:07 +
schrieb Ihor Radchenko :
> Detlef Steuer writes:
>
> >> The patch only allows to the TTL globally for all the calendars.
> >> However, it would make sense to specify TTL on per-file basis.
> >> WDYT?
> >
> > Hmm. Surely it would be useful to have the option
Detlef Steuer writes:
>> The patch only allows to the TTL globally for all the calendars.
>> However, it would make sense to specify TTL on per-file basis. WDYT?
>>
>
> Hmm. Surely it would be useful to have the option to use different TTL
> settings for different calendar exports, yes.
>
> The
Am Tue, 17 Jan 2023 09:43:18 +
schrieb Ihor Radchenko :
> Detlef Steuer writes:
>
> > I tried to follow your advice to improve the patch accordingly.
> > New version attached.
>
> I have amended your patch fixing some of the spelling issues and
> indentation. See the attached. Note that
Detlef Steuer writes:
> I tried to follow your advice to improve the patch accordingly.
> New version attached.
I have amended your patch fixing some of the spelling issues and
indentation. See the attached. Note that I used "time to live"
consistently instead of "time to life". The former is
Hi Ihor!
I tried to follow your advice to improve the patch accordingly.
New version attached.
Detlef
Am Sat, 14 Jan 2023 10:26:17 +
schrieb Ihor Radchenko :
> Detlef Steuer writes:
>
> > I now finally followed your advice for that patch.
> >
> > Attached a diff against a clean git
Hi,
Ihor Radchenko writes:
>> In the meantime I have the paperwork done and have "it" :-)
>
> Bastien, could you please check FSF records?
Yes, I confirm Detlef is registered in the FSF records.
--
Bastien
[Adding Org ML back to CC; please use "Reply All" when replying in ML threads]
Detlef Steuer writes:
>> The patch is on the edge, probably still acceptable without copyright
>> assignment. If you have it, it would be much better though.
>>
>
> In the meantime I have the paperwork done and have
Detlef Steuer writes:
>> I think, it is better to wait for comments from an ox-icalendar user.
>
> Sure.
Sorry for the late reply.
I am not a user, but will the patch looks reasonable in general.
>> I am afraid, you will be tired trying to convince me that TTL should
>> be overridden for all
essage: 9
> Date: Mon, 3 Jan 2022 08:41:41 +0100
> From: Detlef Steuer
> To: emacs-orgmode@gnu.org
> Subject: Re: [patch] improved: add TTL as defcustom to ox-icalendar
> Message-ID: <20220103084141.72d2f...@hsu-hh.de>
> Content-Type: text/plain; charset="us-ascii"
Am Mon, 3 Jan 2022 18:23:43 +0700
schrieb Max Nikulin :
> On 03/01/2022 14:41, Detlef Steuer wrote:
> >
> > The patch in principle is unrelated to nextcloud. That's just my
> > use case. The addiditional TTL setting gives a hint to clients
> > when to reload an imported ics file that was
On 03/01/2022 14:41, Detlef Steuer wrote:
The patch in principle is unrelated to nextcloud. That's just my
use case. The addiditional TTL setting gives a hint to clients
when to reload an imported ics file that was exported from org.
I think, it is better to wait for comments from an
Thank you for the hints.
Attached a diff -u version.
The patch in principle is unrelated to nextcloud. That's just my
use case. The addiditional TTL setting gives a hint to clients
when to reload an imported ics file that was exported from org.
Is there any document how to setup an org-mode
On 02/01/2022 20:28, Detlef Steuer wrote:
This is my first try ever to contribute anything in elisp.
Thanks for the patch. It is tracked on https://updates.orgmode.org/
It is easier to review and to apply a patch when it it is prepared in
context format ("-u" option of diff). Several
Improved patch since org-icalendar-template needed to use
the new variable, too.
And now based on 9.5.2 from elpa.
Detlef
Am Thu, 30 Dec 2021 22:59:19 +0100
schrieb Detlef Steuer :
> This is my first try ever to contribute anything in elisp.
>
> The nextcloud calendar app supports the
20 matches
Mail list logo
