Re: [patch] priorities range reversed

2021-09-29 Thread Bastien Guerry
Hi Joe, Bastien writes: > See the docstring of `org-priority-highest': I'm discarding this patch right now - feel free to submit a bug report if there is something I missed. Thanks, -- Bastien

Re: [patch] priorities range reversed

2021-09-26 Thread Bastien
Hi Joe, Joe Corneli via "General discussions about Org-mode." writes: > In the case of numeric priorities [#1] [#9] and so on, there is a test > that is reversed in org.el. See the docstring of `org-priority-highest': The highest priority of TODO items. A character like ?A, ?B, etc.,

Re: [patch] priorities range reversed

2021-08-31 Thread Timothy
Hi Joe, Thanks for looking into this and figuring out a patch. I’ve just taken a peek at your patches, and I have two minor comments: ⁃ Why use saved-position instead of save-excursion ⁃ I’m think ascii versions of ② et. al would be preferable Also, I notice that your patches are just diffs and

Re: [patch] priorities range reversed

2021-08-09 Thread General discussions about Org-mode.
Actually, there some bigger problems with the function as well... — It didn’t update the priority cookie properly when one had been set before * [#1] Exercise: update to [#2] — After fixing that, I noticed that the included save-excursion doesn’t work

[patch] priorities range reversed

2021-08-09 Thread General discussions about Org-mode.
In the case of numeric priorities [#1] [#9] and so on, there is a test that is reversed in org.el. This appears twice with a slight variation. ;; Are we are less than the highest or greater than the lowest? (or (< (upcase new) org-priority-highest) (> (upcase new) org-priority-lowest)) The