Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
On 26/10/2021 00:33, Bastien wrote: Ihor Radchenko writes: I am thinking to revert the patch and reopen (BTW, how to do it in Woof!?) this bug report for now. Sure, please go ahead, thanks. PS: I'm not sure how to do this with Woof! but I'm working on the next version of Woof! where this will be possible. Would not it be enough to just add X-Woof-Bug header to the message? Maybe even with "(Reopened)" suffix to the title to warn other people that it is not a forgotten bug, even if they remember that some patch was committed. It is a wild guess, I did not looked into the "Woof!" code. I just assume that logic inside is not overcomplicated.
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
> Actually, when I told my daughter I was programming "Woof!" as a tool > to ensure that important emails where receiving enough attention from > the community, she suggested I should program something for the "poor > unimportant emails" out there... of course she'd call it "Mew!" > > And I'm seriously considering this: something like an auto-bumper for > bug reports and help requests that didn't get any anwer... :)
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Bastien, > PS: I'm not sure how to do this with Woof! but I'm working on the next > version of Woof! where this will be possible. i hope you will call the next version: Woof, woof! :)
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Greg Minshall writes: > i hope you will call the next version: Woof, woof! Ahah! Actually, when I told my daughter I was programming "Woof!" as a tool to ensure that important emails where receiving enough attention from the community, she suggested I should program something for the "poor unimportant emails" out there... of course she'd call it "Mew!" And I'm seriously considering this: something like an auto-bumper for bug reports and help requests that didn't get any anwer... :) -- Bastien
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Hi Ihor, Ihor Radchenko writes: > I am thinking to revert the patch and reopen (BTW, how to do it in > Woof!?) this bug report for now. Sure, please go ahead, thanks. PS: I'm not sure how to do this with Woof! but I'm working on the next version of Woof! where this will be possible. -- Bastien
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Bastien writes: > Thanks! > > Ihor Radchenko writes: > >> Should I also merge main with bugfix every time? > > You should merge bugfix into main, yes (but not main into bugfix.) This patch is actually not good. It breaks nested emphasis like /italic *bold* more italic/ and some other cases [1]. I feel that a proper fix should leverage org-element parser API to determine the emphasis boundaries. However, I am not sure about performance. I am thinking to revert the patch and reopen (BTW, how to do it in Woof!?) this bug report for now. WDYT? [1] https://orgmode.org/list/875yu4pc9m.fsf@localhost Best, Ihor
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Bastien writes: > Ihor Radchenko writes: > >> Should I also merge main with bugfix every time? > > You should merge bugfix into main, yes (but not main into bugfix.) Thanks for the clarification. It indeed makes sense, but I was not sure if merging too frequently is ok or not. Best, Ihor
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Also marking patch as applied
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Thanks! Ihor Radchenko writes: > Should I also merge main with bugfix every time? You should merge bugfix into main, yes (but not main into bugfix.) -- Bastien
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Bastien writes: > Hi Ihor, > > Ihor Radchenko writes: > >> The fix is attached. > > Looks good, feel free to apply in the bugfix branch. Done (fa315986a). Marking the bug as fixed. Should I also merge main with bugfix every time? Best, Ihor
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Hi Ihor, Ihor Radchenko writes: > The fix is attached. Looks good, feel free to apply in the bugfix branch. -- Bastien
Re: Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
"Dr. Arne Babenhauserheide" writes:
> When parsing the following code:
>
> Am richtigen Ort zur richtigen Zeit (=+=; 1x pro Abenteuer im richtigen
> Moment auftauchen), Computeraffinität (=+= oder =++=; Bonus von 3 oder 6),
> Kurze Aufmerksamskeitsspanne (~-~), Photographisches Gedächtnis (=+=),
> Primitive Technologie (~-~), Schreckhaft (~-~), Schrecklich Schusselig (~-~),
> Toller Laptop (=+=) oder Verträumt (~-~).
>
> The fourth line is highlighted as code beginning at the first ~-~ until
> the final closing paren (")") of the paragraph.
Confirmed
The fix is attached.
Best,
Ihor
>From a4c864b7f983a135e8debbc32d8ef4ff3f2e89f4 Mon Sep 17 00:00:00 2001
Message-Id:
From: Ihor Radchenko
Date: Fri, 1 Oct 2021 17:47:02 +0800
Subject: [PATCH] org-do-emphasis-faces: Never treat closing marker as next
opening marker
* lisp/org.el (org-do-emphasis-faces): Make sure that we never match
ending marker of an emphasis as a beginning marker of another
emphasis. For example, in "(~-~) test (~+~)" "~) test (~" is a valid
code match unless we move point to the end the first code emphasis
completely during parsing.
Fixes https://orgmode.org/list/87fsujp7mc@web.de
---
lisp/org.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/org.el b/lisp/org.el
index 9608b52ee..9f68182d9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4855,6 +4855,7 @@ (defun org-do-emphasis-faces (limit)
'(invisible t))
(add-text-properties (match-beginning 3) (match-end 3)
'(invisible t)))
+(goto-char (match-end 0))
(throw :exit t)
(defun org-emphasize (&optional char)
--
2.32.0
Bug: font-lock error with - in code-mode [9.4.6 (9.4.6-gab9f2a @ /gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
When parsing the following code:
Am richtigen Ort zur richtigen Zeit (=+=; 1x pro Abenteuer im richtigen
Moment auftauchen), Computeraffinität (=+= oder =++=; Bonus von 3 oder 6),
Kurze Aufmerksamskeitsspanne (~-~), Photographisches Gedächtnis (=+=),
Primitive Technologie (~-~), Schreckhaft (~-~), Schrecklich Schusselig (~-~),
Toller Laptop (=+=) oder Verträumt (~-~).
The fourth line is highlighted as code beginning at the first ~-~ until
the final closing paren (")") of the paragraph.
LaTeX-Export is correct, though.
Emacs : GNU Emacs 27.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24,
cairo version 1.16.0)
Package: Org mode version 9.4.6 (9.4.6-gab9f2a @
/gnu/store/2pny4z6mbi2aybgzzxz0yrzkds7hbpmq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/)
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
signature.asc
Description: PGP signature
