Re: Bug: org-highest-priority not defined [9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/)]
No Wayman writes: > Subject: [PATCH] Use defvaralias for prioirity variable aliases Thank you for the initial report and the follow-up patch. I'm confused why e062ca719 (org.el: Use `defalias' for priority aliases, 2020-02-24) did the exact opposite reversal, but your patch looks obviously correct. Applied in 097b4e6ca, filling in the commit message.
Re: Bug: org-highest-priority not defined [9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/)]
Proposed patch: diff --git a/lisp/org.el b/lisp/org.el index 31133c554..7b7e4c80a 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -2383,7 +2383,7 @@ set a priority." :group 'org-priorities :type 'boolean) -(defalias 'org-highest-priority 'org-priority-highest) +(defvaralias 'org-highest-priority 'org-priority-highest) (defcustom org-priority-highest ?A "The highest priority of TODO items. @@ -2394,7 +2394,7 @@ Must be smaller than `org-priority-lowest'." (character :tag "Character") (integer :tag "Integer (< 65)"))) -(defalias 'org-lowest-priority 'org-priority-lowest) +(defvaralias 'org-lowest-priority 'org-priority-lowest) (defcustom org-priority-lowest ?C "The lowest priority of TODO items. A character like ?A, ?B, etc., or a numeric value like 1, 2, etc. @@ -2404,7 +2404,7 @@ Must be higher than `org-priority-highest'." (character :tag "Character") (integer :tag "Integer (< 65)"))) -(defalias 'org-default-priority 'org-priority-default) +(defvaralias 'org-default-priority 'org-priority-default) (defcustom org-priority-default ?B "The default priority of TODO items. This is the priority an item gets if no explicit priority is given. On Sat, Feb 29, 2020 at 11:35 PM No Wayman wrote: > Actually, on closer inspection. Shouldn't: > > (defalias 'org-highest-priority 'org-priority-highest) > > be > > (defvaralias ...)? > > On Sat, Feb 29, 2020 at 8:09 PM No Wayman > wrote: > >> After updating Org, I'm hitting errors for an undefined >> `org-highest-priority'. >> I see that this is an alias for `org-priority-highest', but >> describe-function (and I'm not sure why it's describe-function vs >> describe-variable) dutifully reports: >> >> org-highest-priority is an alias for ‘org-priority-highest’, >> which is not >> defined. Please make a bug report. >> >> Not documented. >> >> My first hunch is that this is due to a mixed installation of Org, >> but I'm having trouble diagnosing this. I've installed >> org-plus-contrib using the straight package manager. >> I've ensured that Org is not loaded before/during upgrading Org. >> (locate-library "org") points to the correct file: >> >> "/home/n/.emacs.d/straight/build/org/org.elc" >> >> In the src elisp file, >> /home/n/.emacs.d/straight/repos/org/lisp/org.el there defalias is >> there as I would expect: >> >> (defalias 'org-highest-priority 'org-priority-highest) >> >> My usual technique for debugging this is evaling: >> >> (eval-after-load "org" >> '(debug)) >> >> prior to loading Org. However, in this case it looks like it's >> loading the proper file: >> >> Debugger entered: nil >> (closure (t) nil (debug))() >> funcall((closure (t) nil (debug))) >> mapc(funcall ((closure (t) nil (debug)) (closure (t) nil >> (add-to-list 'org-src-lang-modes '("php" . php))) (closure (t) >> nil (add-to-list 'org-src-lang-modes '("redis" . redis) >> do-after-load-evaluation("/home/n/.emacs.d/straight/build/org/org.elc") >> require(org) >> byte-code("\300\301!\210\300\302!\210\300\303!\207" [require >> cl-lib org org-refile] 2) >> autoload-do-load((autoload "org-capture" 1424805 t nil) >> org-capture) >> command-execute(org-capture) >> >> I plan on reporting with the author of straight.el, too. Just >> following through on the describe-function message here. >> Not sure how to proceed with debugging. Apologies if this is >> noise. >> >> >> Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X >> toolkit, cairo version 1.17.3, Xaw3d scroll bars) >> of 2020-02-23 >> Package: Org mode version 9.3.6 (release_9.3.6-399-ge6df03 @ >> /home/n/.emacs.d/straight/build/org/) >> >> current state: >> == >> (setq >> org-src-mode-hook '(org-src-babel-configure-edit-buffer >> org-src-mode-configure-edit-buffer >> doom-modeline-set-org-src-modeline) >> org-link-shell-confirm-function 'yes-or-no-p >> org-metadown-hook '(org-babel-pop-to-session-maybe) >> org-clock-out-hook '(org-clock-remove-empty-clock-drawer) >> org-refile-targets '((org-agenda-files :maxlevel . 20) >> (my/org-files-list :maxlevel . 20)) >> org-enforce-todo-dependencies t >> org-agenda-category-icon-alist '(("[Ww]ork" >>(#("" 0 1 >> (rear-nonsticky t display >> (raise -0.24) font-lock-face >>(:family "FontAwesome" >>:height 1.2) face >>(:family "FontAwesome" >>:height 1.2)) >> ) >> ) >>nil nil :ascent center) >> ("[Rr]efile" >>(#("" 0 1 >> (rear-nonsticky t display >>
Re: Bug: org-highest-priority not defined [9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/)]
Actually, on closer inspection. Shouldn't: (defalias 'org-highest-priority 'org-priority-highest) be (defvaralias ...)? On Sat, Feb 29, 2020 at 8:09 PM No Wayman wrote: > After updating Org, I'm hitting errors for an undefined > `org-highest-priority'. > I see that this is an alias for `org-priority-highest', but > describe-function (and I'm not sure why it's describe-function vs > describe-variable) dutifully reports: > > org-highest-priority is an alias for ‘org-priority-highest’, > which is not > defined. Please make a bug report. > > Not documented. > > My first hunch is that this is due to a mixed installation of Org, > but I'm having trouble diagnosing this. I've installed > org-plus-contrib using the straight package manager. > I've ensured that Org is not loaded before/during upgrading Org. > (locate-library "org") points to the correct file: > > "/home/n/.emacs.d/straight/build/org/org.elc" > > In the src elisp file, > /home/n/.emacs.d/straight/repos/org/lisp/org.el there defalias is > there as I would expect: > > (defalias 'org-highest-priority 'org-priority-highest) > > My usual technique for debugging this is evaling: > > (eval-after-load "org" > '(debug)) > > prior to loading Org. However, in this case it looks like it's > loading the proper file: > > Debugger entered: nil > (closure (t) nil (debug))() > funcall((closure (t) nil (debug))) > mapc(funcall ((closure (t) nil (debug)) (closure (t) nil > (add-to-list 'org-src-lang-modes '("php" . php))) (closure (t) > nil (add-to-list 'org-src-lang-modes '("redis" . redis) > do-after-load-evaluation("/home/n/.emacs.d/straight/build/org/org.elc") > require(org) > byte-code("\300\301!\210\300\302!\210\300\303!\207" [require > cl-lib org org-refile] 2) > autoload-do-load((autoload "org-capture" 1424805 t nil) > org-capture) > command-execute(org-capture) > > I plan on reporting with the author of straight.el, too. Just > following through on the describe-function message here. > Not sure how to proceed with debugging. Apologies if this is > noise. > > > Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X > toolkit, cairo version 1.17.3, Xaw3d scroll bars) > of 2020-02-23 > Package: Org mode version 9.3.6 (release_9.3.6-399-ge6df03 @ > /home/n/.emacs.d/straight/build/org/) > > current state: > == > (setq > org-src-mode-hook '(org-src-babel-configure-edit-buffer > org-src-mode-configure-edit-buffer > doom-modeline-set-org-src-modeline) > org-link-shell-confirm-function 'yes-or-no-p > org-metadown-hook '(org-babel-pop-to-session-maybe) > org-clock-out-hook '(org-clock-remove-empty-clock-drawer) > org-refile-targets '((org-agenda-files :maxlevel . 20) > (my/org-files-list :maxlevel . 20)) > org-enforce-todo-dependencies t > org-agenda-category-icon-alist '(("[Ww]ork" >(#("" 0 1 > (rear-nonsticky t display > (raise -0.24) font-lock-face >(:family "FontAwesome" >:height 1.2) face >(:family "FontAwesome" >:height 1.2)) > ) > ) >nil nil :ascent center) > ("[Rr]efile" >(#("" 0 1 > (rear-nonsticky t display > (raise -0.24) font-lock-face >(:family "FontAwesome" >:height 1.2) face >(:family "FontAwesome" >:height 1.2)) > ) > ) >nil nil :ascent center) > ("[Aa]ccounting" >(#("" 0 1 > (rear-nonsticky t display > (raise -0.24) font-lock-face >(:family "FontAwesome" >:height 1.2) face >(:family "FontAwesome" >:height 1.2)) > ) > ) >nil nil :ascent center) > ("[Hh]abit" >(#("" 0 1 > (rear-nonsticky t display > (raise -0.24) font-lock-face >(:family "FontAwesome" >
Bug: org-highest-priority not defined [9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/)]
After updating Org, I'm hitting errors for an undefined `org-highest-priority'. I see that this is an alias for `org-priority-highest', but describe-function (and I'm not sure why it's describe-function vs describe-variable) dutifully reports: org-highest-priority is an alias for ‘org-priority-highest’, which is not defined. Please make a bug report. Not documented. My first hunch is that this is due to a mixed installation of Org, but I'm having trouble diagnosing this. I've installed org-plus-contrib using the straight package manager. I've ensured that Org is not loaded before/during upgrading Org. (locate-library "org") points to the correct file: "/home/n/.emacs.d/straight/build/org/org.elc" In the src elisp file, /home/n/.emacs.d/straight/repos/org/lisp/org.el there defalias is there as I would expect: (defalias 'org-highest-priority 'org-priority-highest) My usual technique for debugging this is evaling: (eval-after-load "org" '(debug)) prior to loading Org. However, in this case it looks like it's loading the proper file: Debugger entered: nil (closure (t) nil (debug))() funcall((closure (t) nil (debug))) mapc(funcall ((closure (t) nil (debug)) (closure (t) nil (add-to-list 'org-src-lang-modes '("php" . php))) (closure (t) nil (add-to-list 'org-src-lang-modes '("redis" . redis) do-after-load-evaluation("/home/n/.emacs.d/straight/build/org/org.elc") require(org) byte-code("\300\301!\210\300\302!\210\300\303!\207" [require cl-lib org org-refile] 2) autoload-do-load((autoload "org-capture" 1424805 t nil) org-capture) command-execute(org-capture) I plan on reporting with the author of straight.el, too. Just following through on the describe-function message here. Not sure how to proceed with debugging. Apologies if this is noise. Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.3, Xaw3d scroll bars) of 2020-02-23 Package: Org mode version 9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/) current state: == (setq org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer doom-modeline-set-org-src-modeline) org-link-shell-confirm-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-clock-out-hook '(org-clock-remove-empty-clock-drawer) org-refile-targets '((org-agenda-files :maxlevel . 20) (my/org-files-list :maxlevel . 20)) org-enforce-todo-dependencies t org-agenda-category-icon-alist '(("[Ww]ork" (#("" 0 1 (rear-nonsticky t display (raise -0.24) font-lock-face (:family "FontAwesome" :height 1.2) face (:family "FontAwesome" :height 1.2)) ) ) nil nil :ascent center) ("[Rr]efile" (#("" 0 1 (rear-nonsticky t display (raise -0.24) font-lock-face (:family "FontAwesome" :height 1.2) face (:family "FontAwesome" :height 1.2)) ) ) nil nil :ascent center) ("[Aa]ccounting" (#("" 0 1 (rear-nonsticky t display (raise -0.24) font-lock-face (:family "FontAwesome" :height 1.2) face (:family "FontAwesome" :height 1.2)) ) ) nil nil :ascent center) ("[Hh]abit" (#("" 0 1 (rear-nonsticky t display (raise -0.24) font-lock-face (:family "FontAwesome" :height 1.2) face (:family "FontAwesome" :height 1.2)) ) ) nil nil :ascent center) ("[Hh]ealth" (#("" 0 1 (rea