Re: org-attach-git don't automatically commit changes

2024-01-10 Thread Ihor Radchenko
Juan Manuel Macías writes: >> In any case, if you provide a patch, it will encourage the org >> maintainers to join this discussion and proceed with changes. > > OK, this week I will try to propose a patch here, and bring it up for > (possible) discussion. Thanks for the suggestions. For the

Re: org-attach-git don't automatically commit changes

2021-01-31 Thread Juan Manuel Macías
Ihor Radchenko writes: > What is more tricky is making sure that workflow for people using the > old behaviour is not broken. Just changing to (org-attach-dir) will > break existing git repos in org-attach-id-dir. This should also not be > too hard (say, we can introduce a custom variable

Re: org-attach-git don't automatically commit changes

2021-01-31 Thread Ihor Radchenko
Juan Manuel Macías writes: > Do you think a possible patch could simply consist of replacing (as I > have done) `(expand-file-name org-attach-id-dir)' by `(org-attach-dir)' > in `org-attach-git-commit'? This would allow you to handle attachment > dirs as individual git repos, regardless of :ID:

Re: org-attach-git don't automatically commit changes

2021-01-31 Thread Juan Manuel Macías
Ihor Radchenko writes: > The other thing is that `org-attach-id-dir' makes much less sense from > the time :DIR: property was introduced. So, I believe that > org-attach-git should be updated. Probably, handling attachment dirs as > individual git repos can be one of the ways to upgrade the

Re: org-attach-git don't automatically commit changes

2021-01-31 Thread Juan Manuel Macías
Ihor Radchenko writes: > I think you misunderstood how org-attach-git works. > > org-attach-git is: > > ;; An extension to org-attach. If `org-attach-id-dir' is initialized > ;; as a Git repository, then org-attach-git will automatically commit > ;; changes when it sees them. Requires

Re: org-attach-git don't automatically commit changes

2021-01-31 Thread Ihor Radchenko
Juan Manuel Macías writes: > But if I evaluate this, I get an 'incomplete' path: I think you misunderstood how org-attach-git works. org-attach-git is: ;; An extension to org-attach. If `org-attach-id-dir' is initialized ;; as a Git repository, then org-attach-git will automatically commit

Re: org-attach-git don't automatically commit changes

2021-01-31 Thread Juan Manuel Macías
Hi Ihor, Ihor Radchenko writes: > Does it mean that your attachment folder is set in :DIR: property? No, my attachment folder is build using :ID: property. For example, in my heading: * Test :PROPERTIES: :ID: d0e690e2-2ecd-4224-891a-b91257db5389 :END: And if I evaluate

Re: org-attach-git don't automatically commit changes

2021-01-30 Thread Ihor Radchenko
Juan Manuel Macías writes: > The default value of `org-attach-id-dir' is "data/", and if I evaluate > `(expand-file-name org-attach-id-dir)' on my current node, it returns a > wrong path to the attached folder. `org-attach-sync' only works for me > if I set in `org-attach-git-commit' the

Re: org-attach-git don't automatically commit changes

2021-01-30 Thread Juan Manuel Macías
Hi Ihor, Ihor Radchenko writes: > Note that org "sees" changes in the attachment dir only when you use > M-x org-attach command to manage the attachments. Directly changing the > attachment directory will not be noticed. You can force org-mode to > check for changes in attachment dir by running

Re: org-attach-git don't automatically commit changes

2021-01-29 Thread Ihor Radchenko
Juan Manuel Macías writes: > I don't see that org-attach "automatically commit changes when it sees > them". Only when I run in the attached directory `M-: > (org-attach-git-commit) RET' it works fine. Note that org "sees" changes in the attachment dir only when you use M-x org-attach command

org-attach-git don't automatically commit changes

2021-01-29 Thread Juan Manuel Macías
Hi, I don't know if this is a bug or if I am doing something wrong... According to the manual: #+begin_quote If the directory attached to an outline node is a Git repository, Org can be configured to automatically commit changes to that repository when it sees them. To make Org mode take care