Re: org-read-date: selecting date with mouse-2 in calendar
Michael Heerdegen writes: > Hello again, > >> selecting a date from within `org-read-date' from the calendar works >> with mouse-1, but not with mouse-2 (with latest Emacs master and my >> settings loaded at least). >> >> The code seems to intend that it also works with mouse-2, but it fails. >> >> Why it doesn't work? Oh, that's because calendar already binds >> down-mouse-2 to pop-up a menu (see definition of `calendar-mode-map'). >> So when we would add the following line to `org-read-date' (it's obvious >> to where and I'm too lazy to create a patch now): >> >> + (org-defkey map [down-mouse-2] nil) > > No comments on this (hope it wasn't too confused...)? I don't know anything about these mouse things and have to review the manual whenever they come up. Please provide a patch with a proper commit message, and I'll review it this weekend if nobody else gets to it sooner. > Should I just commit the fix to the Emacs master branch? No, I'd appreciate if you did not.
Re: org-read-date: selecting date with mouse-2 in calendar
Hello again, > selecting a date from within `org-read-date' from the calendar works > with mouse-1, but not with mouse-2 (with latest Emacs master and my > settings loaded at least). > > The code seems to intend that it also works with mouse-2, but it fails. > > Why it doesn't work? Oh, that's because calendar already binds > down-mouse-2 to pop-up a menu (see definition of `calendar-mode-map'). > So when we would add the following line to `org-read-date' (it's obvious > to where and I'm too lazy to create a patch now): > > + (org-defkey map [down-mouse-2] nil) No comments on this (hope it wasn't too confused...)? Should I just commit the fix to the Emacs master branch? TIA, Michael.
Re: org-read-date: selecting date with mouse-2 in calendar
Michael Heerdegen writes: > Nothing is lost since the original popup-menu for the calendar is > still being bound to down-mouse-3 (the more expected key for such a > menu in my opinion, at least 2021). That was not quite correct, however. These are the defining lines: ;; These are referenced in the default calendar-date-echo-text. (define-key map [down-mouse-3] (easy-menu-binding cal-menu-context-mouse-menu)) (define-key map [down-mouse-2] (easy-menu-binding cal-menu-global-mouse-menu)) So the calendar provides a global (mouse-2) and a context menu (mouse-3). Seems both are not really useful for `org-read-date'. Michael.
Re: org-read-date: selecting date with mouse-2 in calendar
Michael Heerdegen writes: > So please consider [...] Oh, and please keep me CC'd, I don't read the list regularly. Thanks, Michael.
org-read-date: selecting date with mouse-2 in calendar
Hello, selecting a date from within `org-read-date' from the calendar works with mouse-1, but not with mouse-2 (with latest Emacs master and my settings loaded at least). The code seems to intend that it also works with mouse-2, but it fails. I don't prefer mouse-2, but it would be good to support it I think, since "clicking" in Emacs is with mouse-2 historically, breaking that might cause inconvenience. Why it doesn't work? Oh, that's because calendar already binds down-mouse-2 to pop-up a menu (see definition of `calendar-mode-map'). So when we would add the following line to `org-read-date' (it's obvious to where and I'm too lazy to create a patch now): + (org-defkey map [down-mouse-2] nil) it works as expected for me. Nothing is lost since the original popup-menu for the calendar is still being bound to down-mouse-3 (the more expected key for such a menu in my opinion, at least 2021). So please consider to add the above line to the defun of `org-read-date'. Regards, Michael.
