Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > Unless I misunderstand what you mean, the patch seems to follow this > style. Yes, sorry, my bad, I was reacting to another patch. >> I think this should be applied to the maint branch, right? In this >> case, the patch does not apply. Can you check

Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Sébastien Miquel
Hi Bastien, Bastien writes: Also, nitpick: please don't add a full-stop at the end of the first line of the commit message (or the subject of your patch). Unless I misunderstand what you mean, the patch seems to follow this style. I think this should be applied to the maint branch, right?

Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > The issue is that currently tangling a single block by calling > `org-babel-tangle` with a prefix argument fails. This is unrelated to > the earlier thread today, but was introduced by my original commit > a2cb9b853d. > > Unfortunately, fixing it

Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > I apologise again for the troubles. No problem. So we're all set here? Also, nitpick: please don't add a full-stop at the end of the first line of the commit message (or the subject of your patch). Thanks, -- Bastien

Re: [PATCH] tangling seems to have broken today

2021-05-05 Thread Sébastien Miquel
Hi Bastien, The issue is that currently tangling a single block by calling `org-babel-tangle` with a prefix argument fails. This is unrelated to the earlier thread today, but was introduced by my original commit a2cb9b853d. Unfortunately, fixing it requires some refactorisation to avoid code

Re: tangling seems to have broken today

2021-05-05 Thread Eric S Fraga
On Wednesday, 5 May 2021 at 14:17, Sébastien Miquel wrote: > Eric S Fraga writes: >> I was using org-babel-tangle. Although, in this case, with C-u before >> to tangle just the particular block. > Indeed, I have broken this. I'll provide a patch, shortly. Thank you! And I should have given

Re: tangling seems to have broken today

2021-05-05 Thread Sébastien Miquel
Eric S Fraga writes: I was using org-babel-tangle. Although, in this case, with C-u before to tangle just the particular block. Indeed, I have broken this. I'll provide a patch, shortly. -- Sébastien Miquel

Re: tangling seems to have broken today

2021-05-05 Thread Eric S Fraga
On Wednesday, 5 May 2021 at 13:54, Sébastien Miquel wrote: > What command are you using ? > > Running `org-babel-tangle` works for me with latest master using your > example. I was using org-babel-tangle. Although, in this case, with C-u before to tangle just the particular block. -- : Eric S

Re: tangling seems to have broken today

2021-05-05 Thread Sébastien Miquel
Hi Eric, Timothy, Eric S Fraga writes: I can no longer tangle with a given file name. The error I get indicates that the tangling procedure is looking at the first line of the actual code block. What command are you using ? Running `org-babel-tangle` works for me with latest master using

Re: tangling seems to have broken today

2021-05-05 Thread Bastien
Timothy writes: > I'd just like to chime in to note that I am also experiencing this > issue. Thanks, I guess Sébastien will be able to fix it. If you and Eric can find how to fix this while addressing the original issue Sébastien was trying to resolve, feel free to go ahead. -- Bastien

Re: tangling seems to have broken today

2021-05-05 Thread Timothy
I'd just like to chime in to note that I am also experiencing this issue. Eric S Fraga writes: > I note that the git log shows a commit which affects tangling: 501b2a191 > > I can no longer tangle with a given file name. The error I get > indicates that the tangling procedure is looking at

tangling seems to have broken today

2021-05-05 Thread Eric S Fraga
I note that the git log shows a commit which affects tangling: 501b2a191 I can no longer tangle with a given file name. The error I get indicates that the tangling procedure is looking at the first line of the actual code block. For instance, if I have #+begin_src org ,#+begin_src julia