Re: attachment: link type export to HTML invalid attach dir

2020-01-18 Thread Nicolas Goaziou
Hello, Gustav Wikström writes: > Ok, so change pushed... I'm sorry, but this is going too fast. We're discussing core design here (the parser), and I couldn't even answer your proposal. Let's at least reach an agreement on the change to make. Regards, -- Nicolas Goaziou

[RFC PATCH] Changes to pop-up source buffers

2020-01-18 Thread Jack Kamm
This patch changes some implementation details of org-src-switch-to-buffer and org-edit-src-exit, to more consistently use pop-to-buffer to open the source buffer, and quit-restore-window to close it. It also adds a new default option to org-src-window-setup. I'll explain some details and

Re: [RFC PATCH] Changes to pop-up source buffers

2020-01-18 Thread Jack Kamm
Hi Sam, > for me, trying to get commands or functions that call pop-to-buffer to > behave as i need them to, which is to say, for them to use the full > (and same) window for accessibility reasons,* has been so unfixable in > the past that i had to give up. Thank you for raising this, I wasn't

RE: [O] FW: [RFC] Link-type for attachments, more attach options

2020-01-18 Thread Gustav Wikström
Hi! org-attach-store-link-p with option t is supposed to store a link to the original location (i.e. the location the file was/is in before it was attached to the node. That was the default before I started working with attachments I believe. Haven't ever used that feature myself but the patch

Re: [O] FW: [RFC] Link-type for attachments, more attach options

2020-01-18 Thread stardiviner
stardiviner writes: I finally figured out why the link always failed. Because it use wrong variable which is old filename path. I attached a patch. > Gustav Wikström writes: > >> Hi, >> >>> -Original Message- >>> From: stardiviner >>> Sent: den 15 januari 2020 07:21 >>> To: Gustav

Re: Missing `org-attach-set-inherit' function

2020-01-18 Thread stardiviner
Gustav Wikström writes: > Hi, > >> -Original Message- >> From: Emacs-orgmode On >> Behalf Of stardiviner >> Sent: den 17 januari 2020 08:39 >> To: emacs-orgmode@gnu.org >> Subject: Missing `org-attach-set-inherit' function >> >> >> I found the function ~org-attach-set-inherit~ is

RE: attachment: link type export to HTML invalid attach dir

2020-01-18 Thread Gustav Wikström
Hi, > -Original Message- > From: Nicolas Goaziou > Sent: den 18 januari 2020 12:34 > To: Gustav Wikström > Cc: emacs-orgmode@gnu.org > Subject: Re: attachment: link type export to HTML invalid attach dir > > Hello, > > Gustav Wikström writes: > > > Ok, so change pushed... > > I'm

Re: [RFC PATCH] Changes to pop-up source buffers

2020-01-18 Thread Samuel Wales
i can't comment on your ideas at all, but just have one concern, which maybe could trip up others like me. namely, pop-to-buffer, as stated in its very docstring, prefers not the same window. if i remember correctly, this is the window management problem i have been struggling with since 2002.

Re: [O] FW: [RFC] Link-type for attachments, more attach options

2020-01-18 Thread stardiviner
Gustav Wikström writes: > Hi! > > org-attach-store-link-p with option t is supposed to store a link to the > original location (i.e. the location the file was/is in before it was > attached to the node. That was the default before I started working with > attachments I believe. Haven't ever

Re: [RFC PATCH] Changes to pop-up source buffers

2020-01-18 Thread Samuel Wales
On 1/18/20, Jack Kamm wrote: > What setting of org-src-window-setup are you using? If it is > "current-window" or "reorganize-frame", this patch shouldn't affect you > at all, as those implementations are left the same. you're right, i have that set to current-window, as you might expect. and it

Re: [RFC PATCH] Changes to pop-up source buffers

2020-01-18 Thread Kyle Meyer
Jack Kamm writes: > This patch changes some implementation details of > org-src-switch-to-buffer and org-edit-src-exit, to more consistently use > pop-to-buffer to open the source buffer, and quit-restore-window to > close it. It also adds a new default option to org-src-window-setup. > [...]

Re: [RFC PATCH] Changes to pop-up source buffers

2020-01-18 Thread stardiviner
> A final advantage I'd like to note for pop-to-buffer and > quit-restore-window, is that these are the mechanisms used by many > built-in Emacs functions to pop up and close windows, such as *Help* > windows. I agree to use =pop-to-buffer=. Propose too. > > There was one previous option for