[O] bug#10125: 24.0.91; package.el (org): Macros in tar packages order of byte compilation

2011-11-25 Thread Stefan Monnier
fresh Emacs instance. There's no reason the package manager could not spawn a separate Emacs in batch-mode as a sub-job to do the compilation. Very lightly tested version: This uses the Emacs executable on the exec path, which might not be the correct one. I'm wary of making such a

Re: [Orgmode] Re: Announcing org-contacts, a bbdb-like contact manager for Org

2011-02-10 Thread Stefan Monnier
I'm also using Emacs 24, and for me it doesn't work. Ok. Anyway I've just double checked, and it worst than that. Typing 'a' complete to 'aA' (instead of 'Anne mailaddress') and then does nothing since aA is not valid. I'm not sure completion-at-point-functions is correctly usable in this

Re: [Orgmode] Re: Announcing org-contacts, a bbdb-like contact manager for Org

2011-02-11 Thread Stefan Monnier
So the question is: how can the completion-ignore-case value be propagated from the completion gathering function in `completion-at-point-functions' to the function that actually applies this completion, without having to modify the global or buffer local value of `completion-ignore-case'?

Re: [Orgmode] Re: Announcing org-contacts, a bbdb-like contact manager for Org

2011-02-11 Thread Stefan Monnier
So the question is: how can the completion-ignore-case value be propagated from the completion gathering function in `completion-at-point-functions' to the function that actually applies this completion, without having to modify the global or buffer local value of `completion-ignore-case'?

[Orgmode] Re: Alinea filling (hanlding of explicit line-breaks)

2011-02-14 Thread Stefan Monnier
The proposal is to add, in addition to paragraph separator, an alinea separator. Accordingly there would be a forward-alinea function similar to forward-paragraph. I'm not completely sure I understand the details, so let me try to describe what I think you're suggesting: you're suggesting to

[Orgmode] Re: Alinea filling (hanlding of explicit line-breaks)

2011-02-15 Thread Stefan Monnier
Maybe an example is better to explain what I need, imagine that I have the following two paragraphs: [...] Where I assumed that alineas are separated by either an empty line or a tailing `\\' while paragraphs are separated by just an empty line. An important question here is: is it important

[Orgmode] Re: Alinea filling (hanlding of explicit line-breaks)

2011-02-16 Thread Stefan Monnier
An important question here is: is it important for M-} to ignore those \\? I guess so, this is the current default Org behaviour anyhow. Good. as far as I understand, it would be anyhow possible to move point on an alinea-by-alinea basis just by configuring the tailing \\ as anohter

[O] Re: Alinea filling (hanlding of explicit line-breaks)

2011-03-12 Thread Stefan Monnier
Actually, no, because paragraph-separate would cause the whole line that ends with \\ to be treated as not being part of a paragraph, and paragraph-start wouldn't be appropriate either. Hence the good above :-( [...] I have implemented the thing locally on my machine. It works well but

[O] Re: Alinea filling (hanlding of explicit line-breaks)‏

2011-03-13 Thread Stefan Monnier
But it seems that it does not exactly does the job this way: if the argument sign is 0 and you are in the middle of a paragraph, then, unless the paragraph is at beginning of buffer you are going to the character before the 1st one, rather than to the 1st character of paragraph. Actually,

[O] Re: Completing with anything

2011-03-18 Thread Stefan Monnier
For more complex cases, there is also the issue of what to do when some parts of the completion are case-sensitive and other parts aren't (e.g. completion of case-sensitive envvars in case-insensitive file names), although this is less important for completion-at-point than for minibuffer

[O] Re: Completing with anything

2011-03-21 Thread Stefan Monnier
There's a misunderstanding: AFAIK the patch sent by Tassilo does not make the completion-at-point-function return a function that performs completion but does properly return completion data (i.e. region start, region end, and completion table), part of which happens to be represented by a

[O] Re: Completing with anything

2011-03-21 Thread Stefan Monnier
What I'd like to do is that if the user enters: docTAB is that it can be completed to Emmett Brown gigaw...@delorean.com In a BBDB discussion, I suggested to complete the above to Emmett Brown \doc\ gigaw...@delorean.com, but it's true that you may prefer to keep the nickname

[O] Re: Completing with anything

2011-03-21 Thread Stefan Monnier
As Tassilo mentions, maybe we could have a post-completion step that can perform some kind of expansion/replacement/cleanup once a valid completion is selected. I'm not sure what that would look like in terms of code and API, but if someone wants to try it out a propose a patch to start a

Re: [O] Re: Completing with anything

2011-04-09 Thread Stefan Monnier
So now, I wonder: wouldn't it be a good idea to add a call to `expand-abbrev' just after `completion-at-point' is being called? After completing an abbrev name, yes, but otherwise I don't think so. I.e. why don't you add such a call to org-contacts-message-complete-function? Stefan

Re: [O] Completing with anything

2011-04-11 Thread Stefan Monnier
Because this one return (list start end completion-choies), and does not do anything else. I can't do it myself using the current completion mechanism, IIUC. Hmm... good point, doing it in completion-choices is not reliable, tho using as completion table something like: (lambda (string pred

Re: [O] Completing with anything

2011-05-04 Thread Stefan Monnier
Hmm... good point, doing it in completion-choices is not reliable, tho using as completion table something like: (lambda (string pred action) (let ((res (complete-with-action action completion-choices string pred))) (if (and (eq action nil) (assq (if (eq res t) string res)

Re: [O] Completing with anything

2011-05-23 Thread Stefan Monnier
So at least cycling-completion seems fundamentally incompatible with this idea of abbrev-expansion-after-completion, at least if you want to allow arbitrarily complex abbrevs like skeletons. Indeed, this is a real problem. I've now added a :exit-function property that

Re: [O] Completing with anything

2011-05-24 Thread Stefan Monnier
So, could you add 'failed, which means that no function was able to complete? That way I could do something like (setq completion-extra-properties '(:exit-function my-exit-function)) (defun my-exit-function (string finished) (when (eq finished 'failed) (dabbrev-expand))) and always

Re: [O] Completing with anything

2011-05-24 Thread Stefan Monnier
Oh well, I guess that I'm the only one who wants this kind of behaviour, No, I'm interested as well, but haven't found a good solution yet. Stefan

Re: [O] Completing with anything

2011-05-24 Thread Stefan Monnier
(defadvice completion-at-point (after completion-at-point-complete-if-failed activate) Fallback on dabbrev if completion didn't do anything useful. (unless ad-return-value (dabbrev-expand nil))) BTW, you can avoid the advice by using your own (defun al-completion-at-point ()

Re: [O] Completing with anything

2011-05-24 Thread Stefan Monnier
Oh well, I guess that I'm the only one who wants this kind of behaviour, so I just ended up with an advice which seems to do the trick. Sorry for hijacking this thread. In case anyone is interested: To get back to this discussion. Before worrying about how to implement it, I'm wondering

Re: [O] Completing with anything

2011-05-25 Thread Stefan Monnier
Another is to do it more selectively, flag some of completion-at-point-functions as not-exclusive, meaning that if completion fails with those we should keep trying with subsequent functions. E.g. the nick completion in rcirc could be flagged as non-exclusive since it applies everywhere,

Re: [O] Completing with anything

2011-05-27 Thread Stefan Monnier
With these two modifications, it runs fine (that is, using the old calling convention and just using (setq-default completion-at-point-functions '(my-dabbrev-expand))) Thanks, installed, Stefan

[O] bug#17484: 24.3.91; Emacs Pretest (emacs-24.3.91.tar.xz) freeze

2014-05-13 Thread Stefan Monnier
So, that's an org-mode bug, I'll try to see if I can reproduce it Right: org-adaptive-fill-function should finish fairly promptly. (though I wonder why it uses `inhibit-quit' in the first place). It's not org-mode which binds inhibit-quit but the C code that runs jit-lock. The C code binds

[O] bug#17484: 24.3.91; Emacs Pretest (emacs-24.3.91.tar.xz) freeze

2014-05-14 Thread Stefan Monnier
gdb) xbacktrace avl-tree-delete (0x54b0) byte-code (0x55a0) byte-code (0x5760) org-element--cache-process-request (0x5990) byte-code (0x5aa0) org-element--cache-sync (0x5ce0) org-element-at-point (0x5e00) byte-code (0x60d0) org-adaptive-fill-function

[O] bug#17484: 24.3.91; Emacs Pretest (emacs-24.3.91.tar.xz) freeze

2014-05-14 Thread Stefan Monnier
Is there a way to disable the effect of `inhibit-quit' in `jit-lock' so C-g interrupt again in order to get an elisp-backtrace with `debug-on-quit'. Otherwise, what's the best way to debug this? Looking closer at `org-adaptive-fill-function'? You can try `debug-on-event'. There's

[O] bug#17484: 24.3.91; Emacs Pretest (emacs-24.3.91.tar.xz) freeze

2014-05-28 Thread Stefan Monnier
We can probably close this bug. I haven't been able to reproduce it with the org-mode bundled with the pretest version. Thanks, done. Sorry for the noise. Better luck next time, Stefan

[O] bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-11 Thread Stefan Monnier
Say thanks to Stefan for flagging all those bugs ;-) Now that I think about it, I should make `car' signal an error every 100th call, as well. Would flag many bugs (with some false positives, of course, but what's a few false positives among friends?)! Stefan

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-11 Thread Stefan Monnier
+(defun org-recenter (optional arg) + Like `recenter' but ensure that the `current-buffer' is +properly set. + (with-current-buffer (window-buffer) +(recenter arg))) This doesn't make much sense: in many case (window-buffer) can be a buffer completely unrelated to Org.

[O] bug#17724: 24.4.50; regression: error `recenter'ing a window that does not display current-buffer. when opening org-mode file

2014-06-17 Thread Stefan Monnier
if (buf != current_buffer) // error (`recenter'ing a window that does not display current-buffer.); return Qnil; ... in src/window.c seems to work for me. Using `emacs-24' also works, without defeating the purpose of the error message ;-) Stefan

[O] bug#17724: 24.4.50; regression: error `recenter'ing a window that does not display current-buffer. when opening org-mode file

2014-06-17 Thread Stefan Monnier
Perhaps add some advise to the web page so ppl pull the emacs24 branch instead? Does someone know how to change the text in http://savannah.gnu.org/git/?group=emacs? Stefan

[O] bug#17724: 24.4.50; regression: error `recenter'ing a window that does not display current-buffer. when opening org-mode file

2014-06-18 Thread Stefan Monnier
Ask savannah-hack...@gnu.org. Then it's not worth the trouble (since it's a temporary change that will need to be modified yet again when we release 24.4). Stefan

[O] bug#17724: 24.4.50; regression: error `recenter'ing a window that does not display current-buffer. when opening org-mode file

2014-06-18 Thread Stefan Monnier
Not sure what you have in mind, but perhaps we should rename the branch to something like 'release-branch', and then its name won't need to change with the Emacs versions. It's not just the name: after the release we won't ask people to track the release-branch. Maybe we could use a branch

Re: [O] Fontification of org code block not printed

2014-07-29 Thread Stefan Monnier
I'm sure that this is not what I expect but I'm not sure if this is a fault in ps-def.el or org.el. Because of this I send this to both mailing lists to get help before sending an error report. It's a problem in the ps-def.el code which handles the `face' property in a naive way: it fails to

Re: bug#3597: [Orgmode] 23.0.94; [PATCH] org-store-link broken within kbd macros

2009-06-26 Thread Stefan Monnier
This sounds like interactive-p is working as documented and the excplicit check I proposed would be neccessary. True enough, and I am applying your fix. IIUC you may want to use called-interactively-p instead. Stefan ___ Emacs-orgmode

[O] bug#13820: It was not fixed; it now is, though I don't understand the reason

2013-06-26 Thread Stefan Monnier
Debugger entered--Lisp error: (wrong-type-argument symbolp (autoload [...] interactive-form((autoload org-agenda Activate appointments found [...] advice--make-interactive-form(ad-Advice-org-agenda-to-appt (autoload I installed a patch into trunk that should fix this, thank you.

[O] bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

2013-07-30 Thread Stefan Monnier
That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that list is coupled to debbugs.gnu.org, and because I reassigned the bug after it was received, subsequent replies went to both lists. But the initial report is only on bug-gnu-emacs. It would be nice if some message were

Re: [O] (Emacs 23/24 binary compatibility): defstruct, setf

2013-09-03 Thread Stefan Monnier
I think existing *.elc files compiled against Emacs-23.2.1 should load fine on new Emacs versions. It's indeed an incompatibility I introduced when we switched from CL's setf to gv.el's setf, because the two work in a very different way. Stefan

Re: [O] (Emacs 23/24 binary compatibility): defstruct, setf

2013-09-03 Thread Stefan Monnier
I think existing *.elc files compiled against Emacs-23.2.1 should load fine on new Emacs versions. It's indeed an incompatibility I introduced when we switched from CL's setf to gv.el's setf, because the two work in a very different way. In simple terms, the problem seems to be a 24.x style

Re: [O] (Emacs 23/24 binary compatibility): defstruct, setf

2013-09-04 Thread Stefan Monnier
Does the patch below work for you? Yes. Please install. Done, Stefan

[O] bug#15815: 24.3.50; distant-foreground face attribute and org-hide face

2013-11-10 Thread Stefan Monnier
FWIW, hiding text by setting foreground == background is the wrong way to do it IMO. AFAIK there's no other way offered by Emacs. `invisible' actually removes the text from the output rather than leaving blank space, so it doesn't provide the same feature. Stefan

[O] bug#15888: 24.3.50; Eval-after-load eval'ed twice

2013-11-15 Thread Stefan Monnier
BTW, it's probably easier to debug this in Elisp. You can start with (add-hook 'after-load-functions (lambda (file) (message Loaded %S file))) Or change your recipe to replace (sit-for 3) with (debug). Stefan

[O] bug#17055: 24.3.50; Emacs hangs in Org mode file

2014-03-21 Thread Stefan Monnier
Still no prompt but Emacs survived this infloop (not an infloop, then) after I don't know how much time (but more than a couple of minutes). Then try to M-x profiler-start RET RET ... reproduce ... M-x profiler-report RET And the C-u RET on the + to expand the display. Stefan

[O] bug#12702: 24.2; Orgmode Refile complains Not bookmark format

2012-10-24 Thread Stefan Monnier
I found a way to reproduce this: have a corrupt bookmarks file. Check the contents of your bookmark-default-file. Try (re)moving it. Wonderfull. I had an empty ~/.emacs.d/bookmarks file. I removed it and the problem is gone. Hmm... it would be good if Emacs were a bit more helpful here by

[O] bug#12702: 24.2; Orgmode Refile complains Not bookmark format

2012-10-24 Thread Stefan Monnier
The error message makes sense ... as soon as you know where the problem comes from :) Also, while it's good to signal to the user that his bookmark file is corrupted (and to make sure we don't overwrite it with something else), I don't see why that should prevent Org's Refile from working.

[O] bug#10125: RFE: require and load-path-shadowing

2013-01-10 Thread Stefan Monnier
There is currently a problem with package manager when a package is installed from a package archive,that package is already installed either in Emacs core or site-lisp, and when (parts of) said package have already been loaded when ELPA tries to install: the byte-compiler will use the

[O] bug#10125: RFE: require and load-path-shadowing

2013-01-11 Thread Stefan Monnier
I guess we could fork Emacs early on and keep this second process around as a process from which to generate new clean slates. I've been thinking about something like this for a while… if it worked at least as well as starting a new Emacs instance on all platforms, I'd favor this approach.

[O] bug#10125: RFE: require and load-path-shadowing

2013-01-11 Thread Stefan Monnier
I guess we could fork Emacs early on and keep this second process around as a process from which to generate new clean slates. I've been thinking about something like this for a while… if it worked at least as well as starting a new Emacs instance on all platforms, I'd favor this approach.

[O] bug#10125: RFE: require and load-path-shadowing

2013-01-12 Thread Stefan Monnier
IOW, do you expect the byte-compile instances to be different in any way from a fresh Emacs session invoked from the shell as emacs -Q? Yes, because the current Emacs may be a different executable than the one the shell would run in response to emacs -Q. Stefan

[O] bug#10125: RFE: require and load-path-shadowing

2013-01-12 Thread Stefan Monnier
Yes, this subroutine is never directly called from C, so placing an advice should work just fine. I thought coding conventions prevented advising primitives? Nothing prevents advising primitive functions (advising special forms is another matter altogether). But primitive functions can be

[O] bug#10125: RFE: require and load-path-shadowing

2013-01-12 Thread Stefan Monnier
In that case, isn't it enough to call (package-initialize) before any Org configuration? Here's the scenario: start Emacs use Org use package.el to install a newer version of Org Stefan

[O] bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

2013-02-15 Thread Stefan Monnier
,- | M-: (org-mark-element) RET `- moves point to the beginning of source-block (body) and returns the position of point without (visibly) marking the source-block body. Indeed, thank you. Should be fixed now, thanks to the patch below,

[O] bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode

2012-03-23 Thread Stefan Monnier
Isn't there an underlying bug in Emacs here? Whether it's a bug or not depends on point of view. flyspell takes the position that it binds M-TAB, so if you want to bind M-tab to something else you can (and you still get flyspell's command on C-M-i and on ESC TAB). Stefan

[O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost

2012-07-03 Thread Stefan Monnier
Which is what one wants. Someone seems to be merging the self-insert commands in your situation. Probably the native merging code has changed in recent Emacs itself. Indeed, self-insert-command used to be treated specially by the read-eval-loop and the merging was performed there. Now this

[O] bug#11774: bug#11774: bug#11774: org-mode causes undo boundaries to be lost

2012-07-03 Thread Stefan Monnier
The first is that it hardcodes the clustering by 20. I guess that's the problem which is not new. This was possible to work around before Emacs 24. You could advise self-insert-command or wrap it. This is why Org was able to control this with a variable to support clustering or not

[O] bug#11774: bug#11774: bug#11774: org-mode causes undo boundaries to be lost

2012-07-18 Thread Stefan Monnier
'src/ChangeLog' --- src/ChangeLog 2012-07-18 05:44:36 + +++ src/ChangeLog 2012-07-18 13:17:22 + @@ -1,3 +1,10 @@ +2012-07-18 Stefan Monnier monn...@iro.umontreal.ca + + * lisp.h (last_undo_boundary): Declare new var. + * keyboard.c (command_loop_1): Set

Re: [Orgmode] Backspacing into folded items

2010-09-04 Thread Stefan Monnier
However the plan is to make reveal-mode default: You're jumping to conclusions, Stefan ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org

Re: [Orgmode] Backspacing into folded items

2010-09-04 Thread Stefan Monnier
However the plan is to make reveal-mode default: You're jumping to conclusions, Sorry, but what is the plan then? W.r.t. reveal-mode, there is no plan. Stefan ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the

Re: [Orgmode] Weird behaviour with org-yank and org-startup-indented

2010-10-20 Thread Stefan Monnier
The problem is in org-indent-refresh-section, which is run from a timer. This function first moves point and then calls remove-text-properties, which is considered a buffer change. Since the mark is active, the selection code saves the region to saved-region-selection, from which it is later

[O] bug#11774: bug#11774: bug#11774: org-mode causes undo boundaries to be lost

2014-11-03 Thread Stefan Monnier
There is one possible bug. I have undo-boundary on self-insert-hook. If I do newline-and-indent, for some reason both the newline and the indent get undo boundaries. My expectation is that typing RET should only have one undo boundary. I don't know if that is user expectation error, but

[O] Avoiding `intangible'

2015-04-15 Thread Stefan Monnier
I'm on a crusade to eradicate the `intangible' property, which happens to rub me the wrong way because it's implemented at too-low a level (it affects every point movement) which incurs a significant performance penalty (even when not used) and affects a lot of code which then needs to be fixed by

Re: [O] Why does evaluating a piece of Elisp code seemingly not expand a macro?

2016-01-18 Thread Stefan Monnier
> Does it mean that C-M-x is different than loading? Yes. > Or C-x C-e, for that matter? As well. > Is this covered by the manual? (If not, it might need correcting.) Not really. The basic idea is that macroexpansion can take place *anytime* (tho, before the code is actually executed). If

Re: [O] Why does evaluating a piece of Elisp code seemingly not expand a macro?

2016-01-18 Thread Stefan Monnier
> Does that mean that it's possible that a function definition contains > unexpanded macros? Yes. > Does that mean that `symbol-function' will expand them? AFAIK it currently never happens there, but if your code relies on this property it's probably got a bug. > Does that mean that if I

[O] bug#22399: org-mode fontification

2016-02-01 Thread Stefan Monnier
> No, I don't have commit rights. I'll update the Org side, but, for > issues that were introduced in the Emacs tree post 24.5, I don't know if > it's preferable to also update Emacs instead of waiting for the changes > to come over with a full sync. Looks like there's no Org people following

[O] bug#22399: org-mode fontification

2016-01-25 Thread Stefan Monnier
> Sure. With > > --8<---cut here---start->8--- > > #+BEGIN_SRC elisp > (require 'cl-lib) > (message "test") > #+END_SRC > --8<---cut here---end--->8--- > > in /tmp/scratch.org, run > > emacs -Q --eval "(setq

[O] bug#22399: org-mode fontification

2016-01-20 Thread Stefan Monnier
> (defalias 'org-font-lock-ensure > - (if (fboundp 'org-font-lock-ensure) > + (if (fboundp 'font-lock-ensure) >#'font-lock-ensure > -(lambda (_beg _end) (font-lock-fontify-buffer > +(lambda ( _beg _end) (font-lock-fontify-buffer Looks good. > (unless (eq

[O] bug#22399: org-mode fontification

2016-01-26 Thread Stefan Monnier
>> I see the problem. org-src-font-lock-fontify-block is using buffers >> named " org-src-fontification:" in an unusual way: >> they're updated via normal buffer modifications, but they're not put in >> font-lock-mode, so all the font-lock machinery which tries to keep the >> fontification

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-20 Thread Stefan Monnier
> Maybe there's a misunderstanding. What Noam suggested was just to > move the code which adjusts search_regs.start[i] and .end[i] to before > the call to replace_range. Oh, right, that's also an option. It might suffer from another problem, which is that the match-data will be broken while the

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-20 Thread Stefan Monnier
> Is it OK to adjust the match data before actually making the > replacement? If so, I think it's a simpler solution. >> PS: I can think of one (theoretical) other/better way to fix this >> problem: move the match-data adjustment so it's done within >> replace_range before running the

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-20 Thread Stefan Monnier
> Solution: adjust in between the before and after change functions. > Patch below. I think there shouldn't be performance problems, although > it does add yet another flag to replace_range (by the way, I noticed > that the MARKERS flags is never 0, so it's redundant). I tested with > the

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-20 Thread Stefan Monnier
>> - maybe we can even adjust_match_data in every call to replace_range >> rather than just in the one from Freplace_match. > That would be simpler, though I wasn't sure if it would be correct. I think it's definitely not an option for emacs-25. But maybe we can try it on master.

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-18 Thread Stefan Monnier
> In the case in point, a single character at EOB (= 62) was deleted, > which made EOB be 61, one less than its previous value. When > save-match-data was called from within a hook set up by Org, it tried > to record the end of the sub-expression as 62, but set-marker silently > changed that to

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-18 Thread Stefan Monnier
> The more general problem is when there's at least one more > sub-expression, whose start and/or end are after the new EOB. > Those sub-expression's data will be completely bogus after the > adjustment, If they were after the EOB, they were already bogus to start with. So there's really not much

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-19 Thread Stefan Monnier
> Before call to replace_range in replace-match: > >|---|---|--|| >s1 e1 s2e2 EOB > > (s1, e1, etc. are the start and end of the corresponding > sub-expressions.) > > After the call to replace_range in replace-match: > >

[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)

2016-07-19 Thread Stefan Monnier
> Do we care that using save-match-data in every call to replace-match > might mean a performance hit? I do but: - to be honest, it's probably lost in the noise. - if we copy search_regs.start and search_regs.end with something like alloca+memcpy (instead of calling Fmatch_data), the cost

Re: [O] Sync up the org in emacs master to org maint branch?

2017-01-31 Thread Stefan Monnier
> It is a mistake because you are creating more moving targets and bring > them together very late in the release process. This reduces the amount > of testing that is done for those packages, so bugs will be noticed > later and the quality of the relases suffer. It moves even more work > into the

Re: [O] Using CEDET modules from Emacs core

2017-02-02 Thread Stefan Monnier
SM> 2- We wanted to integrate it more tightly with Emacs (not in terms of SM> bug-tracking and releasing schedule, but in terms of making it SM> possible for generic Emacs code to use some of CEDET, and to SM> encourage more major modes and other features to use CEDET). > Can you clarify what the

Re: [O] Sync up the org in emacs master to org maint branch?

2017-02-02 Thread Stefan Monnier
> So let me try again: What I find completely misguided is to move > packages out of core *but still putting them into the release*. In other > words, in my opinion there are really just two options that make sense: > you either keep a package in core, or you kick it out and don't ship it > with

Re: [O] Using CEDET modules from Emacs core

2017-02-11 Thread Stefan Monnier
SM> For one, I'd like to see more major modes come with support for Semantic SM> right in the major mode's own definition (rather than have it part of SM> CEDET). E.g. for Elisp mode, CC-mode, ... SM> The idea is to get to the point where Semantic support is just another SM> thing that a major

Re: [O] Using CEDET modules from Emacs core

2017-02-14 Thread Stefan Monnier
>> "Semantic is too slow for C++" complaint (e.g. compared to Clang-based >> background process solutions) is unlikely to go away. > While I haven't had time to work on CEDET lately, I'd be happy to discuss > specific performance issues and share ideas on how to improve them, > presumably after

Re: [O] Sync up the org in emacs master to org maint branch?

2017-02-12 Thread Stefan Monnier
> AFAIU, the main motivation for the "drive to ELPA" comes from > developers of individual packages, not from those working on the core Not sure what you mean exactly by "drive to ELPA". If you mean "drive to put packages in GNU ELPA rather than in core", then this drive is linked to various

Re: [O] Key binding popup interface

2017-12-13 Thread Stefan Monnier
> (defhydra hydra-zoom () > "zoom" > ("g" text-scale-increase "in") > ("l" text-scale-decrease "out")) > (global-set-key (kbd "C-c") 'hydra-zoom/body) But now this one suffers from other problems: - `C-h k` does not let me directly find the binding of `C-c g`. - A `C-c a` binding in a lower

Re: [O] Key binding popup interface

2017-12-12 Thread Stefan Monnier
> Problem statement: Need to have a pretty interface that shows the available > valid key bindings. [...] > Of all those options and more that I've seen out there, hydra.el looks like > the most elegant and *configurable* option. While Hydra might include the feature you're looking for, AFAICT it

Re: [O] Key binding popup interface

2017-12-12 Thread Stefan Monnier
>> While Hydra might include the feature you're looking for, AFAICT it does >> something else than what you're looking for. > I don't follow "it does something else than what you're looking for". hydra > is used to define interfaces to temporary keymaps with well-formatted hints. I tend to think

Re: [O] General advice beyond Org

2018-05-18 Thread Stefan Monnier
> It is only when we have to collaborate directly that the issue > arises. I guess that it's a similar situation as you are having > (programming? she does not care, I can do whatever I want; publication > abstract? she wants a DOCX or DOC). Collaborating on an article does require a fairly

[O] bug#30321: 25.3; Melpa ox- packages listed as incompatible

2018-02-04 Thread Stefan Monnier
> Stefan, can you shed any light as to why Org is no longer on elpa.gnu.org? I wasn't aware of it. I'll try and investigate, Stefan

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-02 Thread Stefan Monnier
> Now that add-function sets indent-line-function to a custom closure, > however, (advice--cd*r indent-line-function) no longer returns > indent-relative and the workaround breaks. I think this qualifies as a problem in nadvice: the ad-hoc closure introduced to "redirect to the default-value"

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-11 Thread Stefan Monnier
> The third is why indent-according-to-mode hard-codes the check for > indent-relative and indent-relative-first-indent-point. Wouldn't it be > nice if this check instead looked up some variable akin to > electric-indent-functions-without-reindent, that can be more easily > customised? Agreed.

[O] Suggested patch for org-agenda.el

2019-05-06 Thread Stefan Monnier
Misc changes: - Assume Emacs≥22 (we're using defvaralias already anyway). - Try to make sure -function only contain functions (and never nil). - Use define-minor-mode and define-derived-mode. - Use command remapping. - Initialize map from within its definition. - Use suppress-keymap. There'd be

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-23 Thread Stefan Monnier
>>> The first is whether orgalist-mode couldn't use a custom >>> indent-line-function instead of advising what may or may not be set to >>> indent-relative by the user. >> I don't know how that would work in practice. > Me neither. >> But a minor mode taking control over `indent-line-function'

Re: org 9.2.6 and org 9.1.9

2019-11-26 Thread Stefan Monnier
> What should happen is that > 1) packages.el should see that I'm trying to install a package that requires > 9.2.6 as a dependency and it should notify me that 9.1.9 is already > installed and do I really want to do that, etc. > > 2) *or* just consider that it's better for me to use 9.2.6 instead

Re: org 9.2.6 and org 9.1.9

2019-11-27 Thread Stefan Monnier
> But I don't think the issue is with package.el per se. Maybe it needs fixes elsewhere as well, but it's via package.el that the problem is usually exposed. > You get the same problem if you try to install org-mode manually > without package.el. Depends how you do it. > What is really needed

Re: org 9.2.6 and org 9.1.9

2019-11-27 Thread Stefan Monnier
> Here's what I do, at the shell: > > > > emacs -Q -batch -eval "(progn (require 'package) (add-to-list > 'package-archives '(\"org\" . > \"http://orgmode.org/elpa/\;;)) > (package-initialize) (package-refresh-contents) (package-install >

Re: org 9.2.6 and org 9.1.9

2019-11-27 Thread Stefan Monnier
> [[https://lists.defectivebydesign.org/archive/html/emacs-orgmode/2012-09/msg01365.html][Installing > Org through the new http://orgmode.org ELPA]] > > - > [[https://lists.defectivebydesign.org/archive/html/emacs-orgmode/2015-08/msg00316.html][latest > org from Elpa error: Invalid function:

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Stefan Monnier
> +(defmacro org-test-with-minor-mode (mode state body) > + "Run BODY after setting MODE to STATE. > +Restore MODE to its former state afterward." > + (declare (debug (sexp sexp body)) (indent 2)) > + `(let ((old-state ,mode)) > + (,mode (if ,state 1 0)) > + ,@body > + (,mode

Re: [ANN] EmacsConf 2020 videos are out!

2020-12-05 Thread Stefan Monnier
> The EmacsConf 2020 videos are now ready. Thanks to everyone who helped > make it happen! Wow! I've been too busy with other things to pay attention to EmacsConf-2020 but the program looks terrific, thank you very much for organizing it. Stefan "downloading some videos"

Re: Microsoft Excel spreadsheet editing directly from within emacs.

2020-12-28 Thread Stefan Monnier
>> Is it possible for me to edit Microsoft Excel spreadsheet directly >> from within emacs, especially utilizing the powerful capabilities of >> orgmode? > > Not directly, but you could first save the Excel spreadsheet as CSV and > then import it into Org-Mode using M-x org-table-import. There's

Re: Bug: (org-release) returns empty string on Elpa [ ( @ /home/pierre/.guix-profile/share/emacs/site-lisp/)]

2021-01-06 Thread Stefan Monnier
>> Since the latest update to 9.4.4, some of us in Guix have been >> experiencing issues with loading packages that depend on Org [0]. It >> seems the root of the problem is that (org-release) returns an empty >> string, you can see this manifesting in this email actually :-). [...] > In between

Re: org-mode-map binds [tab]

2021-07-08 Thread Stefan Monnier
> Does outline.el need to be fixed too? [...] > ——snippet from outline.el > (defvar outline-mode-cycle-map > (let ((map (make-sparse-keymap))) >(let ((tab-binding `(menu-item > "" outline-cycle > ;; Only takes effect if point is on a heading. >

Re: More use of lexical-binding in ox.el

2021-04-27 Thread Stefan Monnier
> It looks great but it introduces a test failure, however. > > `org-export-expand-include-keyword' is called from within > `org-export-with-buffer-copy'. > > At the very beginning of `org-export-expand-include-keyword', there is > > (buffer-file-name (buffer-base-buffer)) > > Before the patch,

  1   2   >