Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-05 Thread Nicolas Goaziou
Hello, Marc Ihm writes: > Nicolas Goaziou writes: > >> >> It looks good. Could you provide a commit message? >> > > Yes, of course, albeit a bit lengthy: > > Fix handling of square brackets from timestamps and checkboxes; avoid > invalid confluence markup

Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-03 Thread Marc Ihm
Nicolas Goaziou writes: > > It looks good. Could you provide a commit message? > Yes, of course, albeit a bit lengthy: Fix handling of square brackets from timestamps and checkboxes; avoid invalid confluence markup for empty table headers. Best regards Marc

Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-02 Thread Nicolas Goaziou
Hello, Marc Ihm writes: > this is a corrected patch, which handles timestamps in a more canoncial > way. Great. Thank you. It looks good. Could you provide a commit message? Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-02 Thread Marc Ihm
Nicolas Goaziou writes: > Correcting myselfè > > Nicolas Goaziou writes: > >>> + :filters-alist '((:filter-final-output . org-confluence-fix-timestamps)) >> >> Why do you use a final filter? It is a pretty gross tool, couldn't you >> simply

Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-01 Thread Marc Ihm
Nicolas Goaziou writes: > Correcting myselfè > > Nicolas Goaziou writes: > >>> + :filters-alist '((:filter-final-output . org-confluence-fix-timestamps)) >> >> Why do you use a final filter? It is a pretty gross tool, couldn't you >> simply

Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-01 Thread Nicolas Goaziou
Correcting myselfè Nicolas Goaziou writes: >> + :filters-alist '((:filter-final-output . org-confluence-fix-timestamps)) > > Why do you use a final filter? It is a pretty gross tool, couldn't you > simply generate the correct output from the plain-list or item >

Re: [O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-03-01 Thread Nicolas Goaziou
Hello, Marc Ihm writes: > attached please find a patch for contrib/ox-confluence.el (authored by > Sébastien Delafond); the patch simply translates and fixes some selected > enhancements from ox-confluence-en.el (authored by Correl Roush). > > As a result ox-confluence.el encodes

[O] [PATCH] ox-confluence.el: Handle checkboxes and inactive timestamps correctly

2017-02-28 Thread Marc Ihm
Hello, attached please find a patch for contrib/ox-confluence.el (authored by Sébastien Delafond); the patch simply translates and fixes some selected enhancements from ox-confluence-en.el (authored by Correl Roush). As a result ox-confluence.el encodes square brackets in checkboxes or inactive