[O] bug#14374: bug#14374: Possibly incorrect custom :types
Thank you. I have already fixed the ones you sent - most were indeed issues. Regards - Carsten On 10.5.2013, at 03:26, Glenn Morris r...@gnu.org wrote: Carsten Dominik wrote: I would like to leave things in Emacs as they are and fix this with the following sync, is that acceptable? Sure, no rush. (cus-test.el is in the admin/ directory in the Emacs repo. It needs some updating, it's not checking everything at present, so there could be more of these. I will send them along if I find them.)
[O] bug#14374: bug#14374: Possibly incorrect custom :types
Thanks, I will take care of this. I would like to leave things in Emacs as they are and fix this with the following sync, is that acceptable? - Carsten On 9.5.2013, at 03:46, Glenn Morris r...@gnu.org wrote: Package: org-mode cus-test.el suggests the following variables may have incorrect custom :types. (There may be some false positives.) This refers to Org mode in current Emacs trunk. Eg, org-footnote-auto-adjust does not have nil as an option. org-refile-target-verify-function org-icalendar-combined-description org-link-frame-setup org-export-with-archived-trees org-bibtex-prefix org-log-note-headings org-structure-template-alist org-export-html-postamble-format org-get-priority-function org-export-odt-content-template-file org-export-latex-quotes org-export-html-toplevel-hlevel org-agenda-ndays org-export-initial-scope org-plantuml-jar-path org-export-blocks-witheld org-make-link-description-function org-export-html-postamble org-babel-lob-files org-agenda-export-html-style org-clock-heading-function org-show-notification-handler org-agenda-custom-commands org-beamer-outline-frame-options org-agenda-day-face-function org-use-fast-tag-selection org-export-docbook-xsl-fo-proc-command org-link-translation-function org-export-docbook-xslt-stylesheet org-export-docbook-xslt-proc-command org-columns-modify-value-for-display-function org-export-html-preamble-format org-agenda-auto-exclude-function org-export-docbook-doctype org-wl-namazu-default-index org-agenda-inactive-leader org-export-ascii-underline org-sparse-tree-default-date-type org-footnote-auto-adjust org-protocol-default-template-key
[O] bug#14374: bug#14374: Possibly incorrect custom :types
Glenn Morris r...@gnu.org writes: Hi Glenn, Thanks for this detailled report. May I ask how you did you tests? I can't find cus-test.el in my Emacs. I've attached a diff patch where I fix some of this. Package: org-mode cus-test.el suggests the following variables may have incorrect custom :types. (There may be some false positives.) This refers to Org mode in current Emacs trunk. Eg, org-footnote-auto-adjust does not have nil as an option. org-refile-target-verify-function It's a function with no function by default and I don't know how to fix it. Should we use '(choice function nil)? org-icalendar-combined-description Seems fine to me. org-link-frame-setup Patched (I've only interferred the functions name could VM users confirmed that they are correct). org-export-with-archived-trees Patched. org-bibtex-prefix It's suppose to be a string and after a quick look at the code I think it's safe to set it to nil but I'm not sure. org-log-note-headings Patched. org-structure-template-alist Patched. org-export-html-postamble-format I think it's named `org-html-postamble-format' in master. The docstring and the type talks about an alist but the default value is not. I don't know which one is correct (the default value or the description). org-get-priority-function Same problem than `org-refile-target-verify-function'. org-export-odt-content-template-file Now `org-odt-content-template-file', the type is a file but the default value is nil. Should we use '(choice file nil)? org-export-latex-quotes I couldn't find this variable in master. org-export-html-toplevel-hlevel Now `org-html-toplevel-hlevel' and it doesn't seem to be wrong. org-agenda-ndays The type is an integer but the default value is nil. Should we use '(choice integer nil)? I've just seen Carsten's mail so I'll stop here. org-export-initial-scope org-plantuml-jar-path org-export-blocks-witheld org-make-link-description-function org-export-html-postamble org-babel-lob-files org-agenda-export-html-style org-clock-heading-function org-show-notification-handler org-agenda-custom-commands org-beamer-outline-frame-options org-agenda-day-face-function org-use-fast-tag-selection org-export-docbook-xsl-fo-proc-command org-link-translation-function org-export-docbook-xslt-stylesheet org-export-docbook-xslt-proc-command org-columns-modify-value-for-display-function org-export-html-preamble-format org-agenda-auto-exclude-function org-export-docbook-doctype org-wl-namazu-default-index org-agenda-inactive-leader org-export-ascii-underline org-sparse-tree-default-date-type org-footnote-auto-adjust org-protocol-default-template-key defcustom-fixes.path Description: Binary data -- Daimrod/Greg pgp38ECem9JSK.pgp Description: PGP signature
[O] bug#14374: bug#14374: Possibly incorrect custom :types
Carsten Dominik wrote: I would like to leave things in Emacs as they are and fix this with the following sync, is that acceptable? Sure, no rush. (cus-test.el is in the admin/ directory in the Emacs repo. It needs some updating, it's not checking everything at present, so there could be more of these. I will send them along if I find them.)
