[Orgmode] Re: Bug with time summary in column view?
Hi James, James TD Smith ahktenz...@mohorovi.cc writes: I'm experiencing the same problem the OP reports (i.e., no effort or clocksum summaries) when viewing columns in the agenda. I reported this in an earlier email: http://article.gmane.org/gmane.emacs.orgmode/19937 Ah, I missed that. Sorry. I've looked into this further and found what I think was causing it. The code which calculates the summaries in the agenda was mixing up properties and titles, and failing to find the data it was supposed to be summarising. It worked if there was no title set on the column being summarised, which is why the test I did earlier seemed OK. It should be fixed now, there's a patch (b0eaeaa) for this in the bugfixes branch at git://yog-sothoth.mohorovi.cc/org-mode. Can one of you give it a try and confirm it fixes your problem? The patch fixes the problem. Thanks. - Matt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug with time summary in column view?
Norbert Zeh [2009.11.25 543 -0400]: Hi James, thanks for looking into this, and fixing it. I'd be happy to test. Just one question. If I don't want to overwrite my stable version of org mode that's installed and I choose to install the git version in a separate location, how to I instruct emacs to use the git version instead of the stable one? Cheers, Norbetr Alright, while we're at it ;), here's another somewhat unexpected behaviour. I'm not even sure this should be considered a bug, but it's more a matter of defining what the right behaviour should be. If I have an entry with an effort estimate of, say, 1:00 and it is shown in today's agenda because it is scheduled today and the deadline is in 2 days, the 1:00 time effort is counted twice in the effort summary for the day. To me, this doesn't make much sense, as it's only one task, not two. So, if I were to choose how to treat this situation, I would simply say that all entries shown because of their deadline should not be listed in this summary. Then, of course, this may not be the right rule in all situations. Any ideas how one could let the user specify on a per-column basis whether entries shown because of a deadline should be included in the summary or not? Cheers, Norbert ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: Bug with time summary in column view?
Hi James, thanks for fixing this so quickly. I have applied the patch. - Carsten On Nov 25, 2009, at 3:05 AM, James TD Smith wrote: Hi Matt and Norbert, On 2009-11-24 19:00:18(-0500), Matt Lundin wrote: James TD Smith ahktenz...@mohorovi.cc writes: On 2009-11-24 16:56:27(-0400), Norbert Zeh wrote: I just tried the latest org-mode version 6.33f, and I've run into the following problem that is not there with version 6.32b but which I can also reproduce with version 6.33c (sorry didn't try any other versions). I've just tried this with the latest org-mode from git and it seems to be working fine. There have been no changes to column view since 6.33f was tagged. I'm experiencing the same problem the OP reports (i.e., no effort or clocksum summaries) when viewing columns in the agenda. I reported this in an earlier email: http://article.gmane.org/gmane.emacs.orgmode/19937 Ah, I missed that. Sorry. I've looked into this further and found what I think was causing it. The code which calculates the summaries in the agenda was mixing up properties and titles, and failing to find the data it was supposed to be summarising. It worked if there was no title set on the column being summarised, which is why the test I did earlier seemed OK. It should be fixed now, there's a patch (b0eaeaa) for this in the bugfixes branch at git://yog-sothoth.mohorovi.cc/org-mode. Can one of you give it a try and confirm it fixes your problem? James -- |-James TD Smith-email/ahktenz...@mohorovi.cc-| ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: Bug with time summary in column view?
Hi Norbert, On 2009-11-25 08:25:08(-0400), Norbert Zeh wrote: Norbert Zeh [2009.11.25 543 -0400]: Alright, while we're at it ;), here's another somewhat unexpected behaviour. I'm not even sure this should be considered a bug, but it's more a matter of defining what the right behaviour should be. It seems like a bug to me, in that the effort summary for the day will be wrong. If I have an entry with an effort estimate of, say, 1:00 and it is shown in today's agenda because it is scheduled today and the deadline is in 2 days, the 1:00 time effort is counted twice in the effort summary for the day. To me, this doesn't make much sense, as it's only one task, not two. So, if I were to choose how to treat this situation, I would simply say that all entries shown because of their deadline should not be listed in this summary. Then, of course, this may not be the right rule in all situations. Any ideas how one could let the user specify on a per-column basis whether entries shown because of a deadline should be included in the summary or not? I think this will be quite complicated to fix. There are multiple reasons an item can appear in the agenda: active timestamps, deadlines, scheduling, and in log mode clocked time and inactive timestamps, so any solution would need to handle all of those. As far as column view is concerned each line in the agenda is a different item. If we attach a property to each line in the agenda indicating where it came from (using org ids or similar), the summary calculation code for the agenda could skip entries it had already seen, though I'm not sure it's the right thing to do for all summary types. James -- |-James TD Smith-email/ahktenz...@mohorovi.cc-| ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Re: Bug with time summary in column view?
On Nov 25, 2009, at 1:25 PM, Norbert Zeh wrote: Norbert Zeh [2009.11.25 543 -0400]: Hi James, thanks for looking into this, and fixing it. I'd be happy to test. Just one question. If I don't want to overwrite my stable version of org mode that's installed and I choose to install the git version in a separate location, how to I instruct emacs to use the git version instead of the stable one? Cheers, Norbetr Alright, while we're at it ;), here's another somewhat unexpected behaviour. I'm not even sure this should be considered a bug, but it's more a matter of defining what the right behaviour should be. If I have an entry with an effort estimate of, say, 1:00 and it is shown in today's agenda because it is scheduled today and the deadline is in 2 days, the 1:00 time effort is counted twice in the effort summary for the day. To me, this doesn't make much sense, as it's only one task, not two. So, if I were to choose how to treat this situation, I would simply say that all entries shown because of their deadline should not be listed in this summary. Then, of course, this may not be the right rule in all situations. Any ideas how one could let the user specify on a per-column basis whether entries shown because of a deadline should be included in the summary or not? This is, unfortunately, very hard to fix. A partial remedy could be (setq org-agenda-skip-scheduled-if-deadline-is-shown t) but it works the other way round, and I cannot easily make a variable org-agenda-skip-deadline-if-scheduled-is-shown. - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug with time summary in column view?
Hi James, James TD Smith ahktenz...@mohorovi.cc writes: Hi Norbert, On 2009-11-24 16:56:27(-0400), Norbert Zeh wrote: I just tried the latest org-mode version 6.33f, and I've run into the following problem that is not there with version 6.32b but which I can also reproduce with version 6.33c (sorry didn't try any other versions). I've just tried this with the latest org-mode from git and it seems to be working fine. There have been no changes to column view since 6.33f was tagged. I'm experiencing the same problem the OP reports (i.e., no effort or clocksum summaries) when viewing columns in the agenda. I reported this in an earlier email: http://article.gmane.org/gmane.emacs.orgmode/19937 I'm using the most recent git version with: GNU Emacs 23.1.1 (i386-apple-darwin9.2.1, NS apple-appkit-949.27) It also occurs on my Linux box. The behavior was introduced with the following commit: --8---cut here---start-8--- commit b81fae4c3fa39a15bda5e58016fe9dec28e38c18 Author: James TD Smith ahktenz...@mohorovi.cc Date: Tue Nov 10 02:42:17 2009 + More bugfixes for agenda column view Make org-agenda-columns-summarize work properly with the new summary types. It was assuming the values should be summarised by adding them together. It' now updated to use the summary functions in org-columns-compile-map, and als handles summary types with calculated values properly. Leave calculated columns blank if there is no underlying value. Don't return zero if a property is missing. Changes are also applied to xemacs colview. --8---cut here---end---8--- - Matt ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Bug with time summary in column view?
Hi Matt and Norbert, On 2009-11-24 19:00:18(-0500), Matt Lundin wrote: James TD Smith ahktenz...@mohorovi.cc writes: On 2009-11-24 16:56:27(-0400), Norbert Zeh wrote: I just tried the latest org-mode version 6.33f, and I've run into the following problem that is not there with version 6.32b but which I can also reproduce with version 6.33c (sorry didn't try any other versions). I've just tried this with the latest org-mode from git and it seems to be working fine. There have been no changes to column view since 6.33f was tagged. I'm experiencing the same problem the OP reports (i.e., no effort or clocksum summaries) when viewing columns in the agenda. I reported this in an earlier email: http://article.gmane.org/gmane.emacs.orgmode/19937 Ah, I missed that. Sorry. I've looked into this further and found what I think was causing it. The code which calculates the summaries in the agenda was mixing up properties and titles, and failing to find the data it was supposed to be summarising. It worked if there was no title set on the column being summarised, which is why the test I did earlier seemed OK. It should be fixed now, there's a patch (b0eaeaa) for this in the bugfixes branch at git://yog-sothoth.mohorovi.cc/org-mode. Can one of you give it a try and confirm it fixes your problem? James -- |-James TD Smith-email/ahktenz...@mohorovi.cc-| ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
