Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-27 Thread Alan Schmitt
Rasmus writes: Viktor, 1. Viktor's latest patch. 2. The patch describe above that gets user name and email and works on my system. . . Your code works for me. From my point of view, the pros are that per default `org-koma-letter-{author,sender}' pick up the values of

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-27 Thread Rasmus
Hi Xavier, 1. summarizes all changes in author. It uses my solution as mentioned above. 2. full support for after closing keywords. See commit message 3. signature to nil 4. change handling of subject and allow for setting subject in OPTION-line. I'm going to apply the patches. Thanks

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-27 Thread Viktor Rosenfeld
Hi Xavier, Xavier Garrido wrote: Hi koma-letterers, Patches: 1. summarizes all changes in author. It uses my solution as mentioned above. 2. full support for after closing keywords. See commit message 3. signature to nil 4. change handling of subject and allow for setting subject

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-27 Thread Xavier Garrido
Hi Viktor, Please check the values of `org-koma-letter-email' and `org-koma-letter-author'. They should be set to nil if you have these settings defined in an LCO file and do not want to set them in the generated TeX sources. I use such a setup and the latest master branch is working for me.

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults)

2013-05-26 Thread Viktor Rosenfeld
Hi Rasmus, Rasmus wrote: Attached are three patches that goes on top of Viktor's latest patch (I've also attached it here since I rebased stuff and might have changed it by accident). 1. Viktor's latest patch. 2. The patch describe above that gets user name and email and works

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-26 Thread Viktor Rosenfeld
Hi Rasmus, Rasmus wrote: Rasmus ras...@gmx.us writes: 4. Sets defcustom org-koma-letter-signature nil since that corresponds to default scrlttr2 behavior anyway (p. 183 in the manual). Re 4.: I'd like to do something similar to org-koma-letter-subject-format. But I'm

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-26 Thread Rasmus
Viktor, 1. Viktor's latest patch. 2. The patch describe above that gets user name and email and works on my system. . . Your code works for me. From my point of view, the pros are that per default `org-koma-letter-{author,sender}' pick up the values of `user-full-name' and

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-26 Thread Rasmus
Viktor Rosenfeld listuse...@gmail.com writes: I'm also not a big fan of the title defaulting to the filename. But I think it is a minor issue. What I think is quite useful is setting the subject to the headline of the exported subtree. Wouldn't we also lose this if subject is nil? Without

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-26 Thread Rasmus
As a side note, I had quite a few problems working with your patches. None of them applied against master, or against my latest patch as you claimed. I had to merge in some of the changes of 0002 by hand. I suggest that we nail down the workings of AUTHOR and EMAIL first (should be done now)

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup

2013-05-25 Thread Rasmus
Rasmus ras...@gmx.us writes: 4. Sets defcustom org-koma-letter-signature nil since that corresponds to default scrlttr2 behavior anyway (p. 183 in the manual). Re 4.: I'd like to do something similar to org-koma-letter-subject-format. But I'm not sure how, at the moment