Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > I've seen you didn't apply the part which added an entry in ORG-NEWS > file. Was this deliberate or just an side effect of your refactoring ? > Or is this unneeded ? > Again thanks for your patience. I had to remove that change

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello nicolas, Many thanks for your patience and for applying my patch. I've seen you didn't apply the part which added an entry in ORG-NEWS file. Was this deliberate or just an side effect of your refactoring ? Or is this unneeded ? Again thanks for your patience. Nicolas Goaziou writes: >

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > Hello Nicolas, > I'm sorry for the delay, this problem drove me crazy for a few days. > So I started again from the beginning and, of course, I am now unable to > replicate my original test case. > So, I think you could delete the

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello Nicolas, I'm sorry for the delay, this problem drove me crazy for a few days. So I started again from the beginning and, of course, I am now unable to replicate my original test case. So, I think you could delete the 0001-Manage-the-encoding-of-files-with-include-.patch patch. I am really

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > I've used the following command to do the test : > for emacs 25.3 > > #+begin_src sh > emacs -Q -L lisp -L ~/.emacs.d/elpa-25/htmlize-20180412.1244 -l > ~/.emacs.d/elpa-25/htmlize-20180412.1244/htmlize-autoloads.el >

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello Nicolas, it's really strange. I've checked it another time some minutes ago and, on my machine, this works. I've used the following command to do the test : for emacs 25.3 #+begin_src sh emacs -Q -L lisp -L ~/.emacs.d/elpa-25/htmlize-20180412.1244 -l

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > I reattach the examples, but note that the cmd.txt or sh.txt extensions > are only there to avoid my mail to be wiped out. I must be missing something. When I install both patches, and I export your example to, e.g., UTF-8, I get

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, And sorry for the delay. Nicolas Goaziou writes: > Hello, > > pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > >> Hello Nicolas, >> Did you have time to review the patches ? > > Sorry for the delay, I have been sidetracked. > > I admit I don't fully

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > Hello Nicolas, > Did you have time to review the patches ? Sorry for the delay, I have been sidetracked. I admit I don't fully understand your bugfix patch, i.e., "[PATCH] Correctly convert encoding of included files". For the

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello Nicolas, Did you have time to review the patches ? pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > Hello, > Nicolas Goaziou writes: > >> Hello, >> >> pierre.techouey...@free.fr (Pierre Téchoueyres) writes: >> >>> I think I've corrected all points.

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, Nicolas Goaziou writes: > Hello, > > pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > >> I think I've corrected all points. You'll find new versions attached. > > Thank you. > >> Would you mind consider to include the patch for the detection of >>

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > I think I've corrected all points. You'll find new versions attached. Thank you. > Would you mind consider to include the patch for the detection of > encoding with the #+include keyword in 9.2 release ? This patch is still

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello Nicolas, I think I've corrected all points. You'll find new versions attached. Would you mind consider to include the patch for the detection of encoding with the #+include keyword in 9.2 release ? >From e4d6cf8f9959781c682738a4b9e5ea8ae5747b6b Mon Sep 17 00:00:00 2001 From:

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > I did my homework : found a fix for a) and rebased previous patch on > master. Thank you. Some comments follow. > * lisp/ox.el (org-export-expand-include-keyword): Add new keyword > `:coding' for specify the file encoding whith

Re: [O] [PATCH] Add new keyword :coding for #+include directive

pierre.techouey...@free.fr (Pierre Téchoueyres) writes: Hello, > ... >> ... >> Is it really an Org problem? E.g., couldn't you put a coding: cookie in >> your ".cmd" file? IMO, the coding system depends on the includee, not >> the includer. > > I tend to aggree with you that TRTDT is to put

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, Nicolas Goaziou writes: > Hello, > ... >> This allow you to specify something like >> >> #+begin_example >> ,#+INCLUDE: "myfile.cmd" src cmd :coding "cp850-dos" >> #+end_example > > The quotes are not necessary. AFAICT, coding systems do not contain > spaces. Ok,

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > I want to propose the attached patch which allow you to specify an > optionnal `:coding' keyword to the `#+INCLUDE:' directive. Thank you. > This allow you to specify something like > > #+begin_example > ,#+INCLUDE: "myfile.cmd"

Re: [O] [PATCH] Add new keyword :coding for #+include directive

Hello org's developpers, Sorry, I forgot the patch. so here is the whole mail + patch: I want to propose the attached patch which allow you to specify an optionnal `:coding' keyword to the `#+INCLUDE:' directive. This allow you to specify something like #+begin_example ,#+INCLUDE: "myfile.cmd"