Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2012-02-18 Thread Peter Münster
On Thu, Nov 24 2011, Nick Dokos wrote: > Are they free variable warnings? If so, you now know how to fix them: > go wild :-) All right, done so... ;) -- Peter

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-23 Thread Nick Dokos
Peter Münster wrote: > On Wed, Nov 23 2011, Nick Dokos wrote: > > > Generally speaking, defvars like this tell the compiler to shut up about > > the "free" variable. You can see if it is needed, by commenting out the > > defvar and then trying to compile the file. > > Indeed, now there are 30 w

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-23 Thread Peter Münster
On Wed, Nov 23 2011, Nick Dokos wrote: > Generally speaking, defvars like this tell the compiler to shut up about > the "free" variable. You can see if it is needed, by commenting out the > defvar and then trying to compile the file. Indeed, now there are 30 warnings instead of only 29 ... ;) Tha

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-23 Thread Nick Dokos
Peter Münster wrote: > On Wed, Nov 23 2011, Carsten Dominik wrote: > > > Fixed, thanks, please verify. > > Verified: ok, thanks. > > Is `(defvar parse-time-weekdays)' still needed then? And if yes, why? > Generally speaking, defvars like this tell the compiler to shut up about the "free" var

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-23 Thread Peter Münster
On Wed, Nov 23 2011, Carsten Dominik wrote: > Fixed, thanks, please verify. Verified: ok, thanks. Is `(defvar parse-time-weekdays)' still needed then? And if yes, why? -- Peter

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-22 Thread Carsten Dominik
Fixed, thanks, please verify. - Carsten On 23.11.2011, at 07:14, Peter Münster wrote: > On Tue, Nov 22 2011, Carsten Dominik wrote: > >> This is not allowed, we cannot define a variable defined in another package. > > Oh, pardon. > > >> Can you send a backtrace of the error, please? > > Of

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-22 Thread Peter Münster
On Tue, Nov 22 2011, Carsten Dominik wrote: > This is not allowed, we cannot define a variable defined in another package. Oh, pardon. > Can you send a backtrace of the error, please? Of course (from "emacs -Q"): --8<---cut here---start->8--- Debugger enter

Re: [O] [PATCH] Avoid lisp error with (org-deadline nil "+1d")

2011-11-22 Thread Carsten Dominik
On 21.11.2011, at 23:39, Peter Münster wrote: > * lisp/org.el (parse-time-weekdays): Must not be void. > > TINYCHANGE > --- > lisp/org.el |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lisp/org.el b/lisp/org.el > index 253703b..41d418a 100644 > --- a/lisp/org.el >